asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in asterixdb[master]: Fix for Issue 929
Date Fri, 14 Aug 2015 20:17:46 GMT
Ian Maxon has posted comments on this change.

Change subject: Fix for Issue 929
......................................................................


Patch Set 1:

(3 comments)

A few thoughts...

https://asterix-gerrit.ics.uci.edu/#/c/354/1/asterix-app/src/main/java/edu/uci/ics/asterix/aql/translator/AqlTranslator.java
File asterix-app/src/main/java/edu/uci/ics/asterix/aql/translator/AqlTranslator.java:

Line 2036:             System.out.println("numnber of active connections " + activeConnections.size());
This shouldn't be printed to stdout. This seems like it belongs at logging level debug or
maybe trace.


Line 2046:                 System.out.println("Attempt to drop feed");
See comment for line 2034.


https://asterix-gerrit.ics.uci.edu/#/c/354/1/asterix-doc/src/site/markdown/feeds/tutorial.md
File asterix-doc/src/site/markdown/feeds/tutorial.md:

Line 65:         (("type-name"="Tweet"));
So I'm a bit confused here- How does this fix the issue where the credentials are not necessarily
baked into the instance? How does this show me how to properly provide my OAuth credentials
to the adapter?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/354
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5521287a4fa1818c78a4f83b1a3cabeea8e6096d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Raman Grover <ramangrover29@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: Yes

Mime
View raw message