asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Young-Seok Kim (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in hyracks[master]: Optimized the binary tokenizer - get the total number of tok...
Date Wed, 12 Aug 2015 01:27:11 GMT
Young-Seok Kim has posted comments on this change.

Change subject: Optimized the binary tokenizer - get the total number of tokens Change-Id:
Ifa9a18a43a097766da22633bb48371ffc78406ae
......................................................................


Patch Set 2:

(1 comment)

One minor comment regarding code readability.

https://asterix-gerrit.ics.uci.edu/#/c/348/2/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/invertedindex/tokenizers/DelimitedUTF8StringBinaryTokenizer.java
File hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/invertedindex/tokenizers/DelimitedUTF8StringBinaryTokenizer.java:

Line 82:             boolean previousCharIsNonSeparator = false;
It seems easier to change the above variable to previousCharIsSeparator instead of having
double negative semantic variable.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/348
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa9a18a43a097766da22633bb48371ffc78406ae
Gerrit-PatchSet: 2
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message