asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Jacobs (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in asterixdb[master]: Changed metadata storage format for nullable field types. Mo...
Date Tue, 11 Aug 2015 16:34:27 GMT
Steven Jacobs has posted comments on this change.

Change subject: Changed metadata storage format for nullable field types. Moved field name
generation to the client out of metadata node code. Changed naming scheme for autogenerated
types.
......................................................................


Patch Set 8:

(1 comment)

A few of the new changes are not clear for me, specifically on MetadataNode (please see comment).

https://asterix-gerrit.ics.uci.edu/#/c/323/8/asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataNode.java
File asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataNode.java:

Line 522
It's not clear to me why checks like this are being removed.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/323
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I223aded8aaf80f0688358899c0e8b0d6988fac93
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dtabass@gmail.com>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message