asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Young-Seok Kim (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in hyracks[master]: This change includes: 1. avoid calling ByteBuffer.get() and ...
Date Sun, 09 Aug 2015 18:09:27 GMT
Young-Seok Kim has posted comments on this change.

Change subject: This change includes: 1. avoid calling ByteBuffer.get() and ByteBuffer.put()
for bloom filter set/get operations. ByteBuffer will check boundaries of the index for get/put.
It's a very frequent operation. 2. let the hash table size in BufferCache be 3X of
......................................................................


Patch Set 1: Code-Review+1

MAP_FACTOR change in buffercache from 2 to 3 doesn't seem to have a reasonable reason behind,
but the original 2 also didn't seem to have the reason for that. 
Other than that, LGTM.  
What do you think Ian?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/345
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd47c410338ce557a494ab3605660bad1899e786
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-HasComments: No

Mime
View raw message