asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Young-Seok Kim (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in hyracks[master]: improve the buffer cache perf. with 1) a better hash functio...
Date Thu, 06 Aug 2015 16:52:32 GMT
Young-Seok Kim has posted comments on this change.

Change subject: improve the buffer cache perf. with 1) a better hash function for fileid-pageid,
2) reduce synchronization in clock page replacement policy.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

I added one comment.
Other than that, it looks good to me.

https://asterix-gerrit.ics.uci.edu/#/c/342/1/hyracks/hyracks-storage-am-lsm-common/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
File hyracks/hyracks-storage-am-lsm-common/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java:

Line 190:         return hashValue % buckets.length;
As buffercache's pageMap.length is incremented by 1, the buckets.length can be incremented
by 1 in order to have odd number modular base.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/342
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I296c589a556a9afa7f27c6f560fa07fc4e2c1861
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message