asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ian Maxon <ima...@uci.edu>
Subject Re: Change in asterixdb[master]: Fix really bad typo in POM
Date Fri, 31 Jul 2015 23:42:48 GMT
Also, many thanks to Taewoo for raising the red flag on this. It could
have easily slipped by for longer, which could have led to far greater
pain.

On Fri, Jul 31, 2015 at 4:41 PM, Ian Maxon <imaxon@uci.edu> wrote:
> To fill everyone in on this:
> There was a typo in the introspection change, that was actually
> excluding all of the execution tests ( 😨 ), which is definitely bad!
> Thankfully though, it only looks like one test was failing despite
> this hole. I went ahead and took the liberty of fixing the one test
> result that was incorrect (verified between Taewoo and I), and
> disabling the one that seems to have a deeper issue thatis part of the
> introspection test suite.
>
> -Ian
>
> On Fri, Jul 31, 2015 at 4:18 PM, Ian Maxon (Code Review)
> <do-not-reply@unhygienix.ics.uci.edu> wrote:
>> Ian Maxon has submitted this change and it was merged.
>>
>> Change subject: Fix really bad typo in POM
>> ......................................................................
>>
>>
>> Fix really bad typo in POM
>>
>> - One change to a UUID result which doesn't correspond to its query
>> - Disable the one introspection test case that fails temporarily
>>
>> Change-Id: I4e62a505754967c590f195bd997aba44ddb5a535
>> Reviewed-on: https://asterix-gerrit.ics.uci.edu/340
>> Reviewed-by: Taewoo Kim <wangsaeu@gmail.com>
>> Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
>> ---
>> M asterix-app/src/test/resources/runtimets/queries/records/RecordsQueries.xml
>> M asterix-app/src/test/resources/runtimets/results/dml/insert-with-autogenerated-pk_adm_03/insert-with-autogenerated-pk_adm_03.1.adm
>> M pom.xml
>> 3 files changed, 5 insertions(+), 5 deletions(-)
>>
>> Approvals:
>>   Taewoo Kim: Looks good to me, approved
>>   Jenkins: Verified
>>
>>
>>
>> diff --git a/asterix-app/src/test/resources/runtimets/queries/records/RecordsQueries.xml
b/asterix-app/src/test/resources/runtimets/queries/records/RecordsQueries.xml
>> index 283cdea..9fec682 100644
>> --- a/asterix-app/src/test/resources/runtimets/queries/records/RecordsQueries.xml
>> +++ b/asterix-app/src/test/resources/runtimets/queries/records/RecordsQueries.xml
>> @@ -52,11 +52,11 @@
>>                  <output-dir compare="Text">documentation-example</output-dir>
>>              </compilation-unit>
>>          </test-case>
>> -        <test-case FilePath="records/get-record-fields">
>> +        <!--test-case FilePath="records/get-record-fields">
>>              <compilation-unit name="tiny-social-example">
>>                  <output-dir compare="Text">tiny-social-example</output-dir>
>>              </compilation-unit>
>> -        </test-case>
>> +        </test-case!-->
>>          <test-case FilePath="records/get-record-fields">
>>              <compilation-unit name="tiny-social-example-no-complex-types">
>>                  <output-dir compare="Text">tiny-social-example-no-complex-types</output-dir>
>> @@ -124,4 +124,4 @@
>>                  <output-dir compare="Text">open-open-fieldname-conflict_issue173</output-dir>
>>                  <expected-error>edu.uci.ics.asterix.common.exceptions.AsterixException</expected-error>
>>              </compilation-unit>
>> -        </test-case>
>> \ No newline at end of file
>> +        </test-case>
>> diff --git a/asterix-app/src/test/resources/runtimets/results/dml/insert-with-autogenerated-pk_adm_03/insert-with-autogenerated-pk_adm_03.1.adm
b/asterix-app/src/test/resources/runtimets/results/dml/insert-with-autogenerated-pk_adm_03/insert-with-autogenerated-pk_adm_03.1.adm
>> index fb77d5f..01a114f 100644
>> --- a/asterix-app/src/test/resources/runtimets/results/dml/insert-with-autogenerated-pk_adm_03/insert-with-autogenerated-pk_adm_03.1.adm
>> +++ b/asterix-app/src/test/resources/runtimets/results/dml/insert-with-autogenerated-pk_adm_03/insert-with-autogenerated-pk_adm_03.1.adm
>> @@ -1,2 +1,2 @@
>> -[ "OQL[C++]  Extending C++ with an Object Query Capability."
>> +[ { "id": uuid("89fb1567-70f8-4e59-87d9-ace64f73daf1"), "dblpid": "books/acm/kim95/Blakeley95",
"title": "OQL[C++]  Extending C++ with an Object Query Capability.", "authors": "José A.
Blakeley", "misc": "2002-01-03 69-88 Modern Database Systems db/books/collections/kim95.html#Blakeley95
1995" }
>>   ]
>> diff --git a/pom.xml b/pom.xml
>> index 6f4217e..1c16a4f 100644
>> --- a/pom.xml
>> +++ b/pom.xml
>> @@ -41,7 +41,7 @@
>>          <optimizer.tests>**/optimizer/**/*Test.java</optimizer.tests>
>>          <metadata.tests>**/metadata/*Test.java</metadata.tests>
>>          <execution.tests>**/ExecutionTest.java</execution.tests>
>> -        <repeated.tests>**/ExecutionTest.java</repeated.tests>
>> +        <repeated.tests>**/RepeatedTest.java</repeated.tests>
>>          <invalid.tests>**/DmlTest.java</invalid.tests>
>>          <global.test.includes>**/*TestSuite.java,**/*Test.java,${execution.tests}</global.test.includes>
>>          <global.test.excludes>${optimizer.tests},${metadata.tests},${invalid.tests},${repeated.tests}</global.test.excludes>
>>
>> --
>> To view, visit https://asterix-gerrit.ics.uci.edu/340
>> To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
>>
>> Gerrit-MessageType: merged
>> Gerrit-Change-Id: I4e62a505754967c590f195bd997aba44ddb5a535
>> Gerrit-PatchSet: 3
>> Gerrit-Project: asterixdb
>> Gerrit-Branch: master
>> Gerrit-Owner: Ian Maxon <imaxon@apache.org>
>> Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
>> Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
>> Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>

Mime
View raw message