asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taewoo Kim (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in asterixdb[master]: Added the UUID constructor and changed the relevant document...
Date Tue, 28 Jul 2015 16:02:03 GMT
Taewoo Kim has posted comments on this change.

Change subject: Added the UUID constructor and changed the relevant documentation
......................................................................


Patch Set 3:

(5 comments)

Thank you for your comments. I have modified the code and will upload the new code soon.

https://asterix-gerrit.ics.uci.edu/#/c/326/3/asterix-runtime/src/main/java/edu/uci/ics/asterix/runtime/evaluators/constructors/AUUIDFromStringConstructorDescriptor.java
File asterix-runtime/src/main/java/edu/uci/ics/asterix/runtime/evaluators/constructors/AUUIDFromStringConstructorDescriptor.java:

Line 45:  */
> Not sure how all the indentation got changed to tabs. It should be 3 spaces
Done


Line 104: 								msb <<= 16;
> The 9 here is kind of 'magic', hard to know it's actually skipping the hyph
OK. I will add a comment and replace it by offset +=8; offset += 1;


Line 111: 								msb <<= 16;
> Shouldn't this be msb <<=8?
I believe this is correct. Please check the original implementation of UUID.fromString() at:

http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/util/UUID.java


Line 150: 								tmpLongVal = tmpLongVal * 16 + tmpIntVal;
> Why *16?
It's a hex value, not a decimal value.


Line 161: 					private int transformHexCharToInt(byte val)
> Cool. This should be fast hopefully. I believe switch/cases beyond a certai
I hope so, too.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/326
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2276bf2b44975b13c99d56f448ae3e9e4a74b04e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message