asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in asterixdb[master]: Added the UUID constructor and changed the relevant document...
Date Thu, 23 Jul 2015 23:48:20 GMT
Ian Maxon has posted comments on this change.

Change subject: Added the UUID constructor and changed the relevant documentation
......................................................................


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/326/1/asterix-runtime/src/main/java/edu/uci/ics/asterix/runtime/evaluators/constructors/AUUIDStringConstructorDescriptor.java
File asterix-runtime/src/main/java/edu/uci/ics/asterix/runtime/evaluators/constructors/AUUIDStringConstructorDescriptor.java:

Line 84:                                 aUUID.fromStringToAMuatbleUUID(new String(serString,
outInput.getStartOffset() + 3, outInput.getLength() - 3));
Is constructing a new string here "OK"? Isn't this proportional object allocation?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/326
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2276bf2b44975b13c99d56f448ae3e9e4a74b04e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: Yes

Mime
View raw message