asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in hyracks[master]: Introducing data replication API to LSM indexes
Date Thu, 23 Jul 2015 09:32:02 GMT
Murtadha Hubail has posted comments on this change.

Change subject: Introducing data replication API to LSM indexes
......................................................................


Patch Set 2:

(4 comments)

Thanks guys for the review. I addressed your comments in patch 3.

https://asterix-gerrit.ics.uci.edu/#/c/322/2/hyracks/hyracks-api/src/main/java/edu/uci/ics/hyracks/api/replication/IIOReplicationManager.java
File hyracks/hyracks-api/src/main/java/edu/uci/ics/hyracks/api/replication/IIOReplicationManager.java:

Line 25:     public boolean isReplicationEnable();
> Nit- name should be plural
Changed to isReplicationEnabled()


https://asterix-gerrit.ics.uci.edu/#/c/322/2/hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/impls/ExternalBTreeWithBuddy.java
File hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/impls/ExternalBTreeWithBuddy.java:

Line 889: 
> This type of indexes, have three components
Done


https://asterix-gerrit.ics.uci.edu/#/c/322/2/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java
File hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java:

Line 955:         
> @Ian
Done


https://asterix-gerrit.ics.uci.edu/#/c/322/2/hyracks/hyracks-storage-common/src/main/java/edu/uci/ics/hyracks/storage/common/buffercache/IBufferCache.java
File hyracks/hyracks-storage-common/src/main/java/edu/uci/ics/hyracks/storage/common/buffercache/IBufferCache.java:

Line 55:     
> If all BufferCaches don't do any replication, why are the methods below int
It is implemented in BufferCache and used by AbstractLSMIndex constructors to pass the flag
to the LSMHarness layer.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80565fc9d74e30440d2df5917911904ba8f33c25
Gerrit-PatchSet: 2
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message