asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in hyracks[master]: This change reduce object creation and instead re-use object...
Date Wed, 22 Jul 2015 09:18:17 GMT
abdullah alamoudi has posted comments on this change.

Change subject: This change reduce object creation and instead re-use objects when doing inserts,
deletes or searches in btrees and rtrees.
......................................................................


Patch Set 1:

(8 comments)

https://asterix-gerrit.ics.uci.edu/#/c/245/1/hyracks/hyracks-storage-am-btree/src/main/java/edu/uci/ics/hyracks/storage/am/btree/impls/BTree.java
File hyracks/hyracks-storage-am-btree/src/main/java/edu/uci/ics/hyracks/storage/am/btree/impls/BTree.java:

Line 864:      * for now, we are reusing it while it is an inner class !!!!
> White Space
Done


https://asterix-gerrit.ics.uci.edu/#/c/245/1/hyracks/hyracks-storage-am-btree/src/main/java/edu/uci/ics/hyracks/storage/am/btree/impls/BTreeRangeSearchCursor.java
File hyracks/hyracks-storage-am-btree/src/main/java/edu/uci/ics/hyracks/storage/am/btree/impls/BTreeRangeSearchCursor.java:

Line 318:     public boolean isBloomFilterAware(){
> White Space
Done


https://asterix-gerrit.ics.uci.edu/#/c/245/1/hyracks/hyracks-storage-am-btree/src/main/java/edu/uci/ics/hyracks/storage/am/btree/impls/RangePredicate.java
File hyracks/hyracks-storage-am-btree/src/main/java/edu/uci/ics/hyracks/storage/am/btree/impls/RangePredicate.java:

Line 60:             boolean highKeyInclusive, MultiComparator lowKeyCmp, MultiComparator
highKeyCmp) {
> White Space
Done


https://asterix-gerrit.ics.uci.edu/#/c/245/1/hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/impls/LSMBTreeOpContext.java
File hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/impls/LSMBTreeOpContext.java:

Line 117:         
> White Space
Done


https://asterix-gerrit.ics.uci.edu/#/c/245/1/hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyAbstractCursor.java
File hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyAbstractCursor.java:

Line 128:                 btreeAccessors[i].reset(btree, NoOpOperationCallback.INSTANCE, NoOpOperationCallback.INSTANCE);//
= btree.createAccessor(NoOpOperationCallback.INSTANCE, NoOpOperationCallback.INSTANCE);
> Should this comment stay here?
Done


https://asterix-gerrit.ics.uci.edu/#/c/245/1/hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyCursorInitialState.java
File hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyCursorInitialState.java:

Line 113: 	
> White Space, 	
Done


https://asterix-gerrit.ics.uci.edu/#/c/245/1/hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddySortedCursor.java
File hyracks/hyracks-storage-am-lsm-btree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddySortedCursor.java:

Line 33: 
> Did this page get the Asterix Formatting?
Done


https://asterix-gerrit.ics.uci.edu/#/c/245/1/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/rtree/impls/LSMRTreeAbstractCursor.java
File hyracks/hyracks-storage-am-lsm-rtree/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/rtree/impls/LSMRTreeAbstractCursor.java:

Line 65
> I'm not sure why you no longer need to call super() here
super() is called automatically and there is no need for it to be explicitly written here.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/245
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fab280372951522db02f8c2ff1d7d5b15529cd7
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message