asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in asterixdb[master]: This change includes the following: 1. allowing short-circui...
Date Wed, 22 Jul 2015 06:49:49 GMT
abdullah alamoudi has posted comments on this change.

Change subject: This change includes the following: 1. allowing short-circuit reads to be
used with external data. 2. enhancing behaviour of index access for Text data. 3. updating
the external data documentation.
......................................................................


Patch Set 7:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/218/7/asterix-external-data/src/main/java/edu/uci/ics/asterix/external/adapter/factory/HDFSAdapterFactory.java
File asterix-external-data/src/main/java/edu/uci/ics/asterix/external/adapter/factory/HDFSAdapterFactory.java:

Line 89: 
> That is true. we have them in multiple locations. I will move them to the r
On another thought, These are only present here and publicly accessible by all other classes
which use them. I don't think that they are available anywhere else and I think that this
is not a terrible place to have them.

Let me know if you still think this should be fixed.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/218
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I041c71391d8704cd800c4446a085beef197e7acf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Raman Grover <ramangrover29@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message