asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in asterixdb[master]: This change includes the following: 1. allowing short-circui...
Date Wed, 22 Jul 2015 06:23:14 GMT
abdullah alamoudi has posted comments on this change.

Change subject: This change includes the following: 1. allowing short-circuit reads to be
used with external data. 2. enhancing behaviour of index access for Text data. 3. updating
the external data documentation.
......................................................................


Patch Set 7:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/218/7/asterix-app/src/main/java/edu/uci/ics/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
File asterix-app/src/main/java/edu/uci/ics/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java:

Line 128:         // why are we not stopping the feed server here?
> Yes, I  believe we should. Please piggyback this change too.
Will do.


https://asterix-gerrit.ics.uci.edu/#/c/218/7/asterix-app/src/test/resources/runtimets/queries/hdfs/hdfs_shortcircuit/hdfs_shortcircuit.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/hdfs/hdfs_shortcircuit/hdfs_shortcircuit.1.ddl.aql:

Line 20: (("hdfs"="hdfs://127.0.0.1:31888"),("path"="/asterix/textFileS"),("input-format"="sequence-input-format"),("format"="delimited-text"),("delimiter"="."),("local-socket-path"="/var/lib/hadoop-hdfs/dn_socket"));
> what's local-socket-path? It is not intuitive to me :(
the local socket path is a data communications endpoint for exchanging data between the reader
and the DataNode running on the same host. It is used to get information about physical files
corresponding to HDFS blocks so they can be read directly.


https://asterix-gerrit.ics.uci.edu/#/c/218/7/asterix-external-data/src/main/java/edu/uci/ics/asterix/external/adapter/factory/HDFSAdapterFactory.java
File asterix-external-data/src/main/java/edu/uci/ics/asterix/external/adapter/factory/HDFSAdapterFactory.java:

Line 89: 
> I think, these constants need to live outside this class as these are at a 
That is true. we have them in multiple locations. I will move them to the right place.


https://asterix-gerrit.ics.uci.edu/#/c/218/7/asterix-external-data/src/main/java/edu/uci/ics/asterix/external/indexing/input/HDFSSeekableLineReader.java
File asterix-external-data/src/main/java/edu/uci/ics/asterix/external/indexing/input/HDFSSeekableLineReader.java:

Line 103:         this(in, conf.getInt("io.file.buffer.size", DEFAULT_BUFFER_SIZE));
> Use a constant string
Will do


Line 126:      */
> Awesome comments for method signature :)
Haha. I agree :D


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/218
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I041c71391d8704cd800c4446a085beef197e7acf
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Raman Grover <ramangrover29@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message