asterixdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jianfeng Jia (Code Review)" <do-not-re...@asterix-gerrit.ics.uci.edu>
Subject Change in hyracks[master]: allow btree search to read unregistered indexes.
Date Wed, 22 Jul 2015 05:44:44 GMT
Jianfeng Jia has posted comments on this change.

Change subject: allow btree search to read unregistered indexes.
......................................................................


Patch Set 1:

(3 comments)

I have only one question about the destroy API. Other than that I just take this CR as an
opportunity to understand more about the system designs, so I left some questions about the
existing code that I'm not familiar with. Thanks for answering them!

https://asterix-gerrit.ics.uci.edu/#/c/324/1/hyracks/hyracks-dataflow-std/src/main/java/edu/uci/ics/hyracks/dataflow/std/file/FileSplit.java
File hyracks/hyracks-dataflow-std/src/main/java/edu/uci/ics/hyracks/dataflow/std/file/FileSplit.java:

Line 32:         this.ioDeviceId = 0;
Just curiously, does ioDeviceId = 0 mean the default location of this file is in the first
device?


https://asterix-gerrit.ics.uci.edu/#/c/324/1/hyracks/hyracks-storage-am-common/src/main/java/edu/uci/ics/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java
File hyracks/hyracks-storage-am-common/src/main/java/edu/uci/ics/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java:

Line 121:         synchronized (lcManager) {
Can it also destroy the index that not created by itself? Do we view the external index as
a readonly instance?


https://asterix-gerrit.ics.uci.edu/#/c/324/1/hyracks/hyracks-storage-common/src/main/java/edu/uci/ics/hyracks/storage/common/file/TransientLocalResourceFactoryProvider.java
File hyracks/hyracks-storage-common/src/main/java/edu/uci/ics/hyracks/storage/common/file/TransientLocalResourceFactoryProvider.java:

Line 20:     public static TransientLocalResourceFactoryProvider INSTANCE = new TransientLocalResourceFactoryProvider();
Just curious to understand our system, can we have two node Hyracks node on the same machine?
I vaguely remember it can, but I'm not sure. In that case, this `TransientLocalResourceFactoryProvider`
can be shared by multiple nodes, right?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/324
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7cc7752dd7b6d5261ff02d591f25d76d442a1c
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message