asterixdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mb...@apache.org
Subject asterixdb git commit: ASTERIXDB-1570: "Unable to find free page in buffer cache after 1000 cycles"
Date Mon, 07 Nov 2016 18:06:32 GMT
Repository: asterixdb
Updated Branches:
  refs/heads/master 314c0df16 -> 9af8a4b55


ASTERIXDB-1570: "Unable to find free page in buffer cache after 1000 cycles"

Increase test buffer cache size to reliably accomodate 20M values

Change-Id: I620de9ade875f7f7de26aa7495d9fd873824ac83
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1346
Sonar-Qube: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Till Westmann <tillw@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/asterixdb/repo
Commit: http://git-wip-us.apache.org/repos/asf/asterixdb/commit/9af8a4b5
Tree: http://git-wip-us.apache.org/repos/asf/asterixdb/tree/9af8a4b5
Diff: http://git-wip-us.apache.org/repos/asf/asterixdb/diff/9af8a4b5

Branch: refs/heads/master
Commit: 9af8a4b559cb6274d1842d786725705f404155d2
Parents: 314c0df
Author: Michael Blow <mblow@apache.org>
Authored: Mon Nov 7 07:59:52 2016 -0500
Committer: Michael Blow <mblow@apache.org>
Committed: Mon Nov 7 10:06:06 2016 -0800

----------------------------------------------------------------------
 .../src/main/resources/asterix-build-configuration.xml   |  8 ++++----
 .../results/api/cluster_state_1/cluster_state_1.1.adm    |  2 +-
 .../java/org/apache/asterix/test/aql/TestExecutor.java   |  3 +--
 .../hyracks/storage/common/buffercache/BufferCache.java  | 11 ++++++-----
 4 files changed, 12 insertions(+), 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/asterixdb/blob/9af8a4b5/asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
----------------------------------------------------------------------
diff --git a/asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml b/asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
index ef0cdf2..90dbe5f 100644
--- a/asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
+++ b/asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
@@ -74,15 +74,15 @@
     <name>storage.buffercache.pagesize</name>
     <value>32KB</value>
     <description>The page size in bytes for pages in the buffer cache.
-      (Default = "32768" // 32KB)
+      (Default = "128KB")
     </description>
   </property>
   <property>
     <name>storage.buffercache.size</name>
-    <value>32MB</value>
+    <value>48MB</value>
     <description>The size of memory allocated to the disk buffer cache.
-      The value should be a multiple of the buffer cache page size(Default
-      = "33554432" // 32MB)
+      The value should be a multiple of the buffer cache page size
+      (Default = "512MB")
     </description>
   </property>
   <property>

http://git-wip-us.apache.org/repos/asf/asterixdb/blob/9af8a4b5/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
----------------------------------------------------------------------
diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
index 649f1e8..a20b1a7 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
@@ -55,7 +55,7 @@
         "plot.activate": false,
         "storage.buffercache.maxopenfiles": 2147483647,
         "storage.buffercache.pagesize": 32768,
-        "storage.buffercache.size": 33554432,
+        "storage.buffercache.size": 50331648,
         "storage.lsm.bloomfilter.falsepositiverate": 0.01,
         "storage.memorycomponent.globalbudget": 536870912,
         "storage.memorycomponent.numcomponents": 2,

http://git-wip-us.apache.org/repos/asf/asterixdb/blob/9af8a4b5/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
----------------------------------------------------------------------
diff --git a/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
b/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
index c6da1c0..4080325 100644
--- a/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
+++ b/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
@@ -185,8 +185,7 @@ public class TestExecutor {
             }
             lineActual = readerActual.readLine();
             if (lineActual != null) {
-                throw new ComparisonException(
-                        "Result for " + scriptFile + " changed at line " + num + ":\n<
\n> " + lineActual);
+                throwLineChanged(scriptFile, "<EOF>", lineActual, num);
             }
         } catch (Exception e) {
             System.err.println("Actual results file: " + actualFile.toString());

http://git-wip-us.apache.org/repos/asf/asterixdb/blob/9af8a4b5/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
----------------------------------------------------------------------
diff --git a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
index ed33cc4..8ff9ab6 100644
--- a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
+++ b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
@@ -1248,7 +1248,7 @@ public class BufferCache implements IBufferCacheInternal, ILifeCycleComponent
{
 
     private ICachedPage getPageLoop(long dpid, int multiplier, boolean confiscate)
             throws HyracksDataException {
-        final long startingPinCount = masterPinCount.get();
+        final long startingPinCount = DEBUG ? masterPinCount.get() : -1;
         int cycleCount = 0;
         try {
             while (true) {
@@ -1291,15 +1291,16 @@ public class BufferCache implements IBufferCacheInternal, ILifeCycleComponent
{
                 if (cycleCount > MAX_PIN_ATTEMPT_CYCLES) {
                     cycleCount = 0; // suppress warning below
                     throw new HyracksDataException("Unable to find free page in buffer cache
after "
-                            + MAX_PIN_ATTEMPT_CYCLES + " cycles (buffer cache undersized?);
"
-                            + (masterPinCount.get() - startingPinCount) + " successful pins
since start of cycle");
+                            + MAX_PIN_ATTEMPT_CYCLES + " cycles (buffer cache undersized?)"
+ (DEBUG ? " ; "
+                            + (masterPinCount.get() - startingPinCount) + " successful pins
since start of cycle"
+                            : ""));
                 }
             }
         } finally {
             if (cycleCount > PIN_ATTEMPT_CYCLES_WARNING_THRESHOLD && LOGGER.isLoggable(Level.WARNING))
{
                 LOGGER.warning("Took " + cycleCount + " cycles to find free page in buffer
cache.  (buffer cache " +
-                        "undersized?); " + (masterPinCount.get() - startingPinCount) +
-                        " successful pins since start of cycle");
+                        "undersized?)" + (DEBUG ? " ; " + (masterPinCount.get() - startingPinCount)
+
+                        " successful pins since start of cycle" : ""));
             }
         }
     }


Mime
View raw message