asterixdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From buyin...@apache.org
Subject [4/4] incubator-asterixdb git commit: Clean up compilation warnings.
Date Sat, 21 Nov 2015 21:21:25 GMT
Clean up compilation warnings.

Change-Id: Idbfcd9c67f91d373c5f7269125778a5681021227
Reviewed-on: https://asterix-gerrit.ics.uci.edu/505
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: abdullah alamoudi <bamousaa@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/commit/18a9dca5
Tree: http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/tree/18a9dca5
Diff: http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/diff/18a9dca5

Branch: refs/heads/master
Commit: 18a9dca536b621251dfa68032861291a41506d7f
Parents: 939e186
Author: Yingyi Bu <buyingyi@gmail.com>
Authored: Sat Nov 21 11:27:51 2015 -0800
Committer: Yingyi Bu <buyingyi@gmail.com>
Committed: Sat Nov 21 13:17:49 2015 -0800

----------------------------------------------------------------------
 .../operators/physical/CommitRuntime.java       |   2 -
 .../asterix/optimizer/base/AnalysisUtil.java    |   7 +-
 .../asterix/api/http/servlet/FeedServlet.java   |  10 +-
 .../api/http/servlet/FeedServletUtil.java       |   2 +
 .../api/http/servlet/ShutdownAPIServlet.java    |  17 +--
 .../api/http/servlet/VersionAPIServlet.java     |  20 ++--
 .../asterix/feeds/FeedLifecycleListener.java    |   6 +-
 .../asterix/feeds/FeedMetadataManager.java      |   2 +
 .../feeds/FeedWorkRequestResponseHandler.java   |   6 +-
 .../bootstrap/ExternalLibraryBootstrap.java     |  34 +++---
 .../org/apache/asterix/result/ResultUtils.java  |  22 ++--
 .../asterix/test/runtime/HDFSCluster.java       |  30 +----
 .../annotations/RecordDataGenAnnotation.java    |   2 +-
 .../common/api/AsterixThreadExecutor.java       |   4 +-
 .../common/config/AsterixBuildProperties.java   |  13 ++-
 .../config/AsterixPropertiesAccessor.java       |  19 ++--
 .../context/TransactionSubsystemProvider.java   |   2 +
 .../asterix/common/feeds/CollectionRuntime.java |   7 +-
 .../common/feeds/DistributeFeedFrameWriter.java |  11 +-
 .../common/feeds/FeedFrameDiscarder.java        |   8 +-
 .../asterix/common/feeds/FeedFrameHandlers.java |   7 +-
 .../common/feeds/FeedMetricCollector.java       |   2 -
 .../common/feeds/FeedRuntimeInputHandler.java   |  20 ++--
 .../common/feeds/FeedStorageStatistics.java     |  27 -----
 .../asterix/common/feeds/FrameDistributor.java  |  15 +--
 .../common/feeds/IntakePartitionStatistics.java |  28 ++---
 .../asterix/common/feeds/MonitoredBuffer.java   |  12 +-
 .../common/feeds/NodeLoadReportService.java     |  10 +-
 .../feeds/StorageSideMonitoredBuffer.java       |  15 +--
 .../common/feeds/SubscribableFeedRuntimeId.java |   2 +-
 .../api/IFeedLifecycleEventSubscriber.java      |   1 -
 .../asterix/event/driver/EventDriver.java       |   7 +-
 .../asterix/event/error/OutputHandler.java      |   3 +
 .../asterix/event/management/EventExecutor.java |  14 +--
 .../apache/asterix/event/model/BackupInfo.java  |   1 +
 .../adapter/factory/CNNFeedAdapterFactory.java  |   9 +-
 .../factory/PullBasedTwitterAdapterFactory.java |  11 +-
 .../external/dataset/adapter/HDFSAdapter.java   |  20 ++--
 .../dataset/adapter/NCFileSystemAdapter.java    |   2 -
 .../adapter/PushBasedTwitterFeedClient.java     |  12 +-
 .../dataflow/HDFSIndexingParserFactory.java     |  13 +--
 .../indexing/dataflow/HDFSLookupAdapter.java    |  20 ++--
 .../indexing/dataflow/IndexingScheduler.java    |  45 ++++----
 .../input/AbstractHDFSLookupInputStream.java    |  11 +-
 .../indexing/input/AbstractHDFSReader.java      |   4 +-
 .../input/GenericFileAwareRecordReader.java     |  24 ++--
 .../indexing/input/GenericRecordReader.java     |   6 +-
 .../indexing/input/RCFileDataReader.java        |  12 +-
 .../indexing/input/TextualDataReader.java       |  14 +--
 .../external/library/ExternalFunction.java      |   6 +-
 .../ExternalFunctionDescriptorProvider.java     |   3 +-
 .../library/ExternalFunctionProvider.java       |   3 +-
 .../external/library/JTypeObjectFactory.java    |   2 +
 .../external/library/ResultCollector.java       |  28 +----
 .../external/library/java/JObjectAccessors.java |  75 ++++++-------
 .../external/library/java/JObjectUtil.java      |  22 ++--
 .../asterix/external/library/java/JObjects.java |  52 ++++-----
 .../fuzzyjoin/FuzzyJoinAppendLength.java        |   6 +-
 .../asterix/fuzzyjoin/FuzzyJoinTokenize.java    |  10 +-
 .../asterix/fuzzyjoin/MutableInteger.java       |   2 +-
 .../fuzzyjoin/tests/FuzzyJoinTestUtil.java      |  10 +-
 .../asterix/installer/error/OutputHandler.java  |   3 +
 .../test/AsterixInstallerIntegrationUtil.java   |  15 +--
 .../metadata/bootstrap/MetadataRecordTypes.java |  26 ++---
 .../asterix/metadata/entities/Function.java     |   2 +-
 .../FeedPolicyTupleTranslator.java              |   9 +-
 .../feeds/FeedIntakeOperatorNodePushable.java   |  30 ++---
 .../feeds/FeedMessageOperatorNodePushable.java  |  18 +--
 .../apache/asterix/metadata/feeds/FeedUtil.java |  29 ++---
 .../feeds/RemoteSocketMessageListener.java      |  50 +--------
 .../metadata/feeds/SocketMessageListener.java   |   4 +-
 .../functions/MetadataBuiltinFunctions.java     |  10 +-
 .../DatasetNameValueExtractor.java              |   1 -
 .../management/ReplicationManager.java          |  30 ++---
 .../stream/EmptyStreamAggregateDescriptor.java  |   2 +-
 .../accessors/CircleCenterAccessor.java         |   1 -
 ...BinaryBase64StringConstructorDescriptor.java |  17 ++-
 .../ABinaryHexStringConstructorDescriptor.java  |  12 +-
 .../functions/AbstractBinaryStringBoolEval.java |   2 -
 .../functions/PrefixLenJaccardDescriptor.java   |   5 +-
 .../functions/StringEqualDescriptor.java        |   2 +-
 .../functions/StringLengthDescriptor.java       |   4 +-
 .../binary/BinaryConcatDescriptor.java          |  13 ++-
 .../binary/BinaryLengthDescriptor.java          |  17 ++-
 .../functions/binary/FindBinaryDescriptor.java  |  32 +++---
 .../binary/FindBinaryFromDescriptor.java        |  10 +-
 .../functions/binary/ParseBinaryDescriptor.java |  10 +-
 .../functions/binary/PrintBinaryDescriptor.java |  10 +-
 .../binary/SubBinaryFromDescriptor.java         |  22 ++--
 .../binary/SubBinaryFromToDescriptor.java       |   6 +-
 .../runtime/operators/file/ADMDataParser.java   |  59 +++++-----
 .../operators/file/AbstractDataParser.java      |   5 +-
 .../external/data/SocketClientAdapter.java      |   6 +-
 .../data/SocketClientAdapterFactory.java        |   3 +-
 .../data/TwitterFirehoseFeedAdapter.java        |   2 -
 .../data/TwitterFirehoseFeedAdapterFactory.java |  11 +-
 ...tractIndexModificationOperationCallback.java |   8 +-
 .../resource/LSMBTreeLocalResourceMetadata.java |   1 -
 .../service/locking/ConcurrentLockManager.java  | 110 +++++++++++--------
 .../locking/LockManagerRandomUnitTest.java      |  23 ++--
 .../service/locking/ResourceTablePrinter.java   |  11 +-
 .../locking/WaitInterruptedException.java       |   2 +
 .../service/logging/LogBufferTailReader.java    |   1 -
 .../management/service/logging/LogManager.java  |   7 +-
 .../service/transaction/TransactionContext.java |   4 +-
 .../TransactionSubsystemProvider.java           |  39 -------
 .../org/apache/asterix/aoya/HDFSBackup.java     |  18 +--
 .../aoya/test/AsterixYARNInstanceUtil.java      |  10 +-
 .../aoya/test/AsterixYARNLifecycleIT.java       |  37 +------
 .../apache/asterix/aoya/test/YARNCluster.java   |  19 +---
 110 files changed, 660 insertions(+), 918 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java
----------------------------------------------------------------------
diff --git a/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java b/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java
index 6f3078e..92cd61a 100644
--- a/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java
+++ b/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java
@@ -42,7 +42,6 @@ public class CommitRuntime implements IPushRuntime {
 
     private final static long SEED = 0L;
 
-    private final IHyracksTaskContext hyracksTaskCtx;
     private final ITransactionManager transactionManager;
     private final ILogManager logMgr;
     private final JobId jobId;
@@ -59,7 +58,6 @@ public class CommitRuntime implements IPushRuntime {
 
     public CommitRuntime(IHyracksTaskContext ctx, JobId jobId, int datasetId, int[] primaryKeyFields,
             boolean isTemporaryDatasetWriteJob, boolean isWriteTransaction) {
-        this.hyracksTaskCtx = ctx;
         IAsterixAppRuntimeContext runtimeCtx = (IAsterixAppRuntimeContext) ctx.getJobletContext()
                 .getApplicationContext().getApplicationObject();
         this.transactionManager = runtimeCtx.getTransactionSubsystem().getTransactionManager();

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/AnalysisUtil.java
----------------------------------------------------------------------
diff --git a/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/AnalysisUtil.java b/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/AnalysisUtil.java
index 3e2d26d..0a66013 100644
--- a/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/AnalysisUtil.java
+++ b/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/AnalysisUtil.java
@@ -21,11 +21,9 @@ package org.apache.asterix.optimizer.base;
 import java.util.ArrayList;
 import java.util.List;
 
-import org.apache.hyracks.algebricks.core.algebra.operators.logical.AbstractDataSourceOperator;
-import org.apache.commons.lang3.mutable.Mutable;
-
 import org.apache.asterix.metadata.declared.AqlSourceId;
 import org.apache.asterix.om.functions.AsterixBuiltinFunctions;
+import org.apache.commons.lang3.mutable.Mutable;
 import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException;
 import org.apache.hyracks.algebricks.common.utils.Pair;
 import org.apache.hyracks.algebricks.core.algebra.base.ILogicalExpression;
@@ -35,8 +33,8 @@ import org.apache.hyracks.algebricks.core.algebra.base.LogicalOperatorTag;
 import org.apache.hyracks.algebricks.core.algebra.expressions.AbstractFunctionCallExpression;
 import org.apache.hyracks.algebricks.core.algebra.expressions.AbstractLogicalExpression;
 import org.apache.hyracks.algebricks.core.algebra.functions.FunctionIdentifier;
+import org.apache.hyracks.algebricks.core.algebra.operators.logical.AbstractDataSourceOperator;
 import org.apache.hyracks.algebricks.core.algebra.operators.logical.AbstractLogicalOperator;
-import org.apache.hyracks.algebricks.core.algebra.operators.logical.DataSourceScanOperator;
 
 public class AnalysisUtil {
     /*
@@ -133,6 +131,7 @@ public class AnalysisUtil {
     }
 
     private static List<FunctionIdentifier> fieldAccessFunctions = new ArrayList<FunctionIdentifier>();
+
     static {
         fieldAccessFunctions.add(AsterixBuiltinFunctions.GET_DATA);
         fieldAccessFunctions.add(AsterixBuiltinFunctions.GET_HANDLE);

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
----------------------------------------------------------------------
diff --git a/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java b/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
index b118fb7..35efcb1 100644
--- a/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
+++ b/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServlet.java
@@ -128,8 +128,8 @@ public class FeedServlet extends HttpServlet {
         String store = activity.getFeedActivityDetails().get(FeedActivityDetails.STORAGE_LOCATIONS);
 
         IFeedLoadManager loadManager = CentralFeedManager.getInstance().getFeedLoadManager();
-        FeedConnectionId connectionId = new FeedConnectionId(new FeedId(activity.getDataverseName(),
-                activity.getFeedName()), activity.getDatasetName());
+        FeedConnectionId connectionId = new FeedConnectionId(
+                new FeedId(activity.getDataverseName(), activity.getFeedName()), activity.getDatasetName());
         int intakeRate = loadManager.getOutflowRate(connectionId, FeedRuntimeType.COLLECT) * intake.split(",").length;
         int storeRate = loadManager.getOutflowRate(connectionId, FeedRuntimeType.STORE) * store.split(",").length;
 
@@ -158,13 +158,7 @@ public class FeedServlet extends HttpServlet {
         html.append("</tr>");
     }
 
-    private String insertLink(StringBuilder html, String url, String displayText) {
-        return ("<a href=\"" + url + "\">" + displayText + "</a>");
-    }
-
     private String insertColoredText(String s, String color) {
         return "<font color=\"" + color + "\">" + s + "</font>";
     }
 }
-
-

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
----------------------------------------------------------------------
diff --git a/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java b/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
index fe20f51..f1473f4 100644
--- a/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
+++ b/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/FeedServletUtil.java
@@ -59,6 +59,8 @@ public class FeedServletUtil {
             ch = (char) in.read();
         }
         buffer.flip();
+        sc.close();
+
         String s = new String(buffer.array());
         int feedSubscriptionPort = Integer.parseInt(s.trim());
         if (LOGGER.isLoggable(Level.INFO)) {

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java
----------------------------------------------------------------------
diff --git a/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java b/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java
index f5b5cbb..7585fd3 100644
--- a/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java
+++ b/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java
@@ -30,11 +30,9 @@ import javax.servlet.http.HttpServlet;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
-import org.apache.commons.io.IOUtils;
-
-import org.apache.asterix.api.common.SessionConfig.OutputFormat;
 import org.apache.asterix.common.config.GlobalConfig;
 import org.apache.asterix.result.ResultUtils;
+import org.apache.commons.io.IOUtils;
 import org.apache.hyracks.api.client.IHyracksClientConnection;
 
 public class ShutdownAPIServlet extends HttpServlet {
@@ -42,23 +40,14 @@ public class ShutdownAPIServlet extends HttpServlet {
 
     private static final String HYRACKS_CONNECTION_ATTR = "org.apache.asterix.HYRACKS_CONNECTION";
 
-    private static final String HYRACKS_DATASET_ATTR = "org.apache.asterix.HYRACKS_DATASET";
-
     @Override
-    protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException,
-            IOException {
+    protected void doPost(HttpServletRequest request, HttpServletResponse response)
+            throws ServletException, IOException {
 
         response.setContentType("application/json");
         response.setCharacterEncoding("utf-8");
 
         PrintWriter out = response.getWriter();
-        OutputFormat format = OutputFormat.LOSSLESS_JSON;
-        String accept = request.getHeader("Accept");
-        if ((accept == null) || (accept.contains("application/x-adm"))) {
-            format = OutputFormat.ADM;
-        } else if (accept.contains("application/json")) {
-            format = OutputFormat.LOSSLESS_JSON;
-        }
         StringWriter sw = new StringWriter();
         IOUtils.copy(request.getInputStream(), sw, StandardCharsets.UTF_8.name());
 

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/VersionAPIServlet.java
----------------------------------------------------------------------
diff --git a/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/VersionAPIServlet.java b/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/VersionAPIServlet.java
index f98bb06..424421a 100644
--- a/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/VersionAPIServlet.java
+++ b/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/VersionAPIServlet.java
@@ -18,24 +18,20 @@
  */
 package org.apache.asterix.api.http.servlet;
 
-import org.apache.asterix.api.common.SessionConfig;
-import org.apache.asterix.common.config.AsterixBuildProperties;
-import org.apache.asterix.common.config.AsterixPropertiesAccessor;
-import org.apache.asterix.hyracks.bootstrap.CCApplicationEntryPoint;
-import org.apache.asterix.om.util.AsterixAppContextInfo;
-import org.apache.hadoop.http.HttpServer;
-import org.json.JSONObject;
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.util.Map;
 
 import javax.servlet.ServletContext;
 import javax.servlet.http.HttpServlet;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
-import java.io.IOException;
-import java.io.PrintWriter;
-import java.util.Map;
 
-public class VersionAPIServlet extends HttpServlet {
+import org.apache.asterix.om.util.AsterixAppContextInfo;
+import org.json.JSONObject;
 
+public class VersionAPIServlet extends HttpServlet {
+    private static final long serialVersionUID = 1L;
     public static final String ASTERIX_BUILD_PROP_ATTR = "org.apache.asterix.PROPS";
 
     @Override
@@ -45,7 +41,7 @@ public class VersionAPIServlet extends HttpServlet {
         Map<String, String> buildProperties = props.getBuildProperties().getAllProps();
         JSONObject responseObject = new JSONObject(buildProperties);
         response.setCharacterEncoding("utf-8");
-        PrintWriter responseWriter =  response.getWriter();
+        PrintWriter responseWriter = response.getWriter();
         responseWriter.write(responseObject.toString());
         response.setStatus(HttpServletResponse.SC_OK);
         responseWriter.flush();

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-app/src/main/java/org/apache/asterix/feeds/FeedLifecycleListener.java
----------------------------------------------------------------------
diff --git a/asterix-app/src/main/java/org/apache/asterix/feeds/FeedLifecycleListener.java b/asterix-app/src/main/java/org/apache/asterix/feeds/FeedLifecycleListener.java
index 202451b..d53428d 100644
--- a/asterix-app/src/main/java/org/apache/asterix/feeds/FeedLifecycleListener.java
+++ b/asterix-app/src/main/java/org/apache/asterix/feeds/FeedLifecycleListener.java
@@ -146,7 +146,7 @@ public class FeedLifecycleListener implements IFeedLifecycleListener {
     }
 
     /*
-     * Traverse job specification to categorize job as a feed intake job or a feed collection job 
+     * Traverse job specification to categorize job as a feed intake job or a feed collection job
      */
     @Override
     public void notifyJobCreation(JobId jobId, IActivityClusterGraphGeneratorFactory acggf) throws HyracksException {
@@ -333,6 +333,8 @@ public class FeedLifecycleListener implements IFeedLifecycleListener {
                     }
                 }
                 break;
+            default:
+                break;
         }
 
     }
@@ -473,10 +475,12 @@ public class FeedLifecycleListener implements IFeedLifecycleListener {
         return feedJobNotificationHandler.getFeedJoint(feedJointKey);
     }
 
+    @Override
     public void registerFeedEventSubscriber(FeedConnectionId connectionId, IFeedLifecycleEventSubscriber subscriber) {
         feedJobNotificationHandler.registerFeedEventSubscriber(connectionId, subscriber);
     }
 
+    @Override
     public void deregisterFeedEventSubscriber(FeedConnectionId connectionId, IFeedLifecycleEventSubscriber subscriber) {
         feedJobNotificationHandler.deregisterFeedEventSubscriber(connectionId, subscriber);
 

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-app/src/main/java/org/apache/asterix/feeds/FeedMetadataManager.java
----------------------------------------------------------------------
diff --git a/asterix-app/src/main/java/org/apache/asterix/feeds/FeedMetadataManager.java b/asterix-app/src/main/java/org/apache/asterix/feeds/FeedMetadataManager.java
index 4acc1d4..81cabeb 100644
--- a/asterix-app/src/main/java/org/apache/asterix/feeds/FeedMetadataManager.java
+++ b/asterix-app/src/main/java/org/apache/asterix/feeds/FeedMetadataManager.java
@@ -103,6 +103,8 @@ public class FeedMetadataManager implements IFeedMetadataManager {
                 case STRING:
                     sb.append("\"" + ((AString) record.getValueByPos(i)).getStringValue() + "\"");
                     break;
+                default:
+                    break;
             }
         }
         sb.append(" }");

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-app/src/main/java/org/apache/asterix/feeds/FeedWorkRequestResponseHandler.java
----------------------------------------------------------------------
diff --git a/asterix-app/src/main/java/org/apache/asterix/feeds/FeedWorkRequestResponseHandler.java b/asterix-app/src/main/java/org/apache/asterix/feeds/FeedWorkRequestResponseHandler.java
index d3ee4ef..3686a03 100644
--- a/asterix-app/src/main/java/org/apache/asterix/feeds/FeedWorkRequestResponseHandler.java
+++ b/asterix-app/src/main/java/org/apache/asterix/feeds/FeedWorkRequestResponseHandler.java
@@ -100,8 +100,8 @@ public class FeedWorkRequestResponseHandler implements Runnable {
                         }
                     }
                     if (unsubstitutedNodes.size() > 0) {
-                        String[] participantNodes = AsterixClusterProperties.INSTANCE.getParticipantNodes().toArray(
-                                new String[] {});
+                        String[] participantNodes = AsterixClusterProperties.INSTANCE.getParticipantNodes()
+                                .toArray(new String[] {});
                         nodeIndex = 0;
                         for (String unsubstitutedNode : unsubstitutedNodes) {
                             nodeSubstitution.put(unsubstitutedNode, participantNodes[nodeIndex]);
@@ -226,6 +226,8 @@ public class FeedWorkRequestResponseHandler implements Runnable {
                         }
                     }
                     break;
+                default:
+                    break;
             }
         }
 

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ExternalLibraryBootstrap.java
----------------------------------------------------------------------
diff --git a/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ExternalLibraryBootstrap.java b/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ExternalLibraryBootstrap.java
index ff5e591..51d857a 100755
--- a/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ExternalLibraryBootstrap.java
+++ b/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ExternalLibraryBootstrap.java
@@ -100,8 +100,8 @@ public class ExternalLibraryBootstrap {
         return uninstalledLibs;
     }
 
-    private static boolean uninstallLibrary(String dataverse, String libraryName) throws AsterixException,
-            RemoteException, ACIDException {
+    private static boolean uninstallLibrary(String dataverse, String libraryName)
+            throws AsterixException, RemoteException, ACIDException {
         MetadataTransactionContext mdTxnCtx = null;
         try {
             mdTxnCtx = MetadataManager.INSTANCE.beginTransaction();
@@ -120,8 +120,8 @@ public class ExternalLibraryBootstrap {
                     .getDataverseFunctions(mdTxnCtx, dataverse);
             for (org.apache.asterix.metadata.entities.Function function : functions) {
                 if (function.getName().startsWith(libraryName + "#")) {
-                    MetadataManager.INSTANCE.dropFunction(mdTxnCtx, new FunctionSignature(dataverse,
-                            function.getName(), function.getArity()));
+                    MetadataManager.INSTANCE.dropFunction(mdTxnCtx,
+                            new FunctionSignature(dataverse, function.getName(), function.getArity()));
                 }
             }
 
@@ -156,8 +156,8 @@ public class ExternalLibraryBootstrap {
         MetadataManager.INSTANCE.acquireWriteLatch();
         try {
             mdTxnCtx = MetadataManager.INSTANCE.beginTransaction();
-            org.apache.asterix.metadata.entities.Library libraryInMetadata = MetadataManager.INSTANCE.getLibrary(
-                    mdTxnCtx, dataverse, libraryName);
+            org.apache.asterix.metadata.entities.Library libraryInMetadata = MetadataManager.INSTANCE
+                    .getLibrary(mdTxnCtx, dataverse, libraryName);
             if (libraryInMetadata != null && !wasUninstalled) {
                 return;
             }
@@ -190,9 +190,9 @@ public class ExternalLibraryBootstrap {
                         args.add(arg);
                     }
                     org.apache.asterix.metadata.entities.Function f = new org.apache.asterix.metadata.entities.Function(
-                            dataverse, libraryName + "#" + function.getName().trim(), args.size(), args, function
-                                    .getReturnType().trim(), function.getDefinition().trim(), library.getLanguage()
-                                    .trim(), function.getFunctionType().trim());
+                            dataverse, libraryName + "#" + function.getName().trim(), args.size(), args,
+                            function.getReturnType().trim(), function.getDefinition().trim(),
+                            library.getLanguage().trim(), function.getFunctionType().trim());
                     MetadataManager.INSTANCE.addFunction(mdTxnCtx, f);
                     if (LOGGER.isLoggable(Level.INFO)) {
                         LOGGER.info("Installed function: " + libraryName + "#" + function.getName().trim());
@@ -221,8 +221,8 @@ public class ExternalLibraryBootstrap {
                 LOGGER.info("Installed adapters contain in library :" + libraryName);
             }
 
-            MetadataManager.INSTANCE.addLibrary(mdTxnCtx, new org.apache.asterix.metadata.entities.Library(dataverse,
-                    libraryName));
+            MetadataManager.INSTANCE.addLibrary(mdTxnCtx,
+                    new org.apache.asterix.metadata.entities.Library(dataverse, libraryName));
 
             if (LOGGER.isLoggable(Level.INFO)) {
                 LOGGER.info("Added library " + libraryName + "to Metadata");
@@ -240,8 +240,8 @@ public class ExternalLibraryBootstrap {
         }
     }
 
-    private static void registerLibrary(String dataverse, String libraryName, boolean isMetadataNode, File installLibDir)
-            throws Exception {
+    private static void registerLibrary(String dataverse, String libraryName, boolean isMetadataNode,
+            File installLibDir) throws Exception {
         ClassLoader classLoader = getLibraryClassLoader(dataverse, libraryName);
         ExternalLibraryManager.registerLibraryClassLoader(dataverse, libraryName, classLoader);
     }
@@ -261,8 +261,10 @@ public class ExternalLibraryBootstrap {
                     + " Install Directory: " + installDir.getAbsolutePath());
         }
 
-        File libDir = new File(installDir.getAbsolutePath() + File.separator + dataverse + File.separator + libraryName);
+        File libDir = new File(
+                installDir.getAbsolutePath() + File.separator + dataverse + File.separator + libraryName);
         FilenameFilter jarFileFilter = new FilenameFilter() {
+            @Override
             public boolean accept(File dir, String name) {
                 return name.endsWith(".jar");
             }
@@ -288,12 +290,12 @@ public class ExternalLibraryBootstrap {
         ClassLoader parentClassLoader = ExternalLibraryBootstrap.class.getClassLoader();
         URL[] urls = new URL[numDependencies];
         int count = 0;
-        urls[count++] = libJar.toURL();
+        urls[count++] = libJar.toURI().toURL();
 
         if (libraryDependencies != null && libraryDependencies.length > 0) {
             for (String dependency : libraryDependencies) {
                 File file = new File(libDependencyDir + File.separator + dependency);
-                urls[count++] = file.toURL();
+                urls[count++] = file.toURI().toURL();
             }
         }
 

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
----------------------------------------------------------------------
diff --git a/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java b/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
index 391f61b..5ebbe2c 100644
--- a/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
+++ b/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
@@ -30,15 +30,11 @@ import java.util.Map;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
-import org.apache.http.ParseException;
-import org.json.JSONArray;
-import org.json.JSONException;
-import org.json.JSONObject;
-
 import org.apache.asterix.api.common.SessionConfig;
 import org.apache.asterix.api.common.SessionConfig.OutputFormat;
 import org.apache.asterix.api.http.servlet.APIServlet;
 import org.apache.asterix.om.types.ARecordType;
+import org.apache.http.ParseException;
 import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException;
 import org.apache.hyracks.api.comm.IFrame;
 import org.apache.hyracks.api.comm.IFrameTupleAccessor;
@@ -46,6 +42,9 @@ import org.apache.hyracks.api.comm.VSizeFrame;
 import org.apache.hyracks.api.exceptions.HyracksDataException;
 import org.apache.hyracks.control.nc.resources.memory.FrameManager;
 import org.apache.hyracks.dataflow.common.comm.util.ByteBufferInputStream;
+import org.json.JSONArray;
+import org.json.JSONException;
+import org.json.JSONObject;
 
 public class ResultUtils {
     private static final Charset UTF_8 = Charset.forName("UTF-8");
@@ -92,8 +91,7 @@ public class ResultUtils {
 
     public static FrameManager resultDisplayFrameMgr = new FrameManager(ResultReader.FRAME_SIZE);
 
-    public static void displayResults(ResultReader resultReader, SessionConfig conf)
-            throws HyracksDataException {
+    public static void displayResults(ResultReader resultReader, SessionConfig conf) throws HyracksDataException {
         IFrameTupleAccessor fta = resultReader.getFrameTupleAccessor();
 
         IFrame frame = new VSizeFrame(resultDisplayFrameMgr);
@@ -107,8 +105,8 @@ public class ResultUtils {
 
         // If we're outputting CSV with a header, the HTML header was already
         // output by displayCSVHeader(), so skip it here
-        if (conf.is(SessionConfig.FORMAT_HTML) &&
-            ! (conf.fmt() == OutputFormat.CSV && conf.is(SessionConfig.FORMAT_CSV_HEADER))) {
+        if (conf.is(SessionConfig.FORMAT_HTML)
+                && !(conf.fmt() == OutputFormat.CSV && conf.is(SessionConfig.FORMAT_CSV_HEADER))) {
             conf.out().println("<h4>Results:</h4>");
             conf.out().println("<pre>");
         }
@@ -125,6 +123,8 @@ public class ResultUtils {
                     wrap_array = true;
                 }
                 break;
+            default:
+                break;
         }
 
         if (bytesRead > 0) {
@@ -140,7 +140,7 @@ public class ResultUtils {
                         byte[] recordBytes = new byte[length];
                         int numread = bbis.read(recordBytes, 0, length);
                         if (conf.fmt() == OutputFormat.CSV) {
-                            if ( (numread > 0) && (recordBytes[numread-1] == '\n') ) {
+                            if ((numread > 0) && (recordBytes[numread - 1] == '\n')) {
                                 numread--;
                             }
                         }
@@ -270,7 +270,7 @@ public class ResultUtils {
         //try returning the class without package qualification
         String exceptionClassName = hierarchySplits[hierarchySplits.length - 1];
         String localizedMessage = cause.getLocalizedMessage();
-        if(localizedMessage == null){
+        if (localizedMessage == null) {
             localizedMessage = "Internal error. Please check instance logs for further details.";
         }
         return localizedMessage + " [" + exceptionClassName + "]";

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-app/src/test/java/org/apache/asterix/test/runtime/HDFSCluster.java
----------------------------------------------------------------------
diff --git a/asterix-app/src/test/java/org/apache/asterix/test/runtime/HDFSCluster.java b/asterix-app/src/test/java/org/apache/asterix/test/runtime/HDFSCluster.java
index 6d2de65..9961dc8 100644
--- a/asterix-app/src/test/java/org/apache/asterix/test/runtime/HDFSCluster.java
+++ b/asterix-app/src/test/java/org/apache/asterix/test/runtime/HDFSCluster.java
@@ -26,17 +26,13 @@ import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.fs.Path;
 import org.apache.hadoop.hdfs.MiniDFSCluster;
 import org.apache.hadoop.hdfs.server.common.HdfsServerConstants.StartupOption;
-import org.apache.hadoop.mapred.InputSplit;
 import org.apache.hadoop.mapred.JobConf;
 
-import org.apache.asterix.external.dataset.adapter.HDFSAdapter;
-
 /**
  * Manages a Mini (local VM) HDFS cluster with a configured number of datanodes.
  *
  * @author ramangrover29
  */
-@SuppressWarnings("deprecation")
 public class HDFSCluster {
 
     private static final String PATH_TO_HADOOP_CONF = "src/test/resources/hadoop/conf";
@@ -68,7 +64,7 @@ public class HDFSCluster {
         conf.addResource(new Path(PATH_TO_HADOOP_CONF + "/mapred-site.xml"));
         conf.addResource(new Path(PATH_TO_HADOOP_CONF + "/hdfs-site.xml"));
         cleanupLocal();
-        //this constructor is deprecated in hadoop 2x 
+        //this constructor is deprecated in hadoop 2x
         //dfsCluster = new MiniDFSCluster(nameNodePort, conf, numDataNodes, true, true, StartupOption.REGULAR, null);
         MiniDFSCluster.Builder build = new MiniDFSCluster.Builder(conf);
         build.nameNodePort(nameNodePort);
@@ -104,28 +100,4 @@ public class HDFSCluster {
         }
     }
 
-    public static void main(String[] args) throws Exception {
-        HDFSCluster cluster = new HDFSCluster();
-        cluster.setup();
-        JobConf conf = configureJobConf();
-        FileSystem fs = FileSystem.get(conf);
-        InputSplit[] inputSplits = conf.getInputFormat().getSplits(conf, 0);
-        for (InputSplit split : inputSplits) {
-            System.out.println("split :" + split);
-        }
-        //   cluster.cleanup();
-    }
-
-    private static JobConf configureJobConf() throws Exception {
-        JobConf conf = new JobConf();
-        String hdfsUrl = "hdfs://127.0.0.1:31888";
-        String hdfsPath = "/asterix/extrasmalltweets.txt";
-        conf.set("fs.default.name", hdfsUrl);
-        conf.set("fs.hdfs.impl", "org.apache.hadoop.hdfs.DistributedFileSystem");
-        conf.setClassLoader(HDFSAdapter.class.getClassLoader());
-        conf.set("mapred.input.dir", hdfsPath);
-        conf.set("mapred.input.format.class", "org.apache.hadoop.mapred.TextInputFormat");
-        return conf;
-    }
-
 }

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/annotations/RecordDataGenAnnotation.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/annotations/RecordDataGenAnnotation.java b/asterix-common/src/main/java/org/apache/asterix/common/annotations/RecordDataGenAnnotation.java
index e22e85c..f478a4e 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/annotations/RecordDataGenAnnotation.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/annotations/RecordDataGenAnnotation.java
@@ -21,7 +21,7 @@ package org.apache.asterix.common.annotations;
 import java.io.Serializable;
 
 public class RecordDataGenAnnotation implements IRecordTypeAnnotation, Serializable {
-
+    private static final long serialVersionUID = 1L;
     private final IRecordFieldDataGen[] declaredFieldsDatagen;
     private final UndeclaredFieldsDataGen undeclaredFieldsDataGen;
 

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/api/AsterixThreadExecutor.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/api/AsterixThreadExecutor.java b/asterix-common/src/main/java/org/apache/asterix/common/api/AsterixThreadExecutor.java
index 24a260f..befeb48 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/api/AsterixThreadExecutor.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/api/AsterixThreadExecutor.java
@@ -37,7 +37,7 @@ public class AsterixThreadExecutor implements Executor {
         executorService.execute(command);
     }
 
-    public Future<Object> submit(Callable command) {
-        return (Future<Object>) executorService.submit(command);
+    public Future<? extends Object> submit(Callable<? extends Object> command) {
+        return executorService.submit(command);
     }
 }

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixBuildProperties.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixBuildProperties.java b/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixBuildProperties.java
index e065bec..3ff4ac3 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixBuildProperties.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixBuildProperties.java
@@ -20,7 +20,6 @@
 package org.apache.asterix.common.config;
 
 import java.util.Map;
-import java.util.Properties;
 
 public class AsterixBuildProperties extends AbstractAsterixProperties {
 
@@ -49,7 +48,8 @@ public class AsterixBuildProperties extends AbstractAsterixProperties {
     }
 
     public String getCommitIdDescribeShort() {
-        return accessor.getProperty("git.commit.id.describe-short", "", PropertyInterpreters.getStringPropertyInterpreter());
+        return accessor.getProperty("git.commit.id.describe-short", "",
+                PropertyInterpreters.getStringPropertyInterpreter());
     }
 
     public String getCommitUserEmail() {
@@ -69,7 +69,8 @@ public class AsterixBuildProperties extends AbstractAsterixProperties {
     }
 
     public String getCommitMessageShort() {
-        return accessor.getProperty("git.commit.message.short", "", PropertyInterpreters.getStringPropertyInterpreter());
+        return accessor.getProperty("git.commit.message.short", "",
+                PropertyInterpreters.getStringPropertyInterpreter());
     }
 
     public String getShortCommitId() {
@@ -85,7 +86,8 @@ public class AsterixBuildProperties extends AbstractAsterixProperties {
     }
 
     public String getClosestTagCommitCount() {
-        return accessor.getProperty("git.closest.tag.commit.count", "", PropertyInterpreters.getStringPropertyInterpreter());
+        return accessor.getProperty("git.closest.tag.commit.count", "",
+                PropertyInterpreters.getStringPropertyInterpreter());
     }
 
     public String getCommitIdDescribe() {
@@ -107,7 +109,8 @@ public class AsterixBuildProperties extends AbstractAsterixProperties {
     public String getCommitUserName() {
         return accessor.getProperty("git.commit.user.name", "", PropertyInterpreters.getStringPropertyInterpreter());
     }
-    public Map<String, String> getAllProps(){
+
+    public Map<String, String> getAllProps() {
         return accessor.getBuildProperties();
     }
 

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java b/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java
index 647b032..d6c81ab 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java
@@ -22,14 +22,14 @@ import java.io.FileInputStream;
 import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.io.InputStream;
-import java.util.logging.Level;
-import java.util.logging.Logger;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
-import java.util.Set;
 import java.util.Properties;
+import java.util.Set;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 import javax.xml.bind.JAXBContext;
 import javax.xml.bind.JAXBException;
@@ -99,11 +99,14 @@ public class AsterixPropertiesAccessor {
         for (TransactionLogDir txnLogDir : asterixConfiguration.getTransactionLogDir()) {
             transactionLogDirs.put(txnLogDir.getNcId(), txnLogDir.getTxnLogDirPath());
         }
-        Properties p = new Properties();
+        Properties gitProperties = new Properties();
         try {
-            p.load(getClass().getClassLoader().getResourceAsStream("git.properties"));
-            asterixBuildProperties = new HashMap<String, String>((Map)p);
-        } catch(IOException e) {
+            gitProperties.load(getClass().getClassLoader().getResourceAsStream("git.properties"));
+            asterixBuildProperties = new HashMap<String, String>();
+            for (final String name : gitProperties.stringPropertyNames()) {
+                asterixBuildProperties.put(name, gitProperties.getProperty(name));
+            }
+        } catch (IOException e) {
             throw new AsterixException(e);
         }
 
@@ -137,7 +140,7 @@ public class AsterixPropertiesAccessor {
         return coredumpConfig;
     }
 
-    public Map<String, String> getBuildProperties(){
+    public Map<String, String> getBuildProperties() {
         return asterixBuildProperties;
     }
 

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/context/TransactionSubsystemProvider.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/context/TransactionSubsystemProvider.java b/asterix-common/src/main/java/org/apache/asterix/common/context/TransactionSubsystemProvider.java
index 2d63c05..e464667 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/context/TransactionSubsystemProvider.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/context/TransactionSubsystemProvider.java
@@ -29,6 +29,8 @@ import org.apache.hyracks.api.context.IHyracksTaskContext;
  * while at the same time the AsterixAppRuntimeContext depends on asterix-transactions for the TransactionSubsystem.
  */
 public class TransactionSubsystemProvider implements ITransactionSubsystemProvider {
+    private static final long serialVersionUID = 1L;
+
     @Override
     public ITransactionSubsystem getTransactionSubsystem(IHyracksTaskContext ctx) {
         IAsterixAppRuntimeContext runtimeCtx = (IAsterixAppRuntimeContext) ctx.getJobletContext()

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/feeds/CollectionRuntime.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/feeds/CollectionRuntime.java b/asterix-common/src/main/java/org/apache/asterix/common/feeds/CollectionRuntime.java
index 333e58e..9865501 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/feeds/CollectionRuntime.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/feeds/CollectionRuntime.java
@@ -24,7 +24,6 @@ import org.apache.asterix.common.feeds.FeedFrameCollector.State;
 import org.apache.asterix.common.feeds.api.ISubscribableRuntime;
 import org.apache.asterix.common.feeds.api.ISubscriberRuntime;
 import org.apache.hyracks.api.comm.IFrameWriter;
-import org.apache.hyracks.dataflow.common.comm.io.FrameTupleAccessor;
 
 /**
  * Represents the feed runtime that collects feed tuples from another feed.
@@ -40,8 +39,8 @@ public class CollectionRuntime extends FeedRuntime implements ISubscriberRuntime
     private FeedFrameCollector frameCollector;
 
     public CollectionRuntime(FeedConnectionId connectionId, FeedRuntimeId runtimeId,
-            FeedRuntimeInputHandler inputSideHandler, IFrameWriter outputSideWriter,
-            ISubscribableRuntime sourceRuntime, Map<String, String> feedPolicy) {
+            FeedRuntimeInputHandler inputSideHandler, IFrameWriter outputSideWriter, ISubscribableRuntime sourceRuntime,
+            Map<String, String> feedPolicy) {
         super(runtimeId, inputSideHandler, outputSideWriter);
         this.connectionId = connectionId;
         this.sourceRuntime = sourceRuntime;
@@ -64,6 +63,7 @@ public class CollectionRuntime extends FeedRuntime implements ISubscriberRuntime
                 || frameCollector.getState().equals(FeedFrameCollector.State.HANDOVER);
     }
 
+    @Override
     public void setMode(Mode mode) {
         getInputHandler().setMode(mode);
     }
@@ -85,6 +85,7 @@ public class CollectionRuntime extends FeedRuntime implements ISubscriberRuntime
         this.frameCollector = frameCollector;
     }
 
+    @Override
     public FeedFrameCollector getFrameCollector() {
         return frameCollector;
     }

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/feeds/DistributeFeedFrameWriter.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/feeds/DistributeFeedFrameWriter.java b/asterix-common/src/main/java/org/apache/asterix/common/feeds/DistributeFeedFrameWriter.java
index 9dbca15..f5f89f7 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/feeds/DistributeFeedFrameWriter.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/feeds/DistributeFeedFrameWriter.java
@@ -58,10 +58,11 @@ public class DistributeFeedFrameWriter implements IFrameWriter {
     /** The value of the partition 'i' if this is the i'th instance of the associated operator **/
     private final int partition;
 
-    public DistributeFeedFrameWriter(IHyracksTaskContext ctx, FeedId feedId, IFrameWriter writer, FeedRuntimeType feedRuntimeType,
-            int partition, FrameTupleAccessor fta, IFeedManager feedManager) throws IOException {
+    public DistributeFeedFrameWriter(IHyracksTaskContext ctx, FeedId feedId, IFrameWriter writer,
+            FeedRuntimeType feedRuntimeType, int partition, FrameTupleAccessor fta, IFeedManager feedManager)
+                    throws IOException {
         this.feedId = feedId;
-        this.frameDistributor = new FrameDistributor(ctx, feedId, feedRuntimeType, partition, true,
+        this.frameDistributor = new FrameDistributor(feedId, feedRuntimeType, partition, true,
                 feedManager.getFeedMemoryManager(), fta);
         this.feedRuntimeType = feedRuntimeType;
         this.partition = partition;
@@ -86,8 +87,8 @@ public class DistributeFeedFrameWriter implements IFrameWriter {
     public void unsubscribeFeed(IFrameWriter recipientFeedFrameWriter) throws Exception {
         boolean success = frameDistributor.deregisterFrameCollector(recipientFeedFrameWriter);
         if (!success) {
-            throw new IllegalStateException("Invalid attempt to unregister FeedFrameWriter " + recipientFeedFrameWriter
-                    + " not registered.");
+            throw new IllegalStateException(
+                    "Invalid attempt to unregister FeedFrameWriter " + recipientFeedFrameWriter + " not registered.");
         }
     }
 

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedFrameDiscarder.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedFrameDiscarder.java b/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedFrameDiscarder.java
index 1c9acf6..8609366 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedFrameDiscarder.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedFrameDiscarder.java
@@ -23,13 +23,10 @@ import java.nio.ByteBuffer;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
-import org.apache.hyracks.api.context.IHyracksTaskContext;
-
 public class FeedFrameDiscarder {
 
     private static final Logger LOGGER = Logger.getLogger(FeedFrameSpiller.class.getName());
 
-    private final IHyracksTaskContext ctx;
     private final FeedRuntimeInputHandler inputHandler;
     private final FeedConnectionId connectionId;
     private final FeedRuntimeId runtimeId;
@@ -37,9 +34,8 @@ public class FeedFrameDiscarder {
     private final float maxFractionDiscard;
     private int nDiscarded;
 
-    public FeedFrameDiscarder(IHyracksTaskContext ctx, FeedConnectionId connectionId, FeedRuntimeId runtimeId, 
-            FeedPolicyAccessor policyAccessor, FeedRuntimeInputHandler inputHandler) throws IOException {
-        this.ctx = ctx;
+    public FeedFrameDiscarder(FeedConnectionId connectionId, FeedRuntimeId runtimeId, FeedPolicyAccessor policyAccessor,
+            FeedRuntimeInputHandler inputHandler) throws IOException {
         this.connectionId = connectionId;
         this.runtimeId = runtimeId;
         this.policyAccessor = policyAccessor;

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedFrameHandlers.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedFrameHandlers.java b/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedFrameHandlers.java
index 520912b..c4a2ce0 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedFrameHandlers.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedFrameHandlers.java
@@ -128,7 +128,8 @@ public class FeedFrameHandlers {
 
         private final Collection<FeedFrameCollector> frameCollectors;
 
-        public InMemoryRouter(Collection<FeedFrameCollector> frameCollectors, FeedRuntimeType runtimeType, int partition) {
+        public InMemoryRouter(Collection<FeedFrameCollector> frameCollectors, FeedRuntimeType runtimeType,
+                int partition) {
             this.frameCollectors = frameCollectors;
         }
 
@@ -162,13 +163,11 @@ public class FeedFrameHandlers {
 
     public static class DiskSpiller implements IFeedFrameHandler {
 
-        private final FeedId feedId;
         private FrameSpiller<ByteBuffer> receiver;
         private Iterator<ByteBuffer> iterator;
 
         public DiskSpiller(FrameDistributor distributor, FeedId feedId, FeedRuntimeType runtimeType, int partition,
                 int frameSize) throws IOException {
-            this.feedId = feedId;
             receiver = new FrameSpiller<ByteBuffer>(distributor, feedId, frameSize);
         }
 
@@ -179,7 +178,6 @@ public class FeedFrameHandlers {
 
         private static class FrameSpiller<T> extends MessageReceiver<ByteBuffer> {
 
-            private final int frameSize;
             private final FeedId feedId;
             private BufferedOutputStream bos;
             private final ByteBuffer reusableLengthBuffer;
@@ -191,7 +189,6 @@ public class FeedFrameHandlers {
 
             public FrameSpiller(FrameDistributor distributor, FeedId feedId, int frameSize) throws IOException {
                 this.feedId = feedId;
-                this.frameSize = frameSize;
                 this.frameDistributor = distributor;
                 reusableLengthBuffer = ByteBuffer.allocate(4);
                 reusableDataBuffer = ByteBuffer.allocate(frameSize);

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedMetricCollector.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedMetricCollector.java b/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedMetricCollector.java
index 982fb7c..7b76692 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedMetricCollector.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedMetricCollector.java
@@ -32,14 +32,12 @@ public class FeedMetricCollector implements IFeedMetricCollector {
 
     private static final int UNKNOWN = -1;
 
-    private final String nodeId;
     private final AtomicInteger globalSenderId = new AtomicInteger(1);
     private final Map<Integer, Sender> senders = new HashMap<Integer, Sender>();
     private final Map<Integer, Series> statHistory = new HashMap<Integer, Series>();
     private final Map<String, Sender> sendersByName = new HashMap<String, Sender>();
 
     public FeedMetricCollector(String nodeId) {
-        this.nodeId = nodeId;
     }
 
     @Override

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedRuntimeInputHandler.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedRuntimeInputHandler.java b/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedRuntimeInputHandler.java
index cafc699..6642df1 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedRuntimeInputHandler.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedRuntimeInputHandler.java
@@ -68,8 +68,8 @@ public class FeedRuntimeInputHandler implements IFrameWriter {
 
     private FrameEventCallback frameEventCallback;
 
-    public FeedRuntimeInputHandler(IHyracksTaskContext ctx, FeedConnectionId connectionId, FeedRuntimeId runtimeId, IFrameWriter coreOperator,
-            FeedPolicyAccessor fpa, boolean bufferingEnabled, FrameTupleAccessor fta,
+    public FeedRuntimeInputHandler(IHyracksTaskContext ctx, FeedConnectionId connectionId, FeedRuntimeId runtimeId,
+            IFrameWriter coreOperator, FeedPolicyAccessor fpa, boolean bufferingEnabled, FrameTupleAccessor fta,
             RecordDescriptor recordDesc, IFeedManager feedManager, int nPartitions) throws IOException {
         this.connectionId = connectionId;
         this.runtimeId = runtimeId;
@@ -77,17 +77,17 @@ public class FeedRuntimeInputHandler implements IFrameWriter {
         this.bufferingEnabled = bufferingEnabled;
         this.feedPolicyAccessor = fpa;
         this.spiller = new FeedFrameSpiller(ctx, connectionId, runtimeId, fpa);
-        this.discarder = new FeedFrameDiscarder(ctx, connectionId, runtimeId, fpa, this);
+        this.discarder = new FeedFrameDiscarder(connectionId, runtimeId, fpa, this);
         this.exceptionHandler = new FeedExceptionHandler(ctx, fta, recordDesc, feedManager, connectionId);
         this.mode = Mode.PROCESS;
         this.lastMode = Mode.PROCESS;
         this.finished = false;
         this.fpa = fpa;
         this.feedManager = feedManager;
-        this.pool = (DataBucketPool) feedManager.getFeedMemoryManager().getMemoryComponent(
-                IFeedMemoryComponent.Type.POOL);
-        this.frameCollection = (FrameCollection) feedManager.getFeedMemoryManager().getMemoryComponent(
-                IFeedMemoryComponent.Type.COLLECTION);
+        this.pool = (DataBucketPool) feedManager.getFeedMemoryManager()
+                .getMemoryComponent(IFeedMemoryComponent.Type.POOL);
+        this.frameCollection = (FrameCollection) feedManager.getFeedMemoryManager()
+                .getMemoryComponent(IFeedMemoryComponent.Type.COLLECTION);
         this.frameEventCallback = new FrameEventCallback(fpa, this, coreOperator);
         this.mBuffer = MonitoredBuffer.getMonitoredBuffer(ctx, this, coreOperator, fta, recordDesc,
                 feedManager.getFeedMetricCollector(), connectionId, runtimeId, exceptionHandler, frameEventCallback,
@@ -96,6 +96,7 @@ public class FeedRuntimeInputHandler implements IFrameWriter {
         this.throttlingEnabled = false;
     }
 
+    @Override
     public synchronized void nextFrame(ByteBuffer frame) throws HyracksDataException {
         try {
             switch (mode) {
@@ -159,8 +160,8 @@ public class FeedRuntimeInputHandler implements IFrameWriter {
             LOGGER.info("Bufferring data until recovery is complete " + this.runtimeId);
         }
         if (frameCollection == null) {
-            this.frameCollection = (FrameCollection) feedManager.getFeedMemoryManager().getMemoryComponent(
-                    IFeedMemoryComponent.Type.COLLECTION);
+            this.frameCollection = (FrameCollection) feedManager.getFeedMemoryManager()
+                    .getMemoryComponent(IFeedMemoryComponent.Type.COLLECTION);
         }
         if (frameCollection == null) {
             discarder.processMessage(frame);
@@ -338,6 +339,7 @@ public class FeedRuntimeInputHandler implements IFrameWriter {
         }
     }
 
+    @Override
     public void close() {
         if (mBuffer != null) {
             boolean disableMonitoring = !this.mode.equals(Mode.STALL);

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedStorageStatistics.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedStorageStatistics.java b/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedStorageStatistics.java
deleted file mode 100644
index 156dcc0..0000000
--- a/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedStorageStatistics.java
+++ /dev/null
@@ -1,27 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.asterix.common.feeds;
-
-public class FeedStorageStatistics {
-
-    private long avgPersistenceDelay;
-    private long lastIntakeTimestamp;
-    
-    
-}

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/feeds/FrameDistributor.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/feeds/FrameDistributor.java b/asterix-common/src/main/java/org/apache/asterix/common/feeds/FrameDistributor.java
index f859bfc..9e106fb 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/feeds/FrameDistributor.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/feeds/FrameDistributor.java
@@ -29,7 +29,6 @@ import org.apache.asterix.common.feeds.api.IFeedMemoryComponent.Type;
 import org.apache.asterix.common.feeds.api.IFeedMemoryManager;
 import org.apache.asterix.common.feeds.api.IFeedRuntime.FeedRuntimeType;
 import org.apache.hyracks.api.comm.IFrameWriter;
-import org.apache.hyracks.api.context.IHyracksTaskContext;
 import org.apache.hyracks.api.exceptions.HyracksDataException;
 import org.apache.hyracks.dataflow.common.comm.io.FrameTupleAccessor;
 
@@ -39,7 +38,6 @@ public class FrameDistributor {
 
     private static final long MEMORY_AVAILABLE_POLL_PERIOD = 1000; // 1 second
 
-    private final IHyracksTaskContext ctx;
     private final FeedId feedId;
     private final FeedRuntimeType feedRuntimeType;
     private final int partition;
@@ -73,10 +71,9 @@ public class FrameDistributor {
         INACTIVE
     }
 
-    public FrameDistributor(IHyracksTaskContext ctx, FeedId feedId, FeedRuntimeType feedRuntimeType, int partition,
+    public FrameDistributor(FeedId feedId, FeedRuntimeType feedRuntimeType, int partition,
             boolean enableSynchronousTransfer, IFeedMemoryManager memoryManager, FrameTupleAccessor fta)
-            throws HyracksDataException {
-        this.ctx = ctx;
+                    throws HyracksDataException {
         this.feedId = feedId;
         this.feedRuntimeType = feedRuntimeType;
         this.partition = partition;
@@ -140,16 +137,16 @@ public class FrameDistributor {
         }
         evaluateIfSpillIsEnabled();
         if (LOGGER.isLoggable(Level.INFO)) {
-            LOGGER.info("Switching to " + distributionMode + " mode from " + currentMode + " mode " + " Feed id "
-                    + feedId);
+            LOGGER.info(
+                    "Switching to " + distributionMode + " mode from " + currentMode + " mode " + " Feed id " + feedId);
         }
     }
 
     public synchronized void deregisterFrameCollector(FeedFrameCollector frameCollector) {
         switch (distributionMode) {
             case INACTIVE:
-                throw new IllegalStateException("Invalid attempt to deregister frame collector in " + distributionMode
-                        + " mode.");
+                throw new IllegalStateException(
+                        "Invalid attempt to deregister frame collector in " + distributionMode + " mode.");
             case SHARED:
                 frameCollector.closeCollector();
                 registeredCollectors.remove(frameCollector.getFrameWriter());

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/feeds/IntakePartitionStatistics.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/feeds/IntakePartitionStatistics.java b/asterix-common/src/main/java/org/apache/asterix/common/feeds/IntakePartitionStatistics.java
index e85550d..5601f73 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/feeds/IntakePartitionStatistics.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/feeds/IntakePartitionStatistics.java
@@ -22,24 +22,20 @@ import java.util.BitSet;
 
 public class IntakePartitionStatistics {
 
-	public static int ACK_WINDOW_SIZE = 1024;
-	private int partition;
-	private int base;
-	private BitSet bitSet;
+    public static int ACK_WINDOW_SIZE = 1024;
+    private BitSet bitSet;
 
-	public IntakePartitionStatistics(int partition, int base) {
-		this.partition = partition;
-		this.base = base;
-		this.bitSet = new BitSet(ACK_WINDOW_SIZE);
-	}
+    public IntakePartitionStatistics(int partition, int base) {
+        this.bitSet = new BitSet(ACK_WINDOW_SIZE);
+    }
 
-	public void ackRecordId(int recordId) {
-		int posIndexWithinBase = recordId % ACK_WINDOW_SIZE;
-		this.bitSet.set(posIndexWithinBase);
-	}
+    public void ackRecordId(int recordId) {
+        int posIndexWithinBase = recordId % ACK_WINDOW_SIZE;
+        this.bitSet.set(posIndexWithinBase);
+    }
 
-	public byte[] getAckInfo() {
-		return bitSet.toByteArray();
-	}
+    public byte[] getAckInfo() {
+        return bitSet.toByteArray();
+    }
 
 }

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/feeds/MonitoredBuffer.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/feeds/MonitoredBuffer.java b/asterix-common/src/main/java/org/apache/asterix/common/feeds/MonitoredBuffer.java
index 145fa47..5761944 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/feeds/MonitoredBuffer.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/feeds/MonitoredBuffer.java
@@ -57,7 +57,6 @@ public abstract class MonitoredBuffer extends MessageReceiver<DataBucket> {
     protected final FeedRuntimeInputHandler inputHandler;
     protected final IFrameEventCallback callback;
     protected final Timer timer;
-    private final RecordDescriptor recordDesc;
     private final IExceptionHandler exceptionHandler;
     protected final FeedPolicyAccessor policyAccessor;
     protected int nPartitions;
@@ -122,7 +121,6 @@ public abstract class MonitoredBuffer extends MessageReceiver<DataBucket> {
         this.callback = callback;
         this.inputHandler = inputHandler;
         this.timer = new Timer();
-        this.recordDesc = recordDesc;
         this.policyAccessor = policyAccessor;
         this.nPartitions = nPartitions;
         this.active = true;
@@ -156,9 +154,8 @@ public abstract class MonitoredBuffer extends MessageReceiver<DataBucket> {
             this.timer.scheduleAtFixedRate(processingRateTask, 0, PROCESSING_RATE_MEASURE_FREQUENCY);
         }
 
-        if (monitorInputQueueLength
-                && (policyAccessor.isElastic() || policyAccessor.throttlingEnabled()
-                        || policyAccessor.spillToDiskOnCongestion() || policyAccessor.discardOnCongestion())) {
+        if (monitorInputQueueLength && (policyAccessor.isElastic() || policyAccessor.throttlingEnabled()
+                || policyAccessor.spillToDiskOnCongestion() || policyAccessor.discardOnCongestion())) {
             this.monitorInputQueueLengthTask = new MonitorInputQueueLengthTimerTask(this, callback);
             this.timer.scheduleAtFixedRate(monitorInputQueueLengthTask, 0, INPUT_QUEUE_MEASURE_FREQUENCY);
         }
@@ -237,9 +234,8 @@ public abstract class MonitoredBuffer extends MessageReceiver<DataBucket> {
     }
 
     public void sendReport(ByteBuffer frame) {
-        if ((logInflowOutflowRate || reportInflowRate)
-                && !(inputHandler.getMode().equals(Mode.PROCESS_BACKLOG) || inputHandler.getMode().equals(
-                        Mode.PROCESS_SPILL))) {
+        if ((logInflowOutflowRate || reportInflowRate) && !(inputHandler.getMode().equals(Mode.PROCESS_BACKLOG)
+                || inputHandler.getMode().equals(Mode.PROCESS_SPILL))) {
             inflowFta.reset(frame);
             metricCollector.sendReport(inflowReportSenderId, inflowFta.getTupleCount());
         }

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/feeds/NodeLoadReportService.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/feeds/NodeLoadReportService.java b/asterix-common/src/main/java/org/apache/asterix/common/feeds/NodeLoadReportService.java
index fb16d1d..6be0211 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/feeds/NodeLoadReportService.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/feeds/NodeLoadReportService.java
@@ -36,12 +36,10 @@ public class NodeLoadReportService implements IFeedService {
     private static final float CPU_CHANGE_THRESHOLD = 0.2f;
     private static final float HEAP_CHANGE_THRESHOLD = 0.4f;
 
-    private final String nodeId;
     private final NodeLoadReportTask task;
     private final Timer timer;
 
     public NodeLoadReportService(String nodeId, IFeedManager feedManager) {
-        this.nodeId = nodeId;
         this.task = new NodeLoadReportTask(nodeId, feedManager);
         this.timer = new Timer();
     }
@@ -58,7 +56,6 @@ public class NodeLoadReportService implements IFeedService {
 
     private static class NodeLoadReportTask extends TimerTask {
 
-        private final String nodeId;
         private final IFeedManager feedManager;
         private final NodeReportMessage message;
         private final IFeedMessageService messageService;
@@ -67,7 +64,6 @@ public class NodeLoadReportService implements IFeedService {
         private static MemoryMXBean memBean = ManagementFactory.getMemoryMXBean();
 
         public NodeLoadReportTask(String nodeId, IFeedManager feedManager) {
-            this.nodeId = nodeId;
             this.feedManager = feedManager;
             this.message = new NodeReportMessage(0.0f, 0L, 0);
             this.messageService = feedManager.getFeedMessageService();
@@ -90,8 +86,10 @@ public class NodeLoadReportService implements IFeedService {
                 return true;
             }
 
-            boolean changeInCpu = (Math.abs(cpuLoad - message.getCpuLoad()) / message.getCpuLoad()) > CPU_CHANGE_THRESHOLD;
-            boolean changeInUsedHeap = (Math.abs(usedHeap - message.getUsedHeap()) / message.getUsedHeap()) > HEAP_CHANGE_THRESHOLD;
+            boolean changeInCpu = (Math.abs(cpuLoad - message.getCpuLoad())
+                    / message.getCpuLoad()) > CPU_CHANGE_THRESHOLD;
+            boolean changeInUsedHeap = (Math.abs(usedHeap - message.getUsedHeap())
+                    / message.getUsedHeap()) > HEAP_CHANGE_THRESHOLD;
             boolean changeInRuntimeSize = nRuntimes != message.getnRuntimes();
             return changeInCpu || changeInUsedHeap || changeInRuntimeSize;
         }

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/feeds/StorageSideMonitoredBuffer.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/feeds/StorageSideMonitoredBuffer.java b/asterix-common/src/main/java/org/apache/asterix/common/feeds/StorageSideMonitoredBuffer.java
index 474f0d1..d545b09 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/feeds/StorageSideMonitoredBuffer.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/feeds/StorageSideMonitoredBuffer.java
@@ -37,10 +37,11 @@ public class StorageSideMonitoredBuffer extends MonitoredBuffer {
     private boolean ackingEnabled;
     private final boolean timeTrackingEnabled;
 
-    public StorageSideMonitoredBuffer(IHyracksTaskContext ctx, FeedRuntimeInputHandler inputHandler, IFrameWriter frameWriter,
-            FrameTupleAccessor fta,  RecordDescriptor recordDesc, IFeedMetricCollector metricCollector,
-            FeedConnectionId connectionId, FeedRuntimeId runtimeId, IExceptionHandler exceptionHandler,
-            IFrameEventCallback callback, int nPartitions, FeedPolicyAccessor policyAccessor) {
+    public StorageSideMonitoredBuffer(IHyracksTaskContext ctx, FeedRuntimeInputHandler inputHandler,
+            IFrameWriter frameWriter, FrameTupleAccessor fta, RecordDescriptor recordDesc,
+            IFeedMetricCollector metricCollector, FeedConnectionId connectionId, FeedRuntimeId runtimeId,
+            IExceptionHandler exceptionHandler, IFrameEventCallback callback, int nPartitions,
+            FeedPolicyAccessor policyAccessor) {
         super(ctx, inputHandler, frameWriter, fta, recordDesc, metricCollector, connectionId, runtimeId,
                 exceptionHandler, callback, nPartitions, policyAccessor);
         timeTrackingEnabled = policyAccessor.isTimeTrackingEnabled();
@@ -59,6 +60,7 @@ public class StorageSideMonitoredBuffer extends MonitoredBuffer {
         return false;
     }
 
+    @Override
     protected boolean logInflowOutflowRate() {
         return true;
     }
@@ -86,7 +88,6 @@ public class StorageSideMonitoredBuffer extends MonitoredBuffer {
 
             private static final long NORMAL_WINDOW_LIMIT = 400 * 1000;
             private static final long HIGH_WINDOW_LIMIT = 800 * 1000;
-            private static final long LOW_WINDOW_LIMIT = 1200 * 1000;
 
             private long delayNormalWindow = 0;
             private long delayHighWindow = 0;
@@ -104,8 +105,6 @@ public class StorageSideMonitoredBuffer extends MonitoredBuffer {
                     int nTuples = frameAccessor.getTupleCount();
                     long intakeTimestamp;
                     long currentTime = System.currentTimeMillis();
-                    int partition = 0;
-                    int recordId = 0;
                     for (int i = 0; i < nTuples; i++) {
                         int recordStart = frameAccessor.getTupleStartOffset(i) + frameAccessor.getFieldSlotsLength();
                         int openPartOffsetOrig = frame.getInt(recordStart + 6);
@@ -113,11 +112,9 @@ public class StorageSideMonitoredBuffer extends MonitoredBuffer {
 
                         int recordIdOffset = openPartOffsetOrig + 4 + 8 * numOpenFields
                                 + (StatisticsConstants.INTAKE_TUPLEID.length() + 2) + 1;
-                        recordId = frame.getInt(recordStart + recordIdOffset);
 
                         int partitionOffset = recordIdOffset + 4 + (StatisticsConstants.INTAKE_PARTITION.length() + 2)
                                 + 1;
-                        partition = frame.getInt(recordStart + partitionOffset);
 
                         int intakeTimestampValueOffset = partitionOffset + 4
                                 + (StatisticsConstants.INTAKE_TIMESTAMP.length() + 2) + 1;

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/feeds/SubscribableFeedRuntimeId.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/feeds/SubscribableFeedRuntimeId.java b/asterix-common/src/main/java/org/apache/asterix/common/feeds/SubscribableFeedRuntimeId.java
index 3bc6df9..7eb5921 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/feeds/SubscribableFeedRuntimeId.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/feeds/SubscribableFeedRuntimeId.java
@@ -21,7 +21,7 @@ package org.apache.asterix.common.feeds;
 import org.apache.asterix.common.feeds.api.IFeedRuntime.FeedRuntimeType;
 
 public class SubscribableFeedRuntimeId extends FeedRuntimeId {
-
+    private static final long serialVersionUID = 1L;
     private final FeedId feedId;
 
     public SubscribableFeedRuntimeId(FeedId feedId, FeedRuntimeType runtimeType, int partition) {

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-common/src/main/java/org/apache/asterix/common/feeds/api/IFeedLifecycleEventSubscriber.java
----------------------------------------------------------------------
diff --git a/asterix-common/src/main/java/org/apache/asterix/common/feeds/api/IFeedLifecycleEventSubscriber.java b/asterix-common/src/main/java/org/apache/asterix/common/feeds/api/IFeedLifecycleEventSubscriber.java
index ebcf2fb..94af74b 100644
--- a/asterix-common/src/main/java/org/apache/asterix/common/feeds/api/IFeedLifecycleEventSubscriber.java
+++ b/asterix-common/src/main/java/org/apache/asterix/common/feeds/api/IFeedLifecycleEventSubscriber.java
@@ -19,7 +19,6 @@
 package org.apache.asterix.common.feeds.api;
 
 import org.apache.asterix.common.exceptions.AsterixException;
-import org.apache.asterix.common.feeds.FeedConnectJobInfo;
 
 public interface IFeedLifecycleEventSubscriber {
 

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-events/src/main/java/org/apache/asterix/event/driver/EventDriver.java
----------------------------------------------------------------------
diff --git a/asterix-events/src/main/java/org/apache/asterix/event/driver/EventDriver.java b/asterix-events/src/main/java/org/apache/asterix/event/driver/EventDriver.java
index 2d03034..c92262c 100644
--- a/asterix-events/src/main/java/org/apache/asterix/event/driver/EventDriver.java
+++ b/asterix-events/src/main/java/org/apache/asterix/event/driver/EventDriver.java
@@ -29,18 +29,14 @@ import javax.xml.bind.JAXBContext;
 import javax.xml.bind.JAXBException;
 import javax.xml.bind.Unmarshaller;
 
-import org.kohsuke.args4j.CmdLineParser;
-
-import org.apache.asterix.event.management.DefaultOutputHandler;
 import org.apache.asterix.event.management.EventUtil;
-import org.apache.asterix.event.management.AsterixEventServiceClient;
-import org.apache.asterix.event.management.IOutputHandler;
 import org.apache.asterix.event.management.Randomizer;
 import org.apache.asterix.event.schema.cluster.Cluster;
 import org.apache.asterix.event.schema.cluster.Node;
 import org.apache.asterix.event.schema.cluster.Property;
 import org.apache.asterix.event.schema.event.Events;
 import org.apache.asterix.event.schema.pattern.Patterns;
+import org.kohsuke.args4j.CmdLineParser;
 
 public class EventDriver {
 
@@ -108,7 +104,6 @@ public class EventDriver {
                 Randomizer.getInstance(eventConfig.seed);
             }
             Cluster cluster = initializeCluster(eventConfig.clusterPath);
-            Patterns patterns = initializePatterns(eventConfig.patternPath);
             initialize(eventConfig);
 
             if (!eventConfig.dryRun) {

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-events/src/main/java/org/apache/asterix/event/error/OutputHandler.java
----------------------------------------------------------------------
diff --git a/asterix-events/src/main/java/org/apache/asterix/event/error/OutputHandler.java b/asterix-events/src/main/java/org/apache/asterix/event/error/OutputHandler.java
index 17e0f15..68e87c6 100644
--- a/asterix-events/src/main/java/org/apache/asterix/event/error/OutputHandler.java
+++ b/asterix-events/src/main/java/org/apache/asterix/event/error/OutputHandler.java
@@ -35,6 +35,7 @@ public class OutputHandler implements IOutputHandler {
 
     }
 
+    @Override
     public OutputAnalysis reportEventOutput(Event event, String output) {
 
         EventType eventType = EventType.valueOf(event.getType().toUpperCase());
@@ -83,6 +84,8 @@ public class OutputHandler implements IOutputHandler {
                     ignore = false;
                 }
                 break;
+            default:
+                break;
         }
         if (ignore) {
             return new OutputAnalysis(true, null);

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-events/src/main/java/org/apache/asterix/event/management/EventExecutor.java
----------------------------------------------------------------------
diff --git a/asterix-events/src/main/java/org/apache/asterix/event/management/EventExecutor.java b/asterix-events/src/main/java/org/apache/asterix/event/management/EventExecutor.java
index 95557d7..4587756 100644
--- a/asterix-events/src/main/java/org/apache/asterix/event/management/EventExecutor.java
+++ b/asterix-events/src/main/java/org/apache/asterix/event/management/EventExecutor.java
@@ -25,15 +25,13 @@ import java.io.StringWriter;
 import java.util.ArrayList;
 import java.util.List;
 
-import org.apache.commons.io.IOUtils;
-
-import org.apache.asterix.common.config.AsterixStorageProperties;
 import org.apache.asterix.event.driver.EventDriver;
 import org.apache.asterix.event.schema.cluster.Cluster;
 import org.apache.asterix.event.schema.cluster.Node;
 import org.apache.asterix.event.schema.cluster.Property;
 import org.apache.asterix.event.schema.pattern.Pattern;
 import org.apache.asterix.event.service.AsterixEventServiceUtil;
+import org.apache.commons.io.IOUtils;
 
 public class EventExecutor {
 
@@ -70,8 +68,9 @@ public class EventExecutor {
                         if (node.getDebugPort() != null) {
                             int debugPort = node.getDebugPort().intValue();
                             if (!javaOpts.contains("-Xdebug")) {
-                                builder.append((" "
-                                        + "-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=" + debugPort));
+                                builder.append(
+                                        (" " + "-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address="
+                                                + debugPort));
                             }
                         }
                         builder.append("\"");
@@ -88,8 +87,9 @@ public class EventExecutor {
                         if (node.getDebugPort() != null) {
                             int debugPort = node.getDebugPort().intValue();
                             if (!javaOpts.contains("-Xdebug")) {
-                                builder.append((" "
-                                        + "-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=" + debugPort));
+                                builder.append(
+                                        (" " + "-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address="
+                                                + debugPort));
                             }
                         }
                         builder.append("\"");

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-events/src/main/java/org/apache/asterix/event/model/BackupInfo.java
----------------------------------------------------------------------
diff --git a/asterix-events/src/main/java/org/apache/asterix/event/model/BackupInfo.java b/asterix-events/src/main/java/org/apache/asterix/event/model/BackupInfo.java
index 6c5a25f..3169881 100644
--- a/asterix-events/src/main/java/org/apache/asterix/event/model/BackupInfo.java
+++ b/asterix-events/src/main/java/org/apache/asterix/event/model/BackupInfo.java
@@ -25,6 +25,7 @@ import org.apache.asterix.installer.schema.conf.Backup;
 import org.apache.asterix.installer.schema.conf.Hdfs;
 
 public class BackupInfo implements Serializable {
+    private static final long serialVersionUID = 1L;
 
     public static enum BackupType {
         LOCAL,

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/CNNFeedAdapterFactory.java
----------------------------------------------------------------------
diff --git a/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/CNNFeedAdapterFactory.java b/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/CNNFeedAdapterFactory.java
index bccfa43..a74ae4d 100644
--- a/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/CNNFeedAdapterFactory.java
+++ b/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/CNNFeedAdapterFactory.java
@@ -23,7 +23,6 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
-import org.apache.asterix.common.feeds.FeedPolicyAccessor;
 import org.apache.asterix.common.feeds.api.IDatasourceAdapter;
 import org.apache.asterix.common.feeds.api.IIntakeProgressTracker;
 import org.apache.asterix.external.dataset.adapter.RSSFeedAdapter;
@@ -44,8 +43,6 @@ public class CNNFeedAdapterFactory implements IFeedAdapterFactory {
     private List<String> feedURLs = new ArrayList<String>();
     private static Map<String, String> topicFeeds = new HashMap<String, String>();
     private ARecordType recordType;
-    private FeedPolicyAccessor policyAccessor;
-
     public static final String KEY_RSS_URL = "topic";
     public static final String KEY_INTERVAL = "interval";
     public static final String TOP_STORIES = "topstories";
@@ -98,7 +95,7 @@ public class CNNFeedAdapterFactory implements IFeedAdapterFactory {
     @Override
     public void configure(Map<String, String> configuration, ARecordType outputType) throws Exception {
         this.configuration = configuration;
-        String rssURLProperty = (String) configuration.get(KEY_RSS_URL);
+        String rssURLProperty = configuration.get(KEY_RSS_URL);
         if (rssURLProperty == null) {
             throw new IllegalArgumentException("no rss url provided");
         }
@@ -113,8 +110,8 @@ public class CNNFeedAdapterFactory implements IFeedAdapterFactory {
         for (String topic : rssTopics) {
             String feedURL = topicFeeds.get(topic);
             if (feedURL == null) {
-                throw new IllegalArgumentException(" unknown topic :" + topic + " please choose from the following "
-                        + getValidTopics());
+                throw new IllegalArgumentException(
+                        " unknown topic :" + topic + " please choose from the following " + getValidTopics());
             }
             feedURLs.add(feedURL);
         }

http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/18a9dca5/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/PullBasedTwitterAdapterFactory.java
----------------------------------------------------------------------
diff --git a/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/PullBasedTwitterAdapterFactory.java b/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/PullBasedTwitterAdapterFactory.java
index 91b15fe..c05df33 100644
--- a/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/PullBasedTwitterAdapterFactory.java
+++ b/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/PullBasedTwitterAdapterFactory.java
@@ -23,7 +23,6 @@ import java.util.logging.Level;
 import java.util.logging.Logger;
 
 import org.apache.asterix.common.exceptions.AsterixException;
-import org.apache.asterix.common.feeds.FeedPolicyAccessor;
 import org.apache.asterix.common.feeds.api.IDatasourceAdapter;
 import org.apache.asterix.common.feeds.api.IIntakeProgressTracker;
 import org.apache.asterix.external.dataset.adapter.PullBasedTwitterAdapter;
@@ -47,7 +46,7 @@ public class PullBasedTwitterAdapterFactory implements IFeedAdapterFactory {
     public static final String PULL_BASED_TWITTER_ADAPTER_NAME = "pull_twitter";
 
     private static final String DEFAULT_INTERVAL = "10"; // 10 seconds
-    private static final int INTAKE_CARDINALITY = 1; // degree of parallelism at intake stage 
+    private static final int INTAKE_CARDINALITY = 1; // degree of parallelism at intake stage
 
     private ARecordType outputType;
 
@@ -75,8 +74,8 @@ public class PullBasedTwitterAdapterFactory implements IFeedAdapterFactory {
         TwitterUtil.initializeConfigurationWithAuthInfo(configuration);
 
         if (configuration.get(SearchAPIConstants.QUERY) == null) {
-            throw new AsterixException("parameter " + SearchAPIConstants.QUERY
-                    + " not specified as part of adaptor configuration");
+            throw new AsterixException(
+                    "parameter " + SearchAPIConstants.QUERY + " not specified as part of adaptor configuration");
         }
 
         String interval = configuration.get(SearchAPIConstants.INTERVAL);
@@ -84,8 +83,8 @@ public class PullBasedTwitterAdapterFactory implements IFeedAdapterFactory {
             try {
                 Integer.parseInt(interval);
             } catch (NumberFormatException nfe) {
-                throw new IllegalArgumentException("parameter " + SearchAPIConstants.INTERVAL
-                        + " is defined incorrectly, expecting a number");
+                throw new IllegalArgumentException(
+                        "parameter " + SearchAPIConstants.INTERVAL + " is defined incorrectly, expecting a number");
             }
         } else {
             configuration.put(SearchAPIConstants.INTERVAL, DEFAULT_INTERVAL);



Mime
View raw message