asterixdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ima...@apache.org
Subject incubator-asterixdb git commit: Fix issue 897 (Stale metadata breaks ADM/AQL 101)
Date Fri, 12 Jun 2015 23:06:04 GMT
Repository: incubator-asterixdb
Updated Branches:
  refs/heads/master 7e72daecd -> 1445153fd


Fix issue 897 (Stale metadata breaks ADM/AQL 101)

This fixes the issue for me, but I think this really needs some careful consideration.
Identical issues could be lurking anywhere the passed object is modified and that info needs
to be conveyed to the caller.
I feel like I should not have to read from MetadataNode directly to get this info.

Change-Id: I088d33ad7810d7e1ca5471202cf20fa9a651195c
Reviewed-on: https://asterix-gerrit.ics.uci.edu/283
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Ildar Absalyamov <ildar.absalyamov@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/commit/1445153f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/tree/1445153f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/diff/1445153f

Branch: refs/heads/master
Commit: 1445153fda37f0d244bb1648c27ac5df4c47a852
Parents: 7e72dae
Author: Ian Maxon <imaxon@apache.org>
Authored: Tue Jun 9 16:48:41 2015 -0700
Committer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Committed: Fri Jun 12 15:20:24 2015 -0700

----------------------------------------------------------------------
 .../java/edu/uci/ics/asterix/metadata/MetadataManager.java     | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-asterixdb/blob/1445153f/asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataManager.java
----------------------------------------------------------------------
diff --git a/asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataManager.java
b/asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataManager.java
index d7e9bbb..dbfe32c 100644
--- a/asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataManager.java
+++ b/asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/MetadataManager.java
@@ -388,7 +388,11 @@ public class MetadataManager implements IMetadataManager {
         } catch (RemoteException e) {
             throw new MetadataException(e);
         }
-        ctx.addDatatype(datatype);
+        try {
+            ctx.addDatatype(metadataNode.getDatatype(ctx.getJobId(),datatype.getDataverseName(),datatype.getDatatypeName()));
+        } catch (RemoteException e) {
+            throw new MetadataException(e);
+        }
     }
 
     @Override


Mime
View raw message