From dev-return-15083-archive-asf-public=cust-asf.ponee.io@arrow.apache.org Wed Oct 2 01:39:44 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C30B1180608 for ; Wed, 2 Oct 2019 03:39:43 +0200 (CEST) Received: (qmail 44139 invoked by uid 500); 2 Oct 2019 01:39:41 -0000 Mailing-List: contact dev-help@arrow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@arrow.apache.org Delivered-To: mailing list dev@arrow.apache.org Received: (qmail 44102 invoked by uid 99); 2 Oct 2019 01:39:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Oct 2019 01:39:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C0DBDC1CE2 for ; Wed, 2 Oct 2019 01:39:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.8 X-Spam-Level: * X-Spam-Status: No, score=1.8 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id gZoJPMaVwjVK for ; Wed, 2 Oct 2019 01:39:38 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::22c; helo=mail-lj1-x22c.google.com; envelope-from=emkornfield@gmail.com; receiver= Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 5F78D7DE24 for ; Wed, 2 Oct 2019 01:29:54 +0000 (UTC) Received: by mail-lj1-x22c.google.com with SMTP id y23so15337701lje.9 for ; Tue, 01 Oct 2019 18:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to; bh=HOmCA+yKBNoxMG/E2exM2ipbsA/+d2gO/r1Ij4QlUaM=; b=lMymI43/FhwIIPop/uRq0nTchalIXv8Jha8eSLSwrKlYD4+lMJnP9DcF3PDgiAib6X 3OLgJF2EwGtN8hn8seGH5jRoL8sULU8dFizq90KbqdWHOoLk4BCyqYxIRysJ9IgaW1pC tqWfX3eKLwAOrp2HovORO8C6Vwpw4dyO4XAVP5LnyZ03+AZWyNBhUqpJ7Y5BTYxNSlc4 LywO7qZxoYq1seDblOw0i4shimvAgWVY74mDLuDQg/nxTFRpFhSStu7fHopc9yl2+xY8 6b2Nk+o8o5cgw6Yd6451IDegd86HhthyCODZtgUEq0n3REEdiSE7oAtao0H3O7n2eGf/ L1Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to; bh=HOmCA+yKBNoxMG/E2exM2ipbsA/+d2gO/r1Ij4QlUaM=; b=aPMoWxD1LBaHuvQYMJABuvWLD7tC8W/w2t8qYtfjxbA8ynULU9+4Dm8BlvGXhQs5rl g38dx0Z3ThnZwgdVFhz8BguPn2hoGVS+RMsao8LiUwQ5J3IM0qhdxO5V+qbR9cXUMyXt fUj4oWwdh3b+oeHFY9RYsnewoOZ8Ujv+QlWDvI2X1iABARxMONZIIdZH4qQuEXNXO08x Vz6ddkkJbS95RnOE82pYJl5k8hvXdRYxbdrxyjwE4ybvcs+dn+A50XEWwudP6CPKxA4g aziWUKgOwhEQLe9UlcLtyjOekaNcmTlgptKjhBpxqwgQG06+l9aes9FweLkeMZmXWlpm a25w== X-Gm-Message-State: APjAAAVXGyuL/+4FHOULYUs/g9kofYshvdUdsBJPx0Ati/nOEBZOYnOB QVw4uQnzlyGT447dOWDI4Kzf23VstHvtt688v18= X-Google-Smtp-Source: APXvYqxouBtua2Ok412/GMQjFfzRy++0rT7D7x5GcI6dcQ66BQCW+oFVLPI8/hfrhNZAB9FozqXippdpWga0g32O0Jc= X-Received: by 2002:a2e:91c7:: with SMTP id u7mr477034ljg.146.1569979793469; Tue, 01 Oct 2019 18:29:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Reply-To: emkornfield@gmail.com From: Micah Kornfield Date: Tue, 1 Oct 2019 19:29:42 -0600 Message-ID: Subject: Re: [Discuss] [Java] DateMilliVector.getObject() return type (LocalDateTime vs LocalDate) To: David Li , dev Content-Type: multipart/alternative; boundary="000000000000e4f9070593e367b9" --000000000000e4f9070593e367b9 Content-Type: text/plain; charset="UTF-8" + Arrow-dev which somehow got dropped. This sounds like a good compromise to me. On Tue, Sep 24, 2019 at 7:25 AM David Li wrote: > Hi Micah, > > Yes - LocalDate getDate() would at least make it clear how to get a > date object. DateDayVector could use a similar method, and both could > use overrides of set() to accept these values. (Seems the Time vectors > could use similar overrides of set().) > > Now that I look at it more closely, there's no enforcement that the > milliseconds value is actually a multiple of 86400000 in > DateMilliVector, either. > > Best, > David > > On 9/24/19, Micah Kornfield wrote: > > Hi David, > > Is the suggestion to add something like a LocalDate getDate method? > > > > Thanks, > > Micah > > > > On Tue, Sep 17, 2019 at 7:39 AM David Li wrote: > > > >> Maybe a utility method to get a date instead of a datetime at least > would > >> be useful? And/or documentation of the fact that the default behavior is > >> semantically incorrect, and what it does (return a datetime at midnight > >> for > >> the date). > >> > >> Best, > >> David > >> > >> On Tue, Sep 17, 2019, 04:08 Fan Liya wrote: > >> > >>> I think there are similar problems with other time related vectors. > >>> > >>> Best, > >>> Liya Fan > >>> > >>> > >>> On Tue, Sep 17, 2019 at 1:02 PM Micah Kornfield > > >>> wrote: > >>> > >>> > Anyone have an opinion on this? Personally, I'm leaning on keeping > >>> > the > >>> > existing API compatibility, but I don't feel too strongly about it. > >>> > > >>> > On Mon, Sep 9, 2019 at 7:39 PM Micah Kornfield < > emkornfield@gmail.com> > >>> > wrote: > >>> > > >>> > > Yongbo Zhang, > >>> > > Opened up a pull request to have DateMilliVector return a LocalDate > >>> > > instead of a LocalDateTime object. > >>> > > > >>> > > Do people have opinions if this breaking change is worth the > >>> correctness? > >>> > > > >>> > > Thanks, > >>> > > Micah > >>> > > > >>> > > [1] https://github.com/apache/arrow/pull/5315 > >>> > > > >>> > > On Sat, Sep 7, 2019 at 4:14 PM Yongbo Zhang < > >>> zhangyongbo0523@gmail.com> > >>> > > wrote: > >>> > > > >>> > >> Summary: [Java] DateMilliVector.getObject() should return a > >>> LocalDate, > >>> > >> not a LocalDateTime > >>> > >> Key: ARROW-1984 > >>> > >> URL: https://issues.apache.org/jira/browse/ARROW-1984 > >>> > >> Pull Request: https://github.com/apache/arrow/pull/5315 > >>> > >> Project: Apache Arrow > >>> > >> Issue Type: Bug > >>> > >> Components: Java > >>> > >> Reporter: Vanco Buca > >>> > >> Assignee: Yongbo Zhang > >>> > >> Fix For: 0.15.0 > >>> > >> > >>> > >> This is an API breaking change therefore we may want to discuss > >>> about it > >>> > >> before merging any PRs in. > >>> > >> > >>> > > > >>> > > >>> > >> > > > --000000000000e4f9070593e367b9--