arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Micah Kornfield <emkornfi...@gmail.com>
Subject Re: [Discuss] [Java] DateMilliVector.getObject() return type (LocalDateTime vs LocalDate)
Date Wed, 02 Oct 2019 01:29:42 GMT
+ Arrow-dev which somehow got dropped.

This sounds like a good compromise to me.

On Tue, Sep 24, 2019 at 7:25 AM David Li <li.davidm96@gmail.com> wrote:

> Hi Micah,
>
> Yes - LocalDate getDate() would at least make it clear how to get a
> date object. DateDayVector could use a similar method, and both could
> use overrides of set() to accept these values. (Seems the Time vectors
> could use similar overrides of set().)
>
> Now that I look at it more closely, there's no enforcement that the
> milliseconds value is actually a multiple of 86400000 in
> DateMilliVector, either.
>
> Best,
> David
>
> On 9/24/19, Micah Kornfield <emkornfield@gmail.com> wrote:
> > Hi David,
> > Is the suggestion to add something like a LocalDate getDate method?
> >
> > Thanks,
> > Micah
> >
> > On Tue, Sep 17, 2019 at 7:39 AM David Li <li.davidm96@gmail.com> wrote:
> >
> >> Maybe a utility method to get a date instead of a datetime at least
> would
> >> be useful? And/or documentation of the fact that the default behavior is
> >> semantically incorrect, and what it does (return a datetime at midnight
> >> for
> >> the date).
> >>
> >> Best,
> >> David
> >>
> >> On Tue, Sep 17, 2019, 04:08 Fan Liya <liya.fan03@gmail.com> wrote:
> >>
> >>> I think there are similar problems with other time related vectors.
> >>>
> >>> Best,
> >>> Liya Fan
> >>>
> >>>
> >>> On Tue, Sep 17, 2019 at 1:02 PM Micah Kornfield <emkornfield@gmail.com
> >
> >>> wrote:
> >>>
> >>> > Anyone have an opinion on this?  Personally, I'm leaning on keeping
> >>> > the
> >>> > existing API compatibility, but I don't feel too strongly about it.
> >>> >
> >>> > On Mon, Sep 9, 2019 at 7:39 PM Micah Kornfield <
> emkornfield@gmail.com>
> >>> > wrote:
> >>> >
> >>> > > Yongbo Zhang,
> >>> > > Opened up a pull request to have DateMilliVector return a LocalDate
> >>> > > instead of a LocalDateTime object.
> >>> > >
> >>> > > Do people have opinions if this breaking change is worth the
> >>> correctness?
> >>> > >
> >>> > > Thanks,
> >>> > > Micah
> >>> > >
> >>> > > [1] https://github.com/apache/arrow/pull/5315
> >>> > >
> >>> > > On Sat, Sep 7, 2019 at 4:14 PM Yongbo Zhang <
> >>> zhangyongbo0523@gmail.com>
> >>> > > wrote:
> >>> > >
> >>> > >> Summary: [Java] DateMilliVector.getObject() should return
a
> >>> LocalDate,
> >>> > >> not a LocalDateTime
> >>> > >> Key: ARROW-1984
> >>> > >> URL: https://issues.apache.org/jira/browse/ARROW-1984
> >>> > >> Pull Request: https://github.com/apache/arrow/pull/5315
> >>> > >> Project: Apache Arrow
> >>> > >> Issue Type: Bug
> >>> > >> Components: Java
> >>> > >> Reporter: Vanco Buca
> >>> > >> Assignee: Yongbo Zhang
> >>> > >> Fix For: 0.15.0
> >>> > >>
> >>> > >> This is an API breaking change therefore we may want to discuss
> >>> about it
> >>> > >> before merging any PRs in.
> >>> > >>
> >>> > >
> >>> >
> >>>
> >>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message