arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Wes McKinney <wesmck...@gmail.com>
Subject Re: [VOTE] Release Apache Arrow 0.15.0 - RC2
Date Mon, 07 Oct 2019 23:20:28 GMT
I think we might be a little aggressive at removing artifacts from the
dist system

Can we change our process to only remove old dist artifacts when we
are about to upload a new RC? Otherwise it's harder to make
improvements to the release verification scripts without any old RC to
test against

On Mon, Oct 7, 2019 at 5:17 PM Neal Richardson
<neal.p.richardson@gmail.com> wrote:
>
> The R package has been accepted by CRAN. Binaries for macOS and
> Windows should become available in the next few days.
>
> Neal
>
> On Mon, Oct 7, 2019 at 1:41 AM Krisztián Szűcs
> <szucs.krisztian@gmail.com> wrote:
> >
> > Thanks Andy!
> >
> > I've just removed the RC source artefacts from SVN.
> >
> > We have two remaining post release tasks:
> > - homebrew
> > - apidocs
> >
> > On Mon, Oct 7, 2019 at 1:47 AM Andy Grove <andygrove73@gmail.com> wrote:
> >
> > > I released the Rust crates from the RC2 source tarball. I had to comment
> > > out the benchmark references in the Cargo.toml first since the tarball does
> > > not include the benchmark source code. I filed
> > > https://issues.apache.org/jira/browse/ARROW-6801 for this bug and will
> > > fix the packaging before the 1.0.0 release.
> > >
> > > On Sun, Oct 6, 2019 at 2:01 AM Krisztián Szűcs <szucs.krisztian@gmail.com>
> > > wrote:
> > >
> > >> The rust publishing script fails because it cannot find the benchmarks.
> > >> Seems to be related to cargo changes.
> > >> I cannot investigate it right now, @Andy could you take a look?
> > >>
> > >> On Sun, Oct 6, 2019, 9:11 AM Krisztián Szűcs <szucs.krisztian@gmail.com>
> > >> wrote:
> > >>
> > >>> - published js packages to npm, please check that they are working
> > >>> properly
> > >>>
> > >>> On Sat, Oct 5, 2019 at 10:14 PM Neal Richardson <
> > >>> neal.p.richardson@gmail.com> wrote:
> > >>>
> > >>>> R release steps per
> > >>>>
> > >>>> https://cwiki.apache.org/confluence/display/ARROW/Release+Management+Guide#ReleaseManagementGuide-UpdatingRpackages
> > >>>> are underway.
> > >>>>
> > >>>> Neal
> > >>>>
> > >>>> On Sat, Oct 5, 2019 at 8:40 AM Krisztián Szűcs
> > >>>> <szucs.krisztian@gmail.com> wrote:
> > >>>> >
> > >>>> > - website updated with the release notes
> > >>>> > - conda-forge updates are merged
> > >>>> >
> > >>>> > Remaining:
> > >>>> > - Javascript
> > >>>> > - Rust
> > >>>> > - R
> > >>>> > - Homebrew
> > >>>> > - Apidocs
> > >>>> >
> > >>>> > On Sat, Oct 5, 2019 at 2:58 PM Sutou Kouhei <kou@clear-code.com>
> > >>>> wrote:
> > >>>> >
> > >>>> > > - uploaded C# packages
> > >>>> > >
> > >>>> > > In <CAHM19a6eoiMQZSuZ-29n7LBzHxZYxBigw=
> > >>>> T1K_vz68Rcb3MpDg@mail.gmail.com>
> > >>>> > >   "Re: [VOTE] Release Apache Arrow 0.15.0 - RC2" on Sat,
5 Oct 2019
> > >>>> > > 14:50:51 +0200,
> > >>>> > >   Krisztián Szűcs <szucs.krisztian@gmail.com>
wrote:
> > >>>> > >
> > >>>> > > > - uploaded python wheels to pypi
> > >>>> > > > - uploaded java artifacts to maven central
> > >>>> > > >
> > >>>> > > > I'm going to update the conda recipes.
> > >>>> > > >
> > >>>> > > > Remaining:
> > >>>> > > > - Javascript
> > >>>> > > > - Rust
> > >>>> > > > - C#
> > >>>> > > > - R
> > >>>> > > > - Homebrew
> > >>>> > > > - Site
> > >>>> > > >
> > >>>> > > >
> > >>>> > > >
> > >>>> > > > On Sat, Oct 5, 2019 at 2:29 PM Krisztián Szűcs
<
> > >>>> > > szucs.krisztian@gmail.com>
> > >>>> > > > wrote:
> > >>>> > > >
> > >>>> > > >> - rebased master
> > >>>> > > >> - rebased the pull requests
> > >>>> > > >> - released the jira version
> > >>>> > > >> - started the new jira version
> > >>>> > > >> - uploaded source artifacts to svn
> > >>>> > > >> - uploaded binary artifacts to bintray
> > >>>> > > >> - currently uploading python wheels to pypi
> > >>>> > > >>
> > >>>> > > >>
> > >>>> > > >> On Sat, Oct 5, 2019 at 2:04 PM Sutou Kouhei
<kou@clear-code.com>
> > >>>> wrote:
> > >>>> > > >>
> > >>>> > > >>> I'll release RubyGems.
> > >>>> > > >>>
> > >>>> > > >>> In <
> > >>>> CAHM19a5pxW5mq5ZGb7PxOERg9rkXRHmadcrPMkw12jKjokWTog@mail.gmail.com
> > >>>> > > >
> > >>>> > > >>>   "Re: [VOTE] Release Apache Arrow 0.15.0
- RC2" on Sat, 5 Oct
> > >>>> 2019
> > >>>> > > >>> 11:46:16 +0200,
> > >>>> > > >>>   Krisztián Szűcs <szucs.krisztian@gmail.com>
wrote:
> > >>>> > > >>>
> > >>>> > > >>> > On Sat, Oct 5, 2019 at 11:40 AM Krisztián
Szűcs <
> > >>>> > > >>> szucs.krisztian@gmail.com>
> > >>>> > > >>> > wrote:
> > >>>> > > >>> >
> > >>>> > > >>> >> The VOTE carries with 5 binding
+1 votes and 2 non-binding
> > >>>> +1 votes.
> > >>>> > > >>> >>
> > >>>> > > >>> >> On Fri, Oct 4, 2019 at 10:04 PM
Wes McKinney <
> > >>>> wesmckinn@gmail.com>
> > >>>> > > >>> wrote:
> > >>>> > > >>> >>
> > >>>> > > >>> >>> The commits from your local
RC branch aren't available so I
> > >>>> cannot
> > >>>> > > >>> >>> rebase master yet, I'll just
wait for you to be available
> > >>>> again.
> > >>>> > > >>> >>
> > >>>> > > >>> >> Actually those commits are available
under the tag.
> > >>>> > > >>> >>
> > >>>> > > >>> > The new version updates are indeed
only available locally.
> > >>>> I'm doing
> > >>>> > > the
> > >>>> > > >>> > rebase.
> > >>>> > > >>> >
> > >>>> > > >>> >> If anyone has some spare time we
should try to complete as
> > >>>> many
> > >>>> > > >>> >>> post-release tasks this weekend
so we can announce the
> > >>>> release on
> > >>>> > > >>> >>> Monday or Tuesday next week.
> > >>>> > > >>> >>>
> > >>>> > > >>> >>
> > >>>> > > >>> >> We have many post-release tasks,
any help is appreciated.
> > >>>> > > >>> >>
> > >>>> > > >>> >>>
> > >>>> > > >>> >>> Thanks all for your help getting
this release ready!
> > >>>> > > >>> >>>
> > >>>> > > >>> >>> On Fri, Oct 4, 2019 at 6:40
AM Krisztián Szűcs
> > >>>> > > >>> >>> <szucs.krisztian@gmail.com>
wrote:
> > >>>> > > >>> >>> >
> > >>>> > > >>> >>> > We have 5 binding +1 votes
and 2 non-binding +1 votes so
> > >>>> far.
> > >>>> > > >>> >>> > The 72 hours has passed,
so we can close the release vote.
> > >>>> > > >>> >>> >
> > >>>> > > >>> >>> > Sadly I won't be available
for the rest of the day, so I
> > >>>> will be
> > >>>> > > >>> able
> > >>>> > > >>> >>> > to close the vote and
start to work on the the post
> > >>>> release tasks
> > >>>> > > >>> >>> > from tomorrow.
> > >>>> > > >>> >>> > @Wes if you have bandwidth
feel free to close the vote
> > >>>> sooner.
> > >>>> > > >>> >>> >
> > >>>> > > >>> >>> >
> > >>>> > > >>> >>> > On Thu, Oct 3, 2019 at
1:14 AM Bryan Cutler <
> > >>>> cutlerb@gmail.com>
> > >>>> > > >>> wrote:
> > >>>> > > >>> >>> >
> > >>>> > > >>> >>> > > Accidentally sent
too soon. The ORC build error I got
> > >>>> was
> > >>>> > > probably
> > >>>> > > >>> >>> just an
> > >>>> > > >>> >>> > > env issue for me,
but here it is in case anyone else
> > >>>> had the
> > >>>> > > same
> > >>>> > > >>> >>> issue:
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>> > > In file included
from
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>>
> > >>>> > > >>>
> > >>>> > >
> > >>>> ESC[01mESC[K/tmp/arrow-0.15.0.KxYbA/apache-arrow-0.15.0/cpp/build/orc_ep-prefix/src/orc_ep/c++/src/wrap/orc-proto-wrapper.cc:44:0ESC[mESC[K:
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>>
> > >>>> > > >>>
> > >>>> > >
> > >>>> ESC[01mESC[K/tmp/arrow-0.15.0.KxYbA/apache-arrow-0.15.0/cpp/build/orc_ep-prefix/src/orc_ep-build/c++/src/
> > >>>> > > >>> >>> orc_proto.pb.cc:970
> > >>>> > > >>> >>> > > :13:ESC[mESC[K
> > >>>> > > >>> >>> > > ESC[01;31mESC[Kerror:
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>>
> > >>>> > > >>>
> > >>>> > >
> > >>>> ESC[mESC[K‘ESC[01mESC[Kdynamic_init_dummy_orc_5fproto_2eprotoESC[mESC[K’
> > >>>> > > >>> >>> > > defined but not used
[-Werror=unused-variable]
> > >>>> > > >>> >>> > >  static bool dynamic_init_dummy_orc_5fproto_2eproto
=
> > >>>> []() {
> > >>>> > > >>> >>> > > AddDescriptors_orc_5fproto_2eproto();
return true; }();
> > >>>> > > >>> >>> > > ESC[01;32mESC[K 
           ^ESC[mESC[K
> > >>>> > > >>> >>> > > cc1plus: all warnings
being treated as errors
> > >>>> > > >>> >>> > > make[5]: ***
> > >>>> > > >>> [c++/src/CMakeFiles/orc.dir/wrap/orc-proto-wrapper.cc.o]
> > >>>> > > >>> >>> Error
> > >>>> > > >>> >>> > > 1
> > >>>> > > >>> >>> > > make[5]: *** Waiting
for unfinished jobs....
> > >>>> > > >>> >>> > > make[4]: *** [c++/src/CMakeFiles/orc.dir/all]
Error 2
> > >>>> > > >>> >>> > > make[3]: *** [all]
Error 2
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>> > > [ 29%] Performing
build step for 'orc_ep'
> > >>>> > > >>> >>> > > CMake Error at
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>>
> > >>>> > > >>>
> > >>>> > >
> > >>>> /tmp/arrow-0.15.0.KxYbA/apache-arrow-0.15.0/cpp/build/orc_ep-prefix/src/orc_ep-stamp/orc_ep-build-RELEASE.cmake:16
> > >>>> > > >>> >>> > > (message):
> > >>>> > > >>> >>> > >   Command failed:
2
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>> > >    'make'
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>> > >   See also
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>>
> > >>>> > > >>>
> > >>>> > >
> > >>>> /tmp/arrow-0.15.0.KxYbA/apache-arrow-0.15.0/cpp/build/orc_ep-prefix/src/orc_ep-stamp/orc_ep-build-*.log
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>> > > CMakeFiles/orc_ep.dir/build.make:111:
recipe for target
> > >>>> > > >>> >>> > > 'orc_ep-prefix/src/orc_ep-stamp/orc_ep-build'
failed
> > >>>> > > >>> >>> > > make[2]: ***
> > >>>> [orc_ep-prefix/src/orc_ep-stamp/orc_ep-build]
> > >>>> > > Error 1
> > >>>> > > >>> >>> > > CMakeFiles/Makefile2:1248:
recipe for target
> > >>>> > > >>> >>> 'CMakeFiles/orc_ep.dir/all'
> > >>>> > > >>> >>> > > failed
> > >>>> > > >>> >>> > > make[1]: *** [CMakeFiles/orc_ep.dir/all]
Error 2
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>> > > On Wed, Oct 2, 2019
at 4:12 PM Bryan Cutler <
> > >>>> cutlerb@gmail.com
> > >>>> > > >
> > >>>> > > >>> >>> wrote:
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>> > > > +1 (non-binding)
> > >>>> > > >>> >>> > > >
> > >>>> > > >>> >>> > > > I ran the following
on Ubuntu 16.04 4.15.0-64-generic:
> > >>>> > > >>> >>> > > > > dev/release/verify-release-candidate.sh
binaries
> > >>>> 0.15.0 2
> > >>>> > > >>> >>> > > > > ARROW_CUDA=OFF
\
> > >>>> > > >>> >>> > > > TEST_DEFAULT=0
\
> > >>>> > > >>> >>> > > > TEST_SOURCE=1
\
> > >>>> > > >>> >>> > > > TEST_CPP=1 \
> > >>>> > > >>> >>> > > > TEST_PYTHON=1
\
> > >>>> > > >>> >>> > > > TEST_JAVA=1
\
> > >>>> > > >>> >>> > > > TEST_INTEGRATION=1
\
> > >>>> > > >>> >>> > > > dev/release/verify-release-candidate.sh
source 0.15.0
> > >>>> 2
> > >>>> > > >>> >>> > > >
> > >>>> > > >>> >>> > > > For source verification
I set
> > >>>> > > >>> INTEGRATION_TEST_ARGS="--enable-js=0
> > >>>> > > >>> >>> > > > --enable-go=0"
> > >>>> > > >>> >>> > > >
> > >>>> > > >>> >>> > > > When attempting
source verification with defaults, I
> > >>>> got the
> > >>>> > > >>> below
> > >>>> > > >>> >>> error
> > >>>> > > >>> >>> > > > when building
the ORC adapter. It looks like just a
> > >>>> warning
> > >>>> > > >>> that is
> > >>>> > > >>> >>> being
> > >>>> > > >>> >>> > > > treated as error
and seems to be only in
> > >>>> > > >>> >>> > > >
> > >>>> > > >>> >>> > > > On Wed, Oct
2, 2019 at 7:53 AM Andy Grove <
> > >>>> > > >>> andygrove73@gmail.com>
> > >>>> > > >>> >>> wrote:
> > >>>> > > >>> >>> > > >
> > >>>> > > >>> >>> > > >> +1 (binding)
> > >>>> > > >>> >>> > > >>
> > >>>> > > >>> >>> > > >> On Mon,
Sep 30, 2019 at 11:57 PM Krisztián Szűcs <
> > >>>> > > >>> >>> > > >> szucs.krisztian@gmail.com>
> > >>>> > > >>> >>> > > >> wrote:
> > >>>> > > >>> >>> > > >>
> > >>>> > > >>> >>> > > >> > Hi,
> > >>>> > > >>> >>> > > >> >
> > >>>> > > >>> >>> > > >> > I would
like to propose the following release
> > >>>> candidate
> > >>>> > > >>> (RC2) of
> > >>>> > > >>> >>> > > Apache
> > >>>> > > >>> >>> > > >> > Arrow
version 0.15.0. This is a release consiting
> > >>>> of 697
> > >>>> > > >>> >>> > > >> > resolved
JIRA issues[1].
> > >>>> > > >>> >>> > > >> >
> > >>>> > > >>> >>> > > >> > This
release candidate is based on commit:
> > >>>> > > >>> >>> > > >> > 40d468e162e88e1761b1e80b3ead060f0be927ee
[2]
> > >>>> > > >>> >>> > > >> >
> > >>>> > > >>> >>> > > >> > The
source release rc2 is hosted at [3].
> > >>>> > > >>> >>> > > >> > The
binary artifacts are hosted at [4][5][6][7].
> > >>>> > > >>> >>> > > >> > The
changelog is located at [8].
> > >>>> > > >>> >>> > > >> >
> > >>>> > > >>> >>> > > >> > Please
download, verify checksums and signatures,
> > >>>> run the
> > >>>> > > >>> unit
> > >>>> > > >>> >>> tests,
> > >>>> > > >>> >>> > > >> > and
vote on the release. See [9] for how to
> > >>>> validate a
> > >>>> > > >>> release
> > >>>> > > >>> >>> > > >> candidate.
> > >>>> > > >>> >>> > > >> >
> > >>>> > > >>> >>> > > >> > The
vote will be open for at least 72 hours.
> > >>>> > > >>> >>> > > >> >
> > >>>> > > >>> >>> > > >> > [ ]
+1 Release this as Apache Arrow 0.15.0
> > >>>> > > >>> >>> > > >> > [ ]
+0
> > >>>> > > >>> >>> > > >> > [ ]
-1 Do not release this as Apache Arrow 0.15.0
> > >>>> > > because...
> > >>>> > > >>> >>> > > >> >
> > >>>> > > >>> >>> > > >> > [1]:
> > >>>> > > >>> >>> > > >> >
> > >>>> > > >>> >>> > > >> >
> > >>>> > > >>> >>> > > >>
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>>
> > >>>> > > >>>
> > >>>> > >
> > >>>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20%28Resolved%2C%20Closed%29%20AND%20fixVersion%20%3D%200.15.0
> > >>>> > > >>> >>> > > >> > [2]:
> > >>>> > > >>> >>> > > >> >
> > >>>> > > >>> >>> > > >> >
> > >>>> > > >>> >>> > > >>
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>>
> > >>>> > > >>>
> > >>>> > >
> > >>>> https://github.com/apache/arrow/tree/40d468e162e88e1761b1e80b3ead060f0be927ee
> > >>>> > > >>> >>> > > >> > [3]:
> > >>>> > > >>> >>> > > >>
> > >>>> > > >>> >>>
> > >>>> > >
> > >>>> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.15.0-rc2
> > >>>> > > >>> >>> > > >> > [4]:
> > >>>> > > https://bintray.com/apache/arrow/centos-rc/0.15.0-rc2
> > >>>> > > >>> >>> > > >> > [5]:
> > >>>> > > https://bintray.com/apache/arrow/debian-rc/0.15.0-rc2
> > >>>> > > >>> >>> > > >> > [6]:
> > >>>> > > https://bintray.com/apache/arrow/python-rc/0.15.0-rc2
> > >>>> > > >>> >>> > > >> > [7]:
> > >>>> > > https://bintray.com/apache/arrow/ubuntu-rc/0.15.0-rc2
> > >>>> > > >>> >>> > > >> > [8]:
> > >>>> > > >>> >>> > > >> >
> > >>>> > > >>> >>> > > >> >
> > >>>> > > >>> >>> > > >>
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>>
> > >>>> > > >>>
> > >>>> > >
> > >>>> https://github.com/apache/arrow/blob/40d468e162e88e1761b1e80b3ead060f0be927ee/CHANGELOG.md
> > >>>> > > >>> >>> > > >> > [9]:
> > >>>> > > >>> >>> > > >> >
> > >>>> > > >>> >>> > > >> >
> > >>>> > > >>> >>> > > >>
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>>
> > >>>> > > >>>
> > >>>> > >
> > >>>> https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates
> > >>>> > > >>> >>> > > >> >
> > >>>> > > >>> >>> > > >>
> > >>>> > > >>> >>> > > >
> > >>>> > > >>> >>> > >
> > >>>> > > >>> >>>
> > >>>> > > >>> >>
> > >>>> > > >>>
> > >>>> > > >>
> > >>>> > >
> > >>>>
> > >>>

Mime
View raw message