arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Li <li.david...@gmail.com>
Subject Re: [Discuss][FlightRPC] Extensions to Flight: middleware and DoPut tickets
Date Tue, 01 Oct 2019 14:36:21 GMT
Following up on this, I've put up the C++/Python implementation as
well: https://github.com/apache/arrow/pull/5552

The two are likely not fully compatible, since I'm aware of at least
one case where the gRPC implementations differ - I want to set up real
integration tests for these things as part of ARROW-5875
(https://issues.apache.org/jira/browse/ARROW-5875).

For the DoPut discussion, I'm going to table that for now unless
there's more interest, as I'd like to focus on this (and another
Flight feature that I've been working on a proposal for).

Best,
David

On 9/9/19, David Li <li.davidm96@gmail.com> wrote:
> I'm happy to start a new thread to focus on DoPut specifically.
> Middleware for Java has been in review.
>
> Best,
> David
>
> On 9/9/19, Wes McKinney <wesmckinn@gmail.com> wrote:
>> Ah, I think I'm referring to the format change around DoPut, for which
>> there is not a PR yet. Sorry for my confusion
>>
>> Do we want to start a separate discussion thread about that?
>>
>> https://docs.google.com/document/d/1hrwxNwPU1aOD_1ciRUOaGeUCyXYOmu6IxxCfY6Stj6w/edit?usp=sharing
>>
>> On Mon, Sep 9, 2019 at 3:51 PM Antoine Pitrou <antoine@python.org> wrote:
>>>
>>>
>>> Isn't a middleware an implementation-specific concern?  Does it need a
>>> formal vote?
>>>
>>> Regards
>>>
>>> Antoine.
>>>
>>>
>>> Le 09/09/2019 à 22:49, Wes McKinney a écrit :
>>> > It seems like there is positive feedback on the PR. Do we want to have
>>> > a vote about this?
>>> >
>>> > On Mon, Aug 12, 2019 at 7:54 AM David Li <li.davidm96@gmail.com>
>>> > wrote:
>>> >>
>>> >> I've (finally) put up a draft implementation of middleware for Java:
>>> >> https://github.com/apache/arrow/pull/5068
>>> >>
>>> >> Hopefully this helps clarify how the proposal works.
>>> >>
>>> >> Best,
>>> >> David
>>> >>
>>> >> On 7/25/19, David Li <li.davidm96@gmail.com> wrote:
>>> >>> Thanks for the feedback, Antoine. That would be a natural method
to
>>> >>> have - then the server could deny uploads (as you mention) or note
>>> >>> that the stream already exists. I've updated the proposal to reflect
>>> >>> that, leaving more detailed semantics (e.g. append vs overwrite)
>>> >>> application-defined.
>>> >>>
>>> >>> Best,
>>> >>> David
>>> >>>
>>> >>> On 7/25/19, Antoine Pitrou <antoine@python.org> wrote:
>>> >>>>
>>> >>>> Le 08/07/2019 à 16:33, David Li a écrit :
>>> >>>>> Hi all,
>>> >>>>>
>>> >>>>> I've put together two more proposals for Flight, motivated
by
>>> >>>>> projects
>>> >>>>> we've been working on. I'd appreciate any comments on the
>>> >>>>> design/reasoning; I'm already working on the implementation,
>>> >>>>> alongside
>>> >>>>> some other improvements to Flight.
>>> >>>>>
>>> >>>>> The first is to modify the DoPut call to follow the same
request
>>> >>>>> pattern as DoGet. This is a format change and would require
a
>>> >>>>> vote.
>>> >>>>>
>>> >>>>> https://docs.google.com/document/d/1hrwxNwPU1aOD_1ciRUOaGeUCyXYOmu6IxxCfY6Stj6w/edit?usp=sharing
>>> >>>>
>>> >>>> It seems it would be useful to introduce a GetPutInfo (or
>>> >>>> GetUploadInfo)
>>> >>>> so as to allow differential behaviour between getting and putting.
>>> >>>>
>>> >>>> (one trivial case would be to disallow uploading altogether
:-)))
>>> >>>>
>>> >>>> Regards
>>> >>>>
>>> >>>> Antoine.
>>> >>>>
>>> >>>
>>
>

Mime
View raw message