From dev-return-11961-archive-asf-public=cust-asf.ponee.io@arrow.apache.org Sun May 5 22:57:27 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D36D318066B for ; Mon, 6 May 2019 00:57:26 +0200 (CEST) Received: (qmail 23108 invoked by uid 500); 5 May 2019 22:57:24 -0000 Mailing-List: contact dev-help@arrow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@arrow.apache.org Delivered-To: mailing list dev@arrow.apache.org Received: (qmail 23096 invoked by uid 99); 5 May 2019 22:57:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 May 2019 22:57:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id CEA1EC2C61 for ; Sun, 5 May 2019 22:57:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.2 X-Spam-Level: X-Spam-Status: No, score=-0.2 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id L6HDiZUVrM3b for ; Sun, 5 May 2019 22:57:21 +0000 (UTC) Received: from mail-it1-f179.google.com (mail-it1-f179.google.com [209.85.166.179]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 3BEB361172 for ; Sun, 5 May 2019 22:57:21 +0000 (UTC) Received: by mail-it1-f179.google.com with SMTP id q132so2281163itc.5 for ; Sun, 05 May 2019 15:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=d0a6+tm66dhXWJR5aEnRmTZaXNpyOwkMvV6r8o3PPS8=; b=dl1GCplV4z4qUQImEgwCUvjjXCQqSZPcl+Et/d0wqQVSfi9y7hq6Mz5hPytypzC4Ky o9JODL70Ur0Q7SU6mCooacul/Ms4c7WksQZxxZiZ8lSM/hLUzcf4myJHpSpQi9l6Y5b1 7/EZUdciTT8WLN/hkbRs/DL4u66iPdH7Yyrq6rU7s0ubhSc++dwpQSqeydOJX38ywGby 67k6Yv0sE9mlrfdcohy2AaiHX8H5LgIjwo3QUtv15yzhts0Jw9Hu04m4Jx5gWgGypwNS U/D04T6xsy9xkSXqyrWnenPZuagDTKyzcs7TxJgWqQWd5M896ZncNKaGNC8fOLD75QeC oVaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=d0a6+tm66dhXWJR5aEnRmTZaXNpyOwkMvV6r8o3PPS8=; b=cJIucrwh7UwZybT2bKHbwuHm3syjSXfKiomJRye7AwPcyeJQra6W/Te9mAzJCptw3e 3jF+wiAfeWpMHQl8HbPyvvvszjIpw7vRN2w7nywPpYxOiIm2Pq+ca2d9NzDLcTbB4JJD I643tDVICRl6Pb4C3fnubJuo2tX7rVRg1/Uy3N/ePRAmpg6s5W2M4d5B36aVgxsBwvYL e5hahJw1ulfwqH3vzcIQ6U75R4T/3hFknEgpJ3aslsFJjG6IkF1oizOn8PxqIaeNd/zm 10iW+L14cqGo17+K+Ao5svzy/YcnOwt/DoxnLG+8vSwAYGeZCPFqjVhGAxrDPp7ILa8g Hrjw== X-Gm-Message-State: APjAAAWhnrt/M/ciUPN1gjvLDFKp4Ecf51sFXeR/aqNp3rRY3JHKG0CO e2TI4RsK4jPukG7vqgsMdD0MHMaavGmG5js9kepdSt+2 X-Google-Smtp-Source: APXvYqxUI/mZoHyYVru+okZ2Ifzb507j98woMZshZExeB9sc8HlwsN/Ox3ERlLghraJf5FfggKBGbz4oKY+NqaNgOU8= X-Received: by 2002:a24:b713:: with SMTP id h19mr15727647itf.73.1557097033431; Sun, 05 May 2019 15:57:13 -0700 (PDT) MIME-Version: 1.0 References: <20190406.094349.1911465513877593279.kou@clear-code.com> <27d5e224-0fca-41f3-8e6a-28d2dc510c07@www.fastmail.com> In-Reply-To: From: Wes McKinney Date: Sun, 5 May 2019 17:56:37 -0500 Message-ID: Subject: Re: [VOTE] Add new DurationInterval Type to Arrow Format To: dev@arrow.apache.org Cc: Micah Kornfield Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable OK -- Micah -- I think it's fine to change from DurationInterval -> Duration if no one else chimes in here by tomorrow or so On Sun, May 5, 2019 at 5:02 AM Jacques Nadeau wrote: > > yeah, I think Duration is better than DurationInterval > > On Sat, May 4, 2019 at 3:35 AM Wes McKinney wrote: > > > I've just reviewed the format and C++ changes in > > https://github.com/apache/arrow/pull/3644 which look good to me modulo > > minor comments. > > > > Can someone take a look at the Java changes soon so we move this > > toward completion? > > > > One question came up of whether "DurationInterval" is the name we > > want. It might be more clear to call it simply "Duration" > > > > On Tue, Apr 30, 2019 at 6:57 PM Micah Kornfield > > wrote: > > > > > > Sorry for the type OK, I think https://github.com/apache/arrow/pull/3= 644 > > is > > > now ready to review. > > > > > > On Tue, Apr 30, 2019 at 4:56 PM Micah Kornfield > > > wrote: > > > > > > > OK, I think https://github.com/apache/arrow/pull/3644 is no ready t= o > > > > review. > > > > > > > > It includes Java implementation of DurationInterval and C++ > > > > implementations of DurationInterval and the original interval types= . I > > > > added documentation to Schema.fbs regarding the original interval t= ypes > > > > (TL;DR; YEAR_MONTH is expected to be supported by all implementatio= ns > > > > DAY_TIME is not, which I believe as based on previous ML > > conversations). > > > > Please let me know if there are issues with this language and I can > > remove > > > > it. > > > > > > > > > > > > On Monday, April 8, 2019, Kriszti=C3=A1n Sz=C5=B1cs > > > > wrote: > > > > > > > >> The vote carries with 4 binding +1 votes. > > > >> > > > >> Micah, what are the next steps? > > > >> Are You going to finalize the PR? > > > >> > > > >> On Sun, Apr 7, 2019 at 11:13 AM Uwe L. Korn wro= te: > > > >> > > > >> > +1 (binding) > > > >> > > > > >> > On Sat, Apr 6, 2019, at 2:44 AM, Kouhei Sutou wrote: > > > >> > > +1 (binding) > > > >> > > > > > >> > > In > > >> pkw@mail.gmail.com> > > > >> > > "[VOTE] Add new DurationInterval Type to Arrow Format" on We= d, > > 3 Apr > > > >> > > 2019 07:59:56 -0700, > > > >> > > Jacques Nadeau wrote: > > > >> > > > > > >> > > > I'd like to propose a change to the Arrow format to support = a > > new > > > >> > duration > > > >> > > > type. Details below. Threads on mailing list around discussi= on. > > > >> > > > > > > >> > > > > > > >> > > > // An absolute length of time unrelated to any calendar > > artifacts. > > > >> > For the > > > >> > > > purposes > > > >> > > > /// of Arrow Implementations, adding this value to a Timesta= mp > > > >> ("t1") > > > >> > > > naively (i.e. simply summing > > > >> > > > /// the two number) is acceptable even though in some cases = the > > > >> > resulting > > > >> > > > Timestamp (t2) would > > > >> > > > /// not account for leap-seconds during the elapsed time bet= ween > > > >> "t1" > > > >> > and > > > >> > > > "t2". Similarly, representing > > > >> > > > /// the difference between two Unix timestamp is acceptable,= but > > > >> would > > > >> > > > yield a value that is possibly a few seconds > > > >> > > > /// off from the true elapsed time. > > > >> > > > /// > > > >> > > > /// The resolution defaults to > > > >> > > > /// millisecond, but can be any of the other supported TimeU= nit > > > >> values > > > >> > as > > > >> > > > /// with Timestamp and Time types. This type is always > > represented > > > >> as > > > >> > > > /// an 8-byte integer. > > > >> > > > table DurationInterval { > > > >> > > > unit: TimeUnit =3D MILLISECOND; > > > >> > > > } > > > >> > > > > > > >> > > > > > > >> > > > Please vote whether to accept the changes. The vote will be = open > > > >> > > > for at least 72 hours. > > > >> > > > > > > >> > > > [ ] +1 Accept these changes to the Flight protocol > > > >> > > > [ ] +0 > > > >> > > > [ ] -1 Do not accept the changes because... > > > >> > > > > > >> > > > > >> > > > > > >