From dev-return-11502-archive-asf-public=cust-asf.ponee.io@arrow.apache.org Mon Apr 1 13:03:59 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3D7D9180621 for ; Mon, 1 Apr 2019 15:03:58 +0200 (CEST) Received: (qmail 47000 invoked by uid 500); 1 Apr 2019 13:03:57 -0000 Mailing-List: contact dev-help@arrow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@arrow.apache.org Delivered-To: mailing list dev@arrow.apache.org Received: (qmail 46986 invoked by uid 99); 1 Apr 2019 13:03:57 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Apr 2019 13:03:57 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8E6ACE29DE for ; Mon, 1 Apr 2019 12:53:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 23F6A24597 for ; Mon, 1 Apr 2019 12:53:02 +0000 (UTC) Date: Mon, 1 Apr 2019 12:53:02 +0000 (UTC) From: "David Li (JIRA)" To: dev@arrow.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (ARROW-5081) [C++] Consistently use PATH_SUFFIXES in CMake config MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 David Li created ARROW-5081: ------------------------------- Summary: [C++] Consistently use PATH_SUFFIXES in CMake config Key: ARROW-5081 URL: https://issues.apache.org/jira/browse/ARROW-5081 Project: Apache Arrow Issue Type: Improvement Components: C++ Reporter: David Li In trying to set up a build using system libraries installed to non-default paths, CMake doesn't consistently search user-specified paths for libraries. For instance, FindDoubleConversion.cmake will look only at ${DoubleConversion_ROOT}/libdoubleconversion.so for the shared library, making it impossible to have a directory setup like doubleconversion/lib/*.so + doubleconversion/include. Other Find*.cmake files set PATH_SUFFIXES to also search the lib/ subdirectory; we should do this everywhere. Additionally, it seems the various Find*.cmake files set PATH_SUFFIXES inconsistently. Some hardcode their own list, others use CMAKE_LIBRARY_ARCHITECTURE. -- This message was sent by Atlassian JIRA (v7.6.3#76005)