From dev-return-11131-archive-asf-public=cust-asf.ponee.io@arrow.apache.org Mon Mar 18 11:56:55 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C2C37180651 for ; Mon, 18 Mar 2019 12:56:54 +0100 (CET) Received: (qmail 92307 invoked by uid 500); 18 Mar 2019 11:56:53 -0000 Mailing-List: contact dev-help@arrow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@arrow.apache.org Delivered-To: mailing list dev@arrow.apache.org Received: (qmail 92296 invoked by uid 99); 18 Mar 2019 11:56:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Mar 2019 11:56:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 5EE2DC2228 for ; Mon, 18 Mar 2019 11:56:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.002 X-Spam-Level: **** X-Spam-Status: No, score=4.002 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, KAM_LAZY_DOMAIN_SECURITY=1, RDNS_NONE=3, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id fdDer36J_BLV for ; Mon, 18 Mar 2019 11:56:48 +0000 (UTC) Received: from blaine.gmane.org (unknown [195.159.176.226]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 713976111B for ; Mon, 18 Mar 2019 11:56:48 +0000 (UTC) Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h5qsp-000HVM-79 for dev@arrow.apache.org; Mon, 18 Mar 2019 12:56:47 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: dev@arrow.apache.org From: Antoine Pitrou Subject: Re: URI library for C++ Date: Mon, 18 Mar 2019 12:56:40 +0100 Message-ID: <20190318125640.2203e5ca@fsol> References: <20190227170604.70eb5a33@fsol> <20190227172959.3da02511@fsol> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Newsreader: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Hi Uwe, I am working on integrating uriparser into Arrow and I am using the CMake support indeed: https://github.com/apache/arrow/compare/master...pitrou:ARROW-4697-cpp-uri-= parsing Regards Antoine. On Mon, 18 Mar 2019 05:58:26 -0400 "Uwe L. Korn" wrote: > I have looked into packaging uriparser for conda-forge to have it availa= ble in our build system and it feels to me that we rather should wait for t= heir next release where they switch the build system over to CMake. This wi= ll make packaging in conda and the ExternalProject much easier. Not sure if= anyone has already engaged with them but that would save us a bit of work. >=20 > Uwe >=20 > On Wed, Feb 27, 2019, at 5:38 PM, Francois Saint-Jacques wrote: > > I agree that vendoring curl is crazyness, my main point is that curl now > > has a url api. If we can find a way to avoid pulling another dependency. > >=20 > > On Wed, Feb 27, 2019 at 11:30 AM Antoine Pitrou w= rote: > > =20 > > > > > > Vendoring curl sounds a bit crazy IMHO. We'll end up having to vendo= r a > > > TLS library and who knows what else... > > > > > > Regards > > > > > > Antoine. > > > > > > > > > On Wed, 27 Feb 2019 11:16:49 -0500 > > > Francois Saint-Jacques wrote: =20 > > > > There's a good chance we end up using curl for the dataset project.= Curl > > > > has a new url API https://github.com/curl/curl/wiki/URL-API , but it > > > > requires a recent version (7.62.0 october 2018) which means vendori= ng. > > > > > > > > Fran=C3=A7ois > > > > > > > > On Wed, Feb 27, 2019 at 11:06 AM Antoine Pitrou =20 > > > wrote: =20 > > > > =20 > > > > > > > > > > Hello, > > > > > > > > > > As part of ARROW-4651, we would need to have a URI parsing librar= y in > > > > > the C++ project. > > > > > > > > > > One such library is https://github.com/cpp-netlib/uri, it's based= on a > > > > > previous proposal for the standard C++ library. It has no depend= encies > > > > > except boost::algorithm. > > > > > > > > > > One problem is that the library ships its own backports of > > > > > `std::string_view` and `std::optional`. We already have a backpo= rt of > > > > > `std::string_view` in our source tree (it seems more complete). = So we > > > > > would need to patch the uri library to use our backport. Maintai= ning > > > > > the patch will be a bit annoying. > > > > > > > > > > Another possibility is to use the C-only, no-dependencies uripars= er > > > > > library (and write a small C++ wrapper around it): > > > > > https://uriparser.github.io/ > > > > > > > > > > Regards > > > > > > > > > > Antoine. > > > > > > > > > > > > > > > =20 > > > > =20 > > > > > > > > > > > > =20 > > =20 >=20