arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kouhei Sutou <...@clear-code.com>
Subject Re: [VOTE] Release Apache Arrow 0.13.0 - RC4
Date Fri, 29 Mar 2019 02:38:18 GMT
Hi Wes,

Thanks for verifying the RC.
We need to use "ON" for ARROW_CUDA instead of "1". Because
we compare ARROW_CUDA with "ON" in the verify script:

https://github.com/apache/arrow/blob/master/dev/release/verify-release-candidate.sh#L243-L245
https://github.com/apache/arrow/blob/master/dev/release/verify-release-candidate.sh#L295-L297

If we use "1", we just build CUDA related codes but we don't
run CUDA related tests.


Thanks,
--
kou

In <CAJPUwMAfKFDr2DgW2JS7G4XgwSW=aneAAcLjp8D9VsLb7KcoHg@mail.gmail.com>
  "Re: [VOTE] Release Apache Arrow 0.13.0 - RC4" on Thu, 28 Mar 2019 20:29:39 -0500,
  Wes McKinney <wesmckinn@gmail.com> wrote:

> +1 (binding)
> 
> * Verified source on Ubuntu 14.04 with
> 
> ARROW_CUDA=0 ARROW_BOOST_VENDORED=1
> dev/release/verify-release-candidate.sh source 0.13.0 4
> I ran into ARROW-5059 but otherwise all the tests passed
> 
> * Verified source on Ubuntu 18.10 with ARROW_CUDA=1 and system boost
> * Ran verification script on Windows 10
> 
> Thanks Kou for being the RM!
> 
> On Thu, Mar 28, 2019 at 6:08 PM Krisztián Szűcs
> <szucs.krisztian@gmail.com> wrote:
>>
>> +1 (binding)
>>
>> Both the source and binary verification passed on OSX.
>> A minor plasma issue occurred in python and ruby tests:
>> https://issues.apache.org/jira/browse/ARROW-5060
>>
>> Installed wheels on OSX-py36 and debian-py37, both are
>> working. If anyone has a windows box, please install the
>> windows wheel from [1] and check the imports:
>>
>> python -c "import pyarrow; import pyarrow.parquet; import pyarrow.gandiva;"
>>
>> [1]:
>> https://bintray.com/apache/arrow/python-rc/0.13.0-rc4#files/python-rc/0.13.0-rc4
>>
>> On Thu, Mar 28, 2019 at 10:12 PM Kouhei Sutou <kou@clear-code.com> wrote:
>>
>> > Hi Bryan,
>> >
>> > Thanks for verifying this RC.
>> >
>> > We've changed ARROW_HAVE_CUDA=NO to ARROW_CUDA=OFF:
>> >   https://issues.apache.org/jira/browse/ARROW-4696
>> >
>> > I've updated the "How to Verify Release Candidates" page:
>> >
>> > https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates
>> >
>> > Thanks,
>> > --
>> > kou
>> >
>> > In <CABr4ZARqm790qnjavy3zzFNZ_t2XhX51YuJEaSU-+tUpkProrA@mail.gmail.com>
>> >   "Re: [VOTE] Release Apache Arrow 0.13.0 - RC4" on Thu, 28 Mar 2019
>> > 12:10:13 -0700,
>> >   Bryan Cutler <cutlerb@gmail.com> wrote:
>> >
>> > > +1 (non-binding)
>> > >
>> > > Ran:
>> > > ARROW_HAVE_CUDA=NO dev/release/verify-release-candidate.sh source 0.13.0
>> > 4
>> > >
>> > > With tests:
>> > >   : ${TEST_DEFAULT:=1}
>> > >   : ${TEST_JAVA:=${TEST_DEFAULT}}
>> > >   : ${TEST_CPP:=${TEST_DEFAULT}}
>> > >   : ${TEST_GLIB:=0}
>> > >   : ${TEST_RUBY:=0}
>> > >   : ${TEST_PYTHON:=${TEST_DEFAULT}}
>> > >   : ${TEST_JS:=0}
>> > >   : ${TEST_INTEGRATION:=${TEST_DEFAULT}}
>> > >   : ${TEST_RUST:=0}
>> > >
>> > > On Thu, Mar 28, 2019 at 9:03 AM Ben Kietzman <ben.kietzman@rstudio.com>
>> > > wrote:
>> > >
>> > >> +1 (non-binding)
>> > >>
>> > >> Builds and passes tests on Windows 10
>> > >>
>> > >> Ben Kietzman
>> > >>
>> > >> On Thu, Mar 28, 2019 at 11:50 AM Andy Grove <andygrove73@gmail.com>
>> > wrote:
>> > >> >
>> > >> > Some of the Rust tests fail unless I manually copy some arrow
test
>> > files
>> > >> > into the directory, then they pass. I filed
>> > >> > https://issues.apache.org/jira/browse/ARROW-5053 to resolve this.
>> > >> However,
>> > >> > I don't think this is significant enough to block the release.
I will
>> > aim
>> > >> > to resolve this today though, just in case we have another RC.
>> > >> >
>> > >> > +1 (binding)
>> > >> >
>> > >> > I have only tested the Rust implementation.
>> > >> >
>> > >> >
>> > >> >
>> > >> > On Thu, Mar 28, 2019 at 7:06 AM Francois Saint-Jacques <
>> > >> > fsaintjacques@gmail.com> wrote:
>> > >> >
>> > >> > > +1 (non-binding)
>> > >> > >
>> > >> > > No issues with the latest release-verify script on Ubuntu18.04.
>> > >> > >
>> > >> > > François
>> > >> > >
>> > >> > > On Thu, Mar 28, 2019 at 6:00 AM Kouhei Sutou <kou@clear-code.com>
>> > >> wrote:
>> > >> > >
>> > >> > > > Hi,
>> > >> > > >
>> > >> > > > I would like to propose the following release candidate
(RC4) of
>> > >> Apache
>> > >> > > > Arrow version 0.13.0. This is a release consiting of
596
>> > >> > > > resolved JIRA issues[1].
>> > >> > > >
>> > >> > > > This release candidate is based on commit:
>> > >> > > > dfb9e7af3cd92722893a3819b6676dfdef08f896 [2]
>> > >> > > >
>> > >> > > > The source release rc4 is hosted at [3].
>> > >> > > > The binary artifacts are hosted at [4][5][6][7].
>> > >> > > > The changelog is located at [8].
>> > >> > > >
>> > >> > > > Please download, verify checksums and signatures, run
the unit
>> > tests,
>> > >> > > > and vote on the release. See [9] for how to validate
a release
>> > >> candidate.
>> > >> > > >
>> > >> > > > The vote will be open for at least 72 hours.
>> > >> > > >
>> > >> > > > [ ] +1 Release this as Apache Arrow 0.13.0
>> > >> > > > [ ] +0
>> > >> > > > [ ] -1 Do not release this as Apache Arrow 0.13.0 because...
>> > >> > > >
>> > >> > > > [1]:
>> > >> > > >
>> > >> > >
>> > >>
>> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20fixVersion%20%3D%200.13.0
>> > >> > > > [2]:
>> > >> > > >
>> > >> > >
>> > >>
>> > https://github.com/apache/arrow/tree/dfb9e7af3cd92722893a3819b6676dfdef08f896
>> > >> > > > [3]:
>> > >> > >
>> > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.13.0-rc4
>> > >> > > > [4]: https://bintray.com/apache/arrow/centos-rc/0.13.0-rc4
>> > >> > > > [5]: https://bintray.com/apache/arrow/debian-rc/0.13.0-rc4
>> > >> > > > [6]: https://bintray.com/apache/arrow/python-rc/0.13.0-rc4
>> > >> > > > [7]: https://bintray.com/apache/arrow/ubuntu-rc/0.13.0-rc4
>> > >> > > > [8]:
>> > >> > > >
>> > >> > >
>> > >>
>> > https://github.com/apache/arrow/blob/dfb9e7af3cd92722893a3819b6676dfdef08f896/CHANGELOG.md
>> > >> > > > [9]:
>> > >> > > >
>> > >> > >
>> > >>
>> > https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates
>> > >> > > >
>> > >> > > >
>> > >> > > > Thanks,
>> > >> > > > --
>> > >> > > > kou
>> > >> > > >
>> > >> > >
>> > >>
>> >
Mime
View raw message