Mailing-List: contact dev-help@arrow.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@arrow.apache.org
From: "Katelman, Michael" <Michael.Katelman@CubistSystematic.com>
To: "'dev@arrow.apache.org'" <dev@arrow.apache.org>
Subject: RE: parquet::SetArrayBit
Thread-Topic: parquet::SetArrayBit
Thread-Index: AdLueqnZk2e7LMaSQKCsESz5CxcZHgAAM5oQ
Date: Mon, 26 Jun 2017 12:55:30 +0000
Message-ID: <DB6DA7D4A9C4C44A922E5C2BE8B137DF24E71911@SAC22E10CHM01.saccap.int>
References: <DB6DA7D4A9C4C44A922E5C2BE8B137DF24E71903@SAC22E10CHM01.saccap.int>
In-Reply-To: <DB6DA7D4A9C4C44A922E5C2BE8B137DF24E71903@SAC22E10CHM01.saccap.int>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
archived-at: Mon, 26 Jun 2017 12:55:46 -0000

Sorry, wrong list.

-----Original Message-----
From: Katelman, Michael [mailto:Michael.Katelman@CubistSystematic.com]=20
Sent: Monday, June 26, 2017 8:54
To: 'dev@arrow.apache.org'
Subject: parquet::SetArrayBit

Hi,

Sorry for posting this here and not in Jira (factors outside my control nec=
essitate me posting here). Maybe my interpretation of the semantics of parq=
uet::SetArrayBit is off, but I was surprised to find SetArrayBit(bits, i, f=
alse) does not clear bit i. I just wanted to mention it in case that wasn't=
 the behavior that was intended and is a bug.

from bit-util.h
  static inline void SetArrayBit(uint8_t* bits, int i, bool is_set) {
    bits[i / 8] |=3D (1 << (i % 8)) * is_set;
  }


DISCLAIMER: This e-mail message and any attachments are intended solely for=
 the use of the individual or entity to which it is addressed and may conta=
in information that is confidential or legally privileged. If you are not t=
he intended recipient, you are hereby notified that any dissemination, dist=
ribution, copying or other use of this message or its attachments is strict=
ly prohibited. If you have received this message in error, please notify th=
e sender immediately and permanently delete this message and any attachment=
s.