arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fang Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ARROW-1166) Errors in Struct type's example and missing reference in Layout.md
Date Thu, 29 Jun 2017 16:10:00 GMT
Fang Zheng created ARROW-1166:
---------------------------------

             Summary: Errors in Struct type's example and missing reference in Layout.md
                 Key: ARROW-1166
                 URL: https://issues.apache.org/jira/browse/ARROW-1166
             Project: Apache Arrow
          Issue Type: Bug
          Components: Documentation
    Affects Versions: 0.4.1
            Reporter: Fang Zheng
            Priority: Trivial
             Fix For: 0.5.0


Hi,
There seem to be several minor issues in Layout.md: 

1. In the example for Struct type (https://github.com/apache/arrow/blob/master/format/Layout.md#struct-type),
the second array element is "{null, 2}" in the text, but in the Arrow representation, the
value buffer for field 0 has "bob" in the corresponding slot. Either the text should be changed
from "null" to "bob", or the Null count, Null bitmap buffer, and Offsets buffer should be
changed to count the second element in field 0 as null. 

2. In the same Struct type example, the third element in the Struct array is "null" in text,
but the value buffer for field 1 has 3 in the corresponding slot in the Arrow representation.
The Null count, Null bitmap buffer, and Value buffer should be changed to count the third
element in field 1 as null.

3. In the Dictionary encoding section (https://github.com/apache/arrow/blob/master/format/Layout.md#dictionary-encoding),
there is a missing reference to "Message.fbs". 




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message