arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wes McKinney (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ARROW-782) [C++] Change struct to class for objects that meet the criteria in the Google style guide
Date Fri, 07 Apr 2017 03:27:41 GMT
Wes McKinney created ARROW-782:
----------------------------------

             Summary: [C++] Change struct to class for objects that meet the criteria in the
Google style guide
                 Key: ARROW-782
                 URL: https://issues.apache.org/jira/browse/ARROW-782
             Project: Apache Arrow
          Issue Type: Improvement
          Components: C++
            Reporter: Wes McKinney
             Fix For: 0.3.0


See https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes. I have suspected
that the types in {{type.h}} should be classes, but this suggests it pretty strongly. It would
be better to address this sooner rather than later. 

We should also make the member access functions instead of bare attributes, e.g. {{type->id()}}
instead of {{type->type}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message