arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philipp Moritz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARROW-664) Make C++ Arrow serialization deterministic
Date Mon, 20 Mar 2017 02:41:41 GMT

    [ https://issues.apache.org/jira/browse/ARROW-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932084#comment-15932084
] 

Philipp Moritz commented on ARROW-664:
--------------------------------------

Thanks [~wesmckinn], I created a PR https://github.com/apache/arrow/pull/405

I made zero-initialization the default (it also seems to be the default for the other builders),
let me know if you prefer it to be optional. Is there a reason why it is not already done?

> Make C++ Arrow serialization deterministic
> ------------------------------------------
>
>                 Key: ARROW-664
>                 URL: https://issues.apache.org/jira/browse/ARROW-664
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 0.2.0
>            Reporter: Philipp Moritz
>            Assignee: Philipp Moritz
>            Priority: Minor
>             Fix For: 0.3.0
>
>
> In C++ arrow it can currently occur that uninitialized data created by the builders is
written to IPC memory. The goal of this issue is to identify these cases and set the memory
to zero.
> Note that most of these cases have already been identified by valgrind and fixed in the
past.
> Some of the considerations and benefits are discussed in this github PR:
> https://github.com/apache/arrow/pull/397



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message