arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Deneche A. Hakim (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ARROW-407) BitVector.copyFromSafe() should re-allocate if necessary instead of returning false
Date Tue, 06 Dec 2016 17:06:58 GMT
Deneche A. Hakim created ARROW-407:
--------------------------------------

             Summary: BitVector.copyFromSafe() should re-allocate if necessary instead of
returning false
                 Key: ARROW-407
                 URL: https://issues.apache.org/jira/browse/ARROW-407
             Project: Apache Arrow
          Issue Type: Bug
          Components: Java - Vectors
            Reporter: Deneche A. Hakim
            Assignee: Deneche A. Hakim


Current implementation:
{code}
public boolean copyFromSafe(int inIndex, int outIndex, BitVector from) {
    if (outIndex >= this.getValueCapacity()) {
      decrementAllocationMonitor();
      return false;
    }
    copyFrom(inIndex, outIndex, from);
    return true;
  }
{code}

doesn't match the expectation from "safe" methods. The method should try to re-allocate if
it's running out of space instead of returning false



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message