arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe L. Korn (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (ARROW-338) [C++] Refactor IPC vector "loading" and "unloading" to be based on cleaner visitor pattern
Date Thu, 29 Dec 2016 09:22:58 GMT

     [ https://issues.apache.org/jira/browse/ARROW-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe L. Korn resolved ARROW-338.
-------------------------------
    Resolution: Fixed

Issue resolved by pull request 256
[https://github.com/apache/arrow/pull/256]

> [C++] Refactor IPC vector "loading" and "unloading" to be based on cleaner visitor pattern
> ------------------------------------------------------------------------------------------
>
>                 Key: ARROW-338
>                 URL: https://issues.apache.org/jira/browse/ARROW-338
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>
> The logic for obtaining buffers and metaata from each array is currently somewhat self-contained
in {{arrow/ipc/adapter.cc}} -- this is somewhat inflexible. See the interface used in the
Java implementation: https://github.com/apache/arrow/blob/master/java/vector/src/main/java/org/apache/arrow/vector/FieldVector.java#L52
> This may be better implemented using virtual functions and the visitor pattern, which
may yield better user-extensibility in the future



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message