arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wes McKinney (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ARROW-328) [C++] Return shared_ptr by value instead of const-ref?
Date Sat, 08 Oct 2016 20:00:22 GMT
Wes McKinney created ARROW-328:
----------------------------------

             Summary: [C++] Return shared_ptr by value instead of const-ref?
                 Key: ARROW-328
                 URL: https://issues.apache.org/jira/browse/ARROW-328
             Project: Apache Arrow
          Issue Type: Improvement
          Components: C++
            Reporter: Wes McKinney


This is largely my fault but: many C++ programmers seem to feel that you should always return
{{std::shared_ptr}} by value for a couple reasons:

* RVO in many cases prevents a double ref-count manipulation and,
* If you are planning to share ownership with the other class, you will need to copy the shared_ptr
anyway

On some contemplation I'm +1 on changing all {{const std::shared_ptr<T>&}} to {{std::shared_ptr<T>}},
but let me know if there are other opinions. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message