arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "johnhomes (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARROW-212) [C++] Clarify the fact that PrimitiveArray is now abstract class
Date Thu, 30 Jun 2016 07:12:10 GMT

    [ https://issues.apache.org/jira/browse/ARROW-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356651#comment-15356651
] 

johnhomes commented on ARROW-212:
---------------------------------

In theory it could have a different logical type (I can't think of a great example for boolean
types). I'm also including it here because we still haven't established if we want to be very
pedantic about not doing operations that could fail with bad_alloc (especially in constructors).

Its a slightly bigger change but I can remove the requirement for passing this type and the
the other ones on primitive. I don't have a strong preference here.
Thanks
L.Coffey
My site;
http://www.fixithere.net/sky-customer-service/

> [C++] Clarify the fact that PrimitiveArray is now abstract class 
> -----------------------------------------------------------------
>
>                 Key: ARROW-212
>                 URL: https://issues.apache.org/jira/browse/ARROW-212
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Micah Kornfield
>            Assignee: Micah Kornfield
>            Priority: Minor
>
> Follow up from ARROW-206 based on [~xhochy] feedback.
> Make the constructor protected and point to the approriate method in construct.h



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message