arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philipp Moritz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARROW-100) [C++] Computing RowBatch size
Date Wed, 13 Apr 2016 06:18:25 GMT

    [ https://issues.apache.org/jira/browse/ARROW-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238688#comment-15238688
] 

Philipp Moritz commented on ARROW-100:
--------------------------------------

Just added the test and fixed a bug that the test discovered (I need to compute the actual
offset, passing in 0 is not enough); I also addressed your comments (didn't change the 1<<16
because I don't want the test to depend on code that is supposed to be tested). Thanks a lot
for your help!

The issues clang-tidy found are largely unrelated to what I have been doing, but there is
one the was introduced by the code I wrote that I don't really understand:

https://gist.github.com/pcmoritz/0ec7421c60140eb47fccd770c2cd280d

Any chance you can look at it and help me figure out what is going on?

> [C++] Computing RowBatch size
> -----------------------------
>
>                 Key: ARROW-100
>                 URL: https://issues.apache.org/jira/browse/ARROW-100
>             Project: Apache Arrow
>          Issue Type: New Feature
>          Components: C++
>            Reporter: Philipp Moritz
>
> Hi,
> thank you guys for this project, I'm really enjoying what I've seen so far!
> There is an unimplemented method for getting the total size of objects:
> int64_t GetRowBatchSize(const RowBatch* batch);
> Has somebody already started to implement it or thought about how to do it?
> It could be done by recursively adding up all the involved buffer sizes, build the metadata
and add its size. Let me know if you want me to create a draft of the implementation.
> -- Philipp.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message