arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARROW-85) C++: memcmp can be avoided in Equal when comparing with the same Buffer
Date Mon, 04 Apr 2016 00:47:25 GMT

    [ https://issues.apache.org/jira/browse/ARROW-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223572#comment-15223572
] 

Kai Zheng commented on ARROW-85:
--------------------------------

https://github.com/apache/arrow/pull/57

> C++: memcmp can be avoided in Equal when comparing with the same Buffer
> -----------------------------------------------------------------------
>
>                 Key: ARROW-85
>                 URL: https://issues.apache.org/jira/browse/ARROW-85
>             Project: Apache Arrow
>          Issue Type: Improvement
>            Reporter: Kai Zheng
>
> It looks too expensive to use memcmp to compare two buffers. Instead, the starting address
and length/capacity would be good enough to use. Higher level codes relying on memcmp behaviour
can be done in higher level.
> Update: memcmp should be avoided in Equal when comparing with the same Buffer. In other
cases, it's still needed to know the content are the same or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message