arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Todd Lipcon <t...@cloudera.com>
Subject Re: Code review tools for Arrow patches
Date Mon, 25 Apr 2016 19:03:15 GMT
Using gerrit as an "optional" tool is a bit difficult, because it doesn't
know how to handle commits to a repository that it doesn't own.

The way we get around the "commit via gerrit" issue in the Kudu podling is
to follow the example of AsterixDB. Commits are made using gerrit, but that
doesn't automatically flow to the ASF repo. The committer then runs a
'push-to-asf.py' script which grabs the commit from gerrit and pushes to
the ASF repository:
https://github.com/apache/incubator-kudu/blob/master/build-support/push_to_asf.py

I'm happy to set up the gerrit projects, but not sure how it would work in
an "optional" context.

-Todd


On Sun, Apr 24, 2016 at 4:53 PM, Julian Hyde <jhyde.apache@gmail.com> wrote:

> IIRC Apex wanted to commit via Gerrit. That was a non-starter. Commits
> have to be made by a committer.
>
> Julian
>
>
> > On Apr 24, 2016, at 3:07 PM, Wes McKinney <wes@cloudera.com> wrote:
> >
> > Sending all Gerrit review activity to the mailing list seems adequate to
> me.
> > I don't see how this is especially different from reviewing code on a
> > website owned by GitHub. I remain hopeful that ASF Infra will set up an
> > ASF-managed Gerrit.
> >
> > On Sunday, April 24, 2016, Ted Dunning <ted.dunning@gmail.com> wrote:
> >
> >> Just for the record, Apex had some issues getting Gerrit reviews
> reflected
> >> in a coherent fashion into the Apache record. I presume that you guys
> will
> >> have that handled or will check with the Apex devs to learn their
> >> resolution.
> >>
> >>
> >>
>
>


-- 
Todd Lipcon
Software Engineer, Cloudera

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message