arrow-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ARROW-85) C++: memcmp is too expensive for Buffer's Equal
Date Tue, 29 Mar 2016 00:22:25 GMT

    [ https://issues.apache.org/jira/browse/ARROW-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215142#comment-15215142
] 

Kai Zheng commented on ARROW-85:
--------------------------------

Yes I understood. I thought at least we need to be careful about calling the method directly
or indirectly given a large dataset to comare against another. Would leave this for further
investigation and consideration, right now we don't have much benchmark tests to verify this.

> C++: memcmp is too expensive for Buffer's Equal
> -----------------------------------------------
>
>                 Key: ARROW-85
>                 URL: https://issues.apache.org/jira/browse/ARROW-85
>             Project: Apache Arrow
>          Issue Type: Improvement
>            Reporter: Kai Zheng
>
> It looks too expensive to use memcmp to compare two buffers. Instead, the starting address
and length/capacity would be good enough to use. Higher level codes relying on memcmp behaviour
can be done in higher level.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message