arrow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From w...@apache.org
Subject [arrow] branch master updated: ARROW-1771: [C++] ARROW-1749 Breaks Public API test in parquet-cpp
Date Tue, 07 Nov 2017 03:24:23 GMT
This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 99ea353  ARROW-1771: [C++] ARROW-1749 Breaks Public API test in parquet-cpp
99ea353 is described below

commit 99ea353dbaf15b8db1ad7d8d4419643abe99189d
Author: Phillip Cloud <cpcloud@gmail.com>
AuthorDate: Mon Nov 6 22:24:19 2017 -0500

    ARROW-1771: [C++] ARROW-1749 Breaks Public API test in parquet-cpp
    
    Author: Phillip Cloud <cpcloud@gmail.com>
    
    Closes #1288 from cpcloud/ARROW-1771 and squashes the following commits:
    
    dc002568 [Phillip Cloud] Formatting again
    ac2367b4 [Phillip Cloud] Fix formatting
    35e67e50 [Phillip Cloud] Add public API test
    659e5165 [Phillip Cloud] Fix formatting
    de4632ac [Phillip Cloud] ARROW-1771: [C++] ARROW-1749 Breaks Public API test in parquet-cpp
---
 cpp/src/arrow/CMakeLists.txt     |  1 +
 cpp/src/arrow/public-api-test.cc | 26 ++++++++++++++++++++++++++
 cpp/src/arrow/util/bit-util.h    |  3 +--
 3 files changed, 28 insertions(+), 2 deletions(-)

diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
index 22b4751..69d5052 100644
--- a/cpp/src/arrow/CMakeLists.txt
+++ b/cpp/src/arrow/CMakeLists.txt
@@ -171,6 +171,7 @@ ADD_ARROW_TEST(array-test)
 ADD_ARROW_TEST(buffer-test)
 ADD_ARROW_TEST(memory_pool-test)
 ADD_ARROW_TEST(pretty_print-test)
+ADD_ARROW_TEST(public-api-test)
 ADD_ARROW_TEST(status-test)
 ADD_ARROW_TEST(type-test)
 ADD_ARROW_TEST(table-test)
diff --git a/cpp/src/arrow/public-api-test.cc b/cpp/src/arrow/public-api-test.cc
new file mode 100644
index 0000000..8298d74
--- /dev/null
+++ b/cpp/src/arrow/public-api-test.cc
@@ -0,0 +1,26 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "arrow/api.h"
+
+#ifdef DCHECK
+#error "DCHECK should not be visible from Arrow public headers."
+#endif
+
+#include <gtest/gtest.h>
+
+TEST(_, _) {}
diff --git a/cpp/src/arrow/util/bit-util.h b/cpp/src/arrow/util/bit-util.h
index d6415f3..cab3c9e 100644
--- a/cpp/src/arrow/util/bit-util.h
+++ b/cpp/src/arrow/util/bit-util.h
@@ -57,7 +57,6 @@
 #include <memory>
 #include <vector>
 
-#include "arrow/util/logging.h"
 #include "arrow/util/macros.h"
 #include "arrow/util/type_traits.h"
 #include "arrow/util/visibility.h"
@@ -301,7 +300,7 @@ static inline int Log2(uint64_t x) {
 
 /// \brief Count the number of leading zeros in a 32 bit integer.
 static inline int64_t CountLeadingZeros(uint32_t value) {
-  DCHECK_NE(value, 0);
+// DCHECK_NE(value, 0);
 #if defined(__clang__) || defined(__GNUC__)
   return static_cast<int64_t>(__builtin_clz(value));
 #elif defined(_MSC_VER)

-- 
To stop receiving notification emails like this one, please contact
['"commits@arrow.apache.org" <commits@arrow.apache.org>'].

Mime
View raw message