arrow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From w...@apache.org
Subject arrow git commit: ARROW-1419: [GLib] Suppress sign-conversion warnings
Date Mon, 28 Aug 2017 13:32:29 GMT
Repository: arrow
Updated Branches:
  refs/heads/master 26d4e3f59 -> 6cd2a1716


ARROW-1419: [GLib] Suppress sign-conversion warnings

Apache Arrow C++ uses int as result type for expression that uses
size_t. It causes sign-conversion warning but the coding style is
expected.

Example:

    .../arrow/buffer.h:296:41: warning:
          implicit conversion changes signedness: 'unsigned long' to 'int64_t'
          (aka 'long') [-Wsign-conversion]
      int64_t length() const { return size_ / sizeof(T); }
                               ~~~~~~ ~~~~~~^~~~~~~~~~~

Author: Kouhei Sutou <kou@clear-code.com>

Closes #999 from kou/glib-suppress-warning-on-clang and squashes the following commits:

397490e9 [Kouhei Sutou] [GLib] Suppress sign-conversion warnings


Project: http://git-wip-us.apache.org/repos/asf/arrow/repo
Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/6cd2a171
Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/6cd2a171
Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/6cd2a171

Branch: refs/heads/master
Commit: 6cd2a17160411537a26997271f83321dae32845c
Parents: 26d4e3f
Author: Kouhei Sutou <kou@clear-code.com>
Authored: Mon Aug 28 09:32:25 2017 -0400
Committer: Wes McKinney <wes.mckinney@twosigma.com>
Committed: Mon Aug 28 09:32:25 2017 -0400

----------------------------------------------------------------------
 c_glib/configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/arrow/blob/6cd2a171/c_glib/configure.ac
----------------------------------------------------------------------
diff --git a/c_glib/configure.ac b/c_glib/configure.ac
index 375f76e..103f11b 100644
--- a/c_glib/configure.ac
+++ b/c_glib/configure.ac
@@ -36,8 +36,8 @@ AC_PROG_CXX
 AX_CXX_COMPILE_STDCXX_11([ext], [mandatory])
 LT_INIT
 
-GARROW_CFLAGS="-Wall -Wconversion"
-GARROW_CXXFLAGS="-Wall -Wconversion"
+GARROW_CFLAGS="-Wall"
+GARROW_CXXFLAGS="-Wall"
 AC_ARG_ENABLE(debug,
   [AS_HELP_STRING([--enable-debug],
                   [Use debug flags (default=no)])],


Mime
View raw message