arrow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacq...@apache.org
Subject arrow git commit: ARROW-1239: [JAVA] upgrading git-commit-id-plugin
Date Mon, 24 Jul 2017 15:23:21 GMT
Repository: arrow
Updated Branches:
  refs/heads/master 457bb071d -> 05f7058ce


ARROW-1239: [JAVA] upgrading git-commit-id-plugin

Currently used version of the git-commit-id-plugin maven plugin (2.1.9) doesn't work with
recent git structures. This is for majority of the users not manifested since Arrow has the
java maven root in the project subdirectory  (`/java`) instead of top level so this plugin
normally doesn't kick in if maven is executed from the subdirectory (usual case - ie `cd java;
mvn install` - works fine) as the plugin doesn't see the `.git` directory but it does kick
in and fail if executed from the main arrow top level dir as `mvn -f java/pom.xml install`
(where the `.git` sits):

```
$ mvn -f java/pom.xml package
...
[ERROR] Failed to execute goal pl.project13.maven:git-commit-id-plugin:2.1.9:revision (for-jars)
on project arrow-java-root: Execution for-jars of goal pl.project13.maven:git-commit-id-plugin:2.1.9:revision
failed: Bare Repository has neither a working tree, nor an index -> [Help 1]
```

Simple fix is upgrading the plugin to recent version (the minimal working version appears
to be 2.1.13).

This is required for seamless integration with Jenkins (ARROW-1234).

Author: Antony Mayi <antonymayi@yahoo.com>

Closes #869 from antonymayi/master and squashes the following commits:

6976ee0 [Antony Mayi] ARROW-1239 - upgrading git-commit-id-plugin


Project: http://git-wip-us.apache.org/repos/asf/arrow/repo
Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/05f7058c
Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/05f7058c
Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/05f7058c

Branch: refs/heads/master
Commit: 05f7058ce500278d52118c0f0e8320e93a18cf53
Parents: 457bb07
Author: Antony Mayi <antonymayi@yahoo.com>
Authored: Mon Jul 24 08:22:38 2017 -0700
Committer: Jacques Nadeau <jacques@dremio.com>
Committed: Mon Jul 24 08:22:38 2017 -0700

----------------------------------------------------------------------
 java/pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/arrow/blob/05f7058c/java/pom.xml
----------------------------------------------------------------------
diff --git a/java/pom.xml b/java/pom.xml
index 0d4e612..81f80b0 100644
--- a/java/pom.xml
+++ b/java/pom.xml
@@ -231,7 +231,7 @@
       <plugin>
         <groupId>pl.project13.maven</groupId>
         <artifactId>git-commit-id-plugin</artifactId>
-        <version>2.1.9</version>
+        <version>2.2.2</version>
         <executions>
           <execution>
             <id>for-jars</id>


Mime
View raw message