Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CE609200CB4 for ; Tue, 27 Jun 2017 10:48:54 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CB528160BE9; Tue, 27 Jun 2017 08:48:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1D763160BDC for ; Tue, 27 Jun 2017 10:48:53 +0200 (CEST) Received: (qmail 57444 invoked by uid 500); 27 Jun 2017 08:48:53 -0000 Mailing-List: contact commits-help@arrow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@arrow.apache.org Delivered-To: mailing list commits@arrow.apache.org Received: (qmail 57434 invoked by uid 99); 27 Jun 2017 08:48:53 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jun 2017 08:48:53 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 35F47DFE1F; Tue, 27 Jun 2017 08:48:53 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: uwe@apache.org To: commits@arrow.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: arrow git commit: ARROW-1157: C++/Python: Decimal templates are not correctly exported on OSX Date: Tue, 27 Jun 2017 08:48:53 +0000 (UTC) archived-at: Tue, 27 Jun 2017 08:48:55 -0000 Repository: arrow Updated Branches: refs/heads/master 3e754a0d0 -> cb5f2b953 ARROW-1157: C++/Python: Decimal templates are not correctly exported on OSX Author: Uwe L. Korn Closes #787 from xhochy/ARROW-1157 and squashes the following commits: 1eec942 [Uwe L. Korn] ARROW-1157: C++/Python: Decimal templates are not correctly exported on OSX Project: http://git-wip-us.apache.org/repos/asf/arrow/repo Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/cb5f2b95 Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/cb5f2b95 Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/cb5f2b95 Branch: refs/heads/master Commit: cb5f2b9538e2ca11f65bdbe96451e34259899e26 Parents: 3e754a0 Author: Uwe L. Korn Authored: Tue Jun 27 10:48:37 2017 +0200 Committer: Uwe L. Korn Committed: Tue Jun 27 10:48:37 2017 +0200 ---------------------------------------------------------------------- ci/travis_script_python.sh | 2 +- cpp/src/arrow/util/visibility.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/arrow/blob/cb5f2b95/ci/travis_script_python.sh ---------------------------------------------------------------------- diff --git a/ci/travis_script_python.sh b/ci/travis_script_python.sh index 8585527..ac64c54 100755 --- a/ci/travis_script_python.sh +++ b/ci/travis_script_python.sh @@ -52,7 +52,7 @@ build_parquet_cpp() { -DPARQUET_BUILD_BENCHMARKS=off \ -DPARQUET_BUILD_EXECUTABLES=off \ -DPARQUET_ZLIB_VENDORED=off \ - -DPARQUET_BUILD_TESTS=off \ + -DPARQUET_BUILD_TESTS=on \ .. make -j${CPU_COUNT} http://git-wip-us.apache.org/repos/asf/arrow/blob/cb5f2b95/cpp/src/arrow/util/visibility.h ---------------------------------------------------------------------- diff --git a/cpp/src/arrow/util/visibility.h b/cpp/src/arrow/util/visibility.h index e84cc45..0018ce0 100644 --- a/cpp/src/arrow/util/visibility.h +++ b/cpp/src/arrow/util/visibility.h @@ -46,7 +46,7 @@ // This is a complicated topic, some reading on it: // http://www.codesynthesis.com/~boris/blog/2010/01/18/dll-export-cxx-templates/ -#if defined(_MSC_VER) +#if defined(_MSC_VER) || defined(__clang__) #define ARROW_TEMPLATE_EXPORT ARROW_EXPORT #else #define ARROW_TEMPLATE_EXPORT