arrow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From u..@apache.org
Subject arrow git commit: ARROW-1157: C++/Python: Decimal templates are not correctly exported on OSX
Date Tue, 27 Jun 2017 08:48:53 GMT
Repository: arrow
Updated Branches:
  refs/heads/master 3e754a0d0 -> cb5f2b953


ARROW-1157: C++/Python: Decimal templates are not correctly exported on OSX

Author: Uwe L. Korn <uwelk@xhochy.com>

Closes #787 from xhochy/ARROW-1157 and squashes the following commits:

1eec942 [Uwe L. Korn] ARROW-1157: C++/Python: Decimal templates are not correctly exported
on OSX


Project: http://git-wip-us.apache.org/repos/asf/arrow/repo
Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/cb5f2b95
Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/cb5f2b95
Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/cb5f2b95

Branch: refs/heads/master
Commit: cb5f2b9538e2ca11f65bdbe96451e34259899e26
Parents: 3e754a0
Author: Uwe L. Korn <uwelk@xhochy.com>
Authored: Tue Jun 27 10:48:37 2017 +0200
Committer: Uwe L. Korn <uwelk@xhochy.com>
Committed: Tue Jun 27 10:48:37 2017 +0200

----------------------------------------------------------------------
 ci/travis_script_python.sh      | 2 +-
 cpp/src/arrow/util/visibility.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/arrow/blob/cb5f2b95/ci/travis_script_python.sh
----------------------------------------------------------------------
diff --git a/ci/travis_script_python.sh b/ci/travis_script_python.sh
index 8585527..ac64c54 100755
--- a/ci/travis_script_python.sh
+++ b/ci/travis_script_python.sh
@@ -52,7 +52,7 @@ build_parquet_cpp() {
       -DPARQUET_BUILD_BENCHMARKS=off \
       -DPARQUET_BUILD_EXECUTABLES=off \
       -DPARQUET_ZLIB_VENDORED=off \
-      -DPARQUET_BUILD_TESTS=off \
+      -DPARQUET_BUILD_TESTS=on \
       ..
 
   make -j${CPU_COUNT}

http://git-wip-us.apache.org/repos/asf/arrow/blob/cb5f2b95/cpp/src/arrow/util/visibility.h
----------------------------------------------------------------------
diff --git a/cpp/src/arrow/util/visibility.h b/cpp/src/arrow/util/visibility.h
index e84cc45..0018ce0 100644
--- a/cpp/src/arrow/util/visibility.h
+++ b/cpp/src/arrow/util/visibility.h
@@ -46,7 +46,7 @@
 
 // This is a complicated topic, some reading on it:
 // http://www.codesynthesis.com/~boris/blog/2010/01/18/dll-export-cxx-templates/
-#if defined(_MSC_VER)
+#if defined(_MSC_VER) || defined(__clang__)
 #define ARROW_TEMPLATE_EXPORT ARROW_EXPORT
 #else
 #define ARROW_TEMPLATE_EXPORT


Mime
View raw message