arrow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From w...@apache.org
Subject arrow git commit: ARROW-856: Also read compiler info from stdout
Date Sat, 06 May 2017 21:54:37 GMT
Repository: arrow
Updated Branches:
  refs/heads/master 75ebf5ca8 -> 959ec47b3


ARROW-856: Also read compiler info from stdout

As I cannot reproduce the problem, this may not the be the correct solution. Still due to
the output of `gcc -v` in the ticket, it is very likely that some systems print the info on
stdout. Also the additional message should improve debugging.

Author: Uwe L. Korn <uwelk@xhochy.com>

Closes #650 from xhochy/ARROW-856 and squashes the following commits:

d87c7bd [Uwe L. Korn] ARROW-856: Also read compiler info from stdout


Project: http://git-wip-us.apache.org/repos/asf/arrow/repo
Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/959ec47b
Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/959ec47b
Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/959ec47b

Branch: refs/heads/master
Commit: 959ec47b3e2828a44088d054bbdc5eabac9113e5
Parents: 75ebf5c
Author: Uwe L. Korn <uwelk@xhochy.com>
Authored: Sat May 6 17:54:31 2017 -0400
Committer: Wes McKinney <wes.mckinney@twosigma.com>
Committed: Sat May 6 17:54:31 2017 -0400

----------------------------------------------------------------------
 cpp/cmake_modules/CompilerInfo.cmake | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/arrow/blob/959ec47b/cpp/cmake_modules/CompilerInfo.cmake
----------------------------------------------------------------------
diff --git a/cpp/cmake_modules/CompilerInfo.cmake b/cpp/cmake_modules/CompilerInfo.cmake
index 21e2daf..4a18376 100644
--- a/cpp/cmake_modules/CompilerInfo.cmake
+++ b/cpp/cmake_modules/CompilerInfo.cmake
@@ -21,7 +21,11 @@ if (NOT MSVC)
   set(COMPILER_GET_VERSION_SWITCH "-v")
 endif()
 
+message(INFO "Compiler command: ${CMAKE_CXX_COMPILER}")
+# Some gcc seem to output their version on stdout, most do it on stderr, simply
+# merge both pipes into a single variable
 execute_process(COMMAND "${CMAKE_CXX_COMPILER}" ${COMPILER_GET_VERSION_SWITCH}
+                OUTPUT_VARIABLE COMPILER_VERSION_FULL
                 ERROR_VARIABLE COMPILER_VERSION_FULL)
 message(INFO "Compiler version: ${COMPILER_VERSION_FULL}")
 message(INFO "Compiler id: ${CMAKE_CXX_COMPILER_ID}")


Mime
View raw message