arrow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From w...@apache.org
Subject arrow git commit: ARROW-745: [C++] Allow use of system cpplint
Date Sat, 01 Apr 2017 17:18:49 GMT
Repository: arrow
Updated Branches:
  refs/heads/master 31a1f53f4 -> 651ea9247


ARROW-745: [C++] Allow use of system cpplint

You can do `pip install cpplint` to take advantage of this.

Author: Phillip Cloud <cpcloud@gmail.com>

Closes #476 from cpcloud/ARROW-745 and squashes the following commits:

e43d20c [Phillip Cloud] ARROW-745: [C++] Allow use of system cpplint


Project: http://git-wip-us.apache.org/repos/asf/arrow/repo
Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/651ea924
Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/651ea924
Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/651ea924

Branch: refs/heads/master
Commit: 651ea9247c42b889da457432d4ff13b558e8bec1
Parents: 31a1f53
Author: Phillip Cloud <cpcloud@gmail.com>
Authored: Sat Apr 1 13:18:40 2017 -0400
Committer: Wes McKinney <wes.mckinney@twosigma.com>
Committed: Sat Apr 1 13:18:40 2017 -0400

----------------------------------------------------------------------
 cpp/CMakeLists.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/arrow/blob/651ea924/cpp/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index 5dcf58c..7a5a0e6 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -741,8 +741,11 @@ if (UNIX)
     ENDIF()
   ENDFOREACH(item ${LINT_FILES})
 
+  find_program(CPPLINT_BIN NAMES cpplint cpplint.py HINTS ${BUILD_SUPPORT_DIR})
+  message(STATUS "Found cpplint executable at ${CPPLINT_BIN}")
+
   # Full lint
-  add_custom_target(lint ${BUILD_SUPPORT_DIR}/cpplint.py
+  add_custom_target(lint ${CPPLINT_BIN}
   --verbose=2
   --linelength=90
   --filter=-whitespace/comments,-readability/todo,-build/header_guard,-build/c++11,-runtime/references,-build/include_order


Mime
View raw message