Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B5BB8200C35 for ; Sun, 12 Mar 2017 18:50:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B43AF160B77; Sun, 12 Mar 2017 17:50:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 07F4A160B69 for ; Sun, 12 Mar 2017 18:50:02 +0100 (CET) Received: (qmail 37556 invoked by uid 500); 12 Mar 2017 17:50:02 -0000 Mailing-List: contact commits-help@arrow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@arrow.apache.org Delivered-To: mailing list commits@arrow.apache.org Received: (qmail 37547 invoked by uid 99); 12 Mar 2017 17:50:02 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Mar 2017 17:50:02 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 11770DFE1E; Sun, 12 Mar 2017 17:50:02 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: wesm@apache.org To: commits@arrow.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: arrow git commit: ARROW-612: [Java] Added not null to Field.toString output Date: Sun, 12 Mar 2017 17:50:02 +0000 (UTC) archived-at: Sun, 12 Mar 2017 17:50:03 -0000 Repository: arrow Updated Branches: refs/heads/master 344ad1f10 -> d4ecb5e54 ARROW-612: [Java] Added not null to Field.toString output Changed `Field.toString` method to include an additional `not null` description only if the nullable flag is not set. Changed test to update expected string output. Author: Bryan Cutler Closes #368 from BryanCutler/Field-toString-show-nullable-ARROW-612 and squashes the following commits: 9dc633d [Bryan Cutler] added not null to Field.toString output Project: http://git-wip-us.apache.org/repos/asf/arrow/repo Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/d4ecb5e5 Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/d4ecb5e5 Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/d4ecb5e5 Branch: refs/heads/master Commit: d4ecb5e54eb7bc9392ad2f4e1cf9a0fe42be8cd0 Parents: 344ad1f Author: Bryan Cutler Authored: Sun Mar 12 13:49:53 2017 -0400 Committer: Wes McKinney Committed: Sun Mar 12 13:49:53 2017 -0400 ---------------------------------------------------------------------- .../src/main/java/org/apache/arrow/vector/types/pojo/Field.java | 3 +++ .../test/java/org/apache/arrow/vector/types/pojo/TestSchema.java | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/arrow/blob/d4ecb5e5/java/vector/src/main/java/org/apache/arrow/vector/types/pojo/Field.java ---------------------------------------------------------------------- diff --git a/java/vector/src/main/java/org/apache/arrow/vector/types/pojo/Field.java b/java/vector/src/main/java/org/apache/arrow/vector/types/pojo/Field.java index 2d528e4..f9b79ce 100644 --- a/java/vector/src/main/java/org/apache/arrow/vector/types/pojo/Field.java +++ b/java/vector/src/main/java/org/apache/arrow/vector/types/pojo/Field.java @@ -185,6 +185,9 @@ public class Field { if (!children.isEmpty()) { sb.append("<").append(Joiner.on(", ").join(children)).append(">"); } + if (!nullable) { + sb.append(" not null"); + } return sb.toString(); } } http://git-wip-us.apache.org/repos/asf/arrow/blob/d4ecb5e5/java/vector/src/test/java/org/apache/arrow/vector/types/pojo/TestSchema.java ---------------------------------------------------------------------- diff --git a/java/vector/src/test/java/org/apache/arrow/vector/types/pojo/TestSchema.java b/java/vector/src/test/java/org/apache/arrow/vector/types/pojo/TestSchema.java index d60d17e..f04c78e 100644 --- a/java/vector/src/test/java/org/apache/arrow/vector/types/pojo/TestSchema.java +++ b/java/vector/src/test/java/org/apache/arrow/vector/types/pojo/TestSchema.java @@ -53,7 +53,7 @@ public class TestSchema { )); roundTrip(schema); assertEquals( - "Schema, e: List, f: FloatingPoint(SINGLE), g: Timestamp(MILLISECOND), h: Interval(DAY_TIME)>", + "Schema, e: List, f: FloatingPoint(SINGLE), g: Timestamp(MILLISECOND), h: Interval(DAY_TIME)>", schema.toString()); }