arrow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From w...@apache.org
Subject arrow git commit: ARROW-651: [C++] Set version to shared library
Date Sat, 18 Mar 2017 20:52:51 GMT
Repository: arrow
Updated Branches:
  refs/heads/master 98c949018 -> a9f0c63ad


ARROW-651: [C++] Set version to shared library

.deb package builder assumes that shared libraries have version.
See also: https://www.debian.org/doc/debian-policy/ch-sharedlibs.html

Author: Kouhei Sutou <kou@clear-code.com>

Closes #401 from kou/debian-set-version-to-shared-library and squashes the following commits:

2da1442 [Kouhei Sutou] [C++] Set version to shared library


Project: http://git-wip-us.apache.org/repos/asf/arrow/repo
Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/a9f0c63a
Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/a9f0c63a
Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/a9f0c63a

Branch: refs/heads/master
Commit: a9f0c63ad9b8942f3287da2b7109d486d92731b0
Parents: 98c9490
Author: Kouhei Sutou <kou@clear-code.com>
Authored: Sat Mar 18 16:52:45 2017 -0400
Committer: Wes McKinney <wes.mckinney@twosigma.com>
Committed: Sat Mar 18 16:52:45 2017 -0400

----------------------------------------------------------------------
 cpp/CMakeLists.txt                 | 3 +++
 cpp/cmake_modules/BuildUtils.cmake | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/arrow/blob/a9f0c63a/cpp/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index 197aa9c..956658a 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -30,6 +30,9 @@ include(CMakeParseArguments)
 include(ExternalProject)
 include(GNUInstallDirs)
 
+set(ARROW_SO_VERSION "0")
+set(ARROW_ABI_VERSION "${ARROW_SO_VERSION}.0.0")
+
 set(BUILD_SUPPORT_DIR "${CMAKE_SOURCE_DIR}/build-support")
 set(THIRDPARTY_DIR "${CMAKE_SOURCE_DIR}/thirdparty")
 

http://git-wip-us.apache.org/repos/asf/arrow/blob/a9f0c63a/cpp/cmake_modules/BuildUtils.cmake
----------------------------------------------------------------------
diff --git a/cpp/cmake_modules/BuildUtils.cmake b/cpp/cmake_modules/BuildUtils.cmake
index 9e14838..78b514c 100644
--- a/cpp/cmake_modules/BuildUtils.cmake
+++ b/cpp/cmake_modules/BuildUtils.cmake
@@ -52,7 +52,9 @@ function(ADD_ARROW_LIB LIB_NAME)
       PROPERTIES
       LIBRARY_OUTPUT_DIRECTORY "${BUILD_OUTPUT_ROOT_DIRECTORY}"
       LINK_FLAGS "${ARG_SHARED_LINK_FLAGS}"
-      OUTPUT_NAME ${LIB_NAME})
+      OUTPUT_NAME ${LIB_NAME}
+      VERSION "${ARROW_ABI_VERSION}"
+      SOVERSION "${ARROW_SO_VERSION}")
     target_link_libraries(${LIB_NAME}_shared
       LINK_PUBLIC ${ARG_SHARED_LINK_LIBS}
       LINK_PRIVATE ${ARG_SHARED_PRIVATE_LINK_LIBS})


Mime
View raw message