arrow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From w...@apache.org
Subject arrow git commit: ARROW-505: [C++] Fix compiler warning in gcc in release mode
Date Sun, 22 Jan 2017 16:14:08 GMT
Repository: arrow
Updated Branches:
  refs/heads/master 5888e10cf -> 5a161ebc1


ARROW-505: [C++] Fix compiler warning in gcc in release mode

Author: Wes McKinney <wes.mckinney@twosigma.com>

Closes #294 from wesm/fix-release-compile-warning and squashes the following commits:

4189892 [Wes McKinney] Suppress another Cython compiler warning when compiling with clang
9a8ad54 [Wes McKinney] Fix compiler warning in gcc in release mode


Project: http://git-wip-us.apache.org/repos/asf/arrow/repo
Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/5a161ebc
Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/5a161ebc
Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/5a161ebc

Branch: refs/heads/master
Commit: 5a161ebc1961b4f784d51322b12fe09e8c8aa08d
Parents: 5888e10
Author: Wes McKinney <wes.mckinney@twosigma.com>
Authored: Sun Jan 22 11:13:59 2017 -0500
Committer: Wes McKinney <wes.mckinney@twosigma.com>
Committed: Sun Jan 22 11:13:59 2017 -0500

----------------------------------------------------------------------
 cpp/src/arrow/ipc/adapter.cc | 4 ++--
 python/CMakeLists.txt        | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/arrow/blob/5a161ebc/cpp/src/arrow/ipc/adapter.cc
----------------------------------------------------------------------
diff --git a/cpp/src/arrow/ipc/adapter.cc b/cpp/src/arrow/ipc/adapter.cc
index 9da7b39..c8e631c 100644
--- a/cpp/src/arrow/ipc/adapter.cc
+++ b/cpp/src/arrow/ipc/adapter.cc
@@ -197,8 +197,8 @@ class RecordBatchWriter : public ArrayVisitor {
 
   Status GetTotalSize(int64_t* size) {
     // emulates the behavior of Write without actually writing
-    int32_t metadata_length;
-    int64_t body_length;
+    int32_t metadata_length = 0;
+    int64_t body_length = 0;
     MockOutputStream dst;
     RETURN_NOT_OK(Write(&dst, &metadata_length, &body_length));
     *size = dst.GetExtentBytesWritten();

http://git-wip-us.apache.org/repos/asf/arrow/blob/5a161ebc/python/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
index 0a2d4e9..b3735b1 100644
--- a/python/CMakeLists.txt
+++ b/python/CMakeLists.txt
@@ -87,6 +87,9 @@ if ("${COMPILER_FAMILY}" STREQUAL "clang")
   #   http://petereisentraut.blogspot.com/2011/05/ccache-and-clang.html
   #   http://petereisentraut.blogspot.com/2011/09/ccache-and-clang-part-2.html
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Qunused-arguments")
+
+  # Cython warnings in clang
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-parentheses-equality")
 endif()
 
 set(PYARROW_LINK "a")


Mime
View raw message