arrow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From w...@apache.org
Subject arrow git commit: ARROW-445: arrow_ipc_objlib depends on Flatbuffer generated files
Date Thu, 29 Dec 2016 01:21:56 GMT
Repository: arrow
Updated Branches:
  refs/heads/master 3095f2cb7 -> 4733ee876


ARROW-445: arrow_ipc_objlib depends on Flatbuffer generated files

This is needed as before the depedency was done through the arrow
library on which arrow_ipc depends. But as the arrow_objlib target is
not linked to anything else, it can actually be built independently.
This would lead to races where the flatbuffer generated files were not
existing during arrow_ipc compilation.

Author: Uwe L. Korn <uwelk@xhochy.com>

Closes #258 from xhochy/ARROW-445 and squashes the following commits:

8bdad8e [Uwe L. Korn] ARROW-445: arrow_ipc_objlib depends on Flatbuffer generated files


Project: http://git-wip-us.apache.org/repos/asf/arrow/repo
Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/4733ee87
Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/4733ee87
Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/4733ee87

Branch: refs/heads/master
Commit: 4733ee876e1fddb8032fce1dc9e486d68904fbea
Parents: 3095f2c
Author: Uwe L. Korn <uwelk@xhochy.com>
Authored: Wed Dec 28 20:21:48 2016 -0500
Committer: Wes McKinney <wes.mckinney@twosigma.com>
Committed: Wed Dec 28 20:21:48 2016 -0500

----------------------------------------------------------------------
 cpp/src/arrow/ipc/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/arrow/blob/4733ee87/cpp/src/arrow/ipc/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/cpp/src/arrow/ipc/CMakeLists.txt b/cpp/src/arrow/ipc/CMakeLists.txt
index 11ca191..b7ac5f0 100644
--- a/cpp/src/arrow/ipc/CMakeLists.txt
+++ b/cpp/src/arrow/ipc/CMakeLists.txt
@@ -143,7 +143,7 @@ add_custom_command(
 )
 
 add_custom_target(metadata_fbs DEPENDS ${FBS_OUTPUT_FILES})
-add_dependencies(arrow_objlib metadata_fbs)
+add_dependencies(arrow_ipc_objlib metadata_fbs)
 
 # Headers: top level
 install(FILES


Mime
View raw message