arrow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From w...@apache.org
Subject arrow git commit: ARROW-437: [C++} Fix clang compiler warning
Date Tue, 27 Dec 2016 23:04:51 GMT
Repository: arrow
Updated Branches:
  refs/heads/master 65af9ea16 -> 1079a3206


ARROW-437: [C++} Fix clang compiler warning

Author: Wes McKinney <wes.mckinney@twosigma.com>

Closes #254 from wesm/ARROW-437 and squashes the following commits:

a18a651 [Wes McKinney] Fix compiler warning in clang


Project: http://git-wip-us.apache.org/repos/asf/arrow/repo
Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/1079a320
Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/1079a320
Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/1079a320

Branch: refs/heads/master
Commit: 1079a3206c58dc053ad6d9ca4ead6446a1c9be80
Parents: 65af9ea
Author: Wes McKinney <wes.mckinney@twosigma.com>
Authored: Tue Dec 27 18:04:28 2016 -0500
Committer: Wes McKinney <wes.mckinney@twosigma.com>
Committed: Tue Dec 27 18:04:28 2016 -0500

----------------------------------------------------------------------
 cpp/src/arrow/array.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/arrow/blob/1079a320/cpp/src/arrow/array.h
----------------------------------------------------------------------
diff --git a/cpp/src/arrow/array.h b/cpp/src/arrow/array.h
index 26d53f7..5cd56d6 100644
--- a/cpp/src/arrow/array.h
+++ b/cpp/src/arrow/array.h
@@ -147,7 +147,9 @@ class ARROW_EXPORT NumericArray : public PrimitiveArray {
     return PrimitiveArray::EqualsExact(static_cast<const PrimitiveArray&>(other));
   }
 
-  bool ApproxEquals(const std::shared_ptr<Array>& arr) const { return Equals(arr);
}
+  bool ApproxEquals(const std::shared_ptr<Array>& arr) const override {
+    return Equals(arr);
+  }
 
   bool RangeEquals(int32_t start_idx, int32_t end_idx, int32_t other_start_idx,
       const ArrayPtr& arr) const override {


Mime
View raw message