Mailing-List: contact commits-help@arrow.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@arrow.apache.org
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: wesm@apache.org
To: commits@arrow.apache.org
Message-Id: <0a2328d8f5c349ba95bf2f66503aef2c@git.apache.org>
Subject: arrow git commit: ARROW-244: Some global APIs of IPC module should be
 visible to the outside
Date: Mon,  1 Aug 2016 18:29:09 +0000 (UTC)
archived-at: Mon, 01 Aug 2016 18:29:11 -0000

Repository: arrow
Updated Branches:
  refs/heads/master a2fb756a4 -> dc79ceb05


ARROW-244: Some global APIs of IPC module should be visible to the outside

Author: Jihoon Son <jihoonson@apache.org>

Closes #109 from jihoonson/ARROW-244 and squashes the following commits:

51d9a87 [Jihoon Son] Make line length shorter than 90
2da5466 [Jihoon Son] Make some APIs of IPC module visible


Project: http://git-wip-us.apache.org/repos/asf/arrow/repo
Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/dc79ceb0
Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/dc79ceb0
Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/dc79ceb0

Branch: refs/heads/master
Commit: dc79ceb05c05e626e2324863cfc3f386ecccce90
Parents: a2fb756
Author: Jihoon Son <jihoonson@apache.org>
Authored: Mon Aug 1 11:29:02 2016 -0700
Committer: Wes McKinney <wesm@apache.org>
Committed: Mon Aug 1 11:29:02 2016 -0700

----------------------------------------------------------------------
 cpp/src/arrow/ipc/adapter.h | 11 +++++++----
 cpp/src/arrow/ipc/memory.h  |  5 +++--
 2 files changed, 10 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/arrow/blob/dc79ceb0/cpp/src/arrow/ipc/adapter.h
----------------------------------------------------------------------
diff --git a/cpp/src/arrow/ipc/adapter.h b/cpp/src/arrow/ipc/adapter.h
index 0d2b77f..a34a5c4 100644
--- a/cpp/src/arrow/ipc/adapter.h
+++ b/cpp/src/arrow/ipc/adapter.h
@@ -24,6 +24,8 @@
 #include <cstdint>
 #include <memory>
 
+#include "arrow/util/visibility.h"
+
 namespace arrow {
 
 class Array;
@@ -54,20 +56,21 @@ constexpr int kMaxIpcRecursionDepth = 64;
 //
 // Finally, the memory offset to the start of the metadata / data header is
 // returned in an out-variable
-Status WriteRowBatch(MemorySource* dst, const RowBatch* batch, int64_t position,
-    int64_t* header_offset, int max_recursion_depth = kMaxIpcRecursionDepth);
+ARROW_EXPORT Status WriteRowBatch(MemorySource* dst, const RowBatch* batch,
+    int64_t position, int64_t* header_offset,
+    int max_recursion_depth = kMaxIpcRecursionDepth);
 
 // int64_t GetRowBatchMetadata(const RowBatch* batch);
 
 // Compute the precise number of bytes needed in a contiguous memory segment to
 // write the row batch. This involves generating the complete serialized
 // Flatbuffers metadata.
-Status GetRowBatchSize(const RowBatch* batch, int64_t* size);
+ARROW_EXPORT Status GetRowBatchSize(const RowBatch* batch, int64_t* size);
 
 // ----------------------------------------------------------------------
 // "Read" path; does not copy data if the MemorySource does not
 
-class RowBatchReader {
+class ARROW_EXPORT RowBatchReader {
  public:
   static Status Open(
       MemorySource* source, int64_t position, std::shared_ptr<RowBatchReader>* out);

http://git-wip-us.apache.org/repos/asf/arrow/blob/dc79ceb0/cpp/src/arrow/ipc/memory.h
----------------------------------------------------------------------
diff --git a/cpp/src/arrow/ipc/memory.h b/cpp/src/arrow/ipc/memory.h
index c6fd7a7..377401d 100644
--- a/cpp/src/arrow/ipc/memory.h
+++ b/cpp/src/arrow/ipc/memory.h
@@ -25,6 +25,7 @@
 #include <string>
 
 #include "arrow/util/macros.h"
+#include "arrow/util/visibility.h"
 
 namespace arrow {
 
@@ -69,7 +70,7 @@ class BufferOutputStream : public OutputStream {
   int64_t position_;
 };
 
-class MemorySource {
+class ARROW_EXPORT MemorySource {
  public:
   // Indicates the access permissions of the memory source
   enum AccessMode { READ_ONLY, READ_WRITE };
@@ -100,7 +101,7 @@ class MemorySource {
 };
 
 // A memory source that uses memory-mapped files for memory interactions
-class MemoryMappedSource : public MemorySource {
+class ARROW_EXPORT MemoryMappedSource : public MemorySource {
  public:
   static Status Open(const std::string& path, AccessMode access_mode,
       std::shared_ptr<MemoryMappedSource>* out);