arrow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From w...@apache.org
Subject arrow git commit: ARROW-247: Missing explicit destructor in RowBatchReader causes an incomplete type error
Date Thu, 04 Aug 2016 22:29:06 GMT
Repository: arrow
Updated Branches:
  refs/heads/master 56835c338 -> 5df7d4dee


ARROW-247: Missing explicit destructor in RowBatchReader causes an incomplete type error

Author: Jihoon Son <jihoonson@apache.org>

Closes #111 from jihoonson/ARROW-247 and squashes the following commits:

cc7281c [Jihoon Son] Make destructor virtual
795d3d3 [Jihoon Son] Merge branch 'master' of https://github.com/apache/arrow into ARROW-247
df297ef [Jihoon Son] Trigger travis
65d64c8 [Jihoon Son] Make the comment into two line
9555260 [Jihoon Son] Add a comment
f671a32 [Jihoon Son] Add explicit destructor for RowBatchReader


Project: http://git-wip-us.apache.org/repos/asf/arrow/repo
Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/5df7d4de
Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/5df7d4de
Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/5df7d4de

Branch: refs/heads/master
Commit: 5df7d4dee5fd57e91d9bb83f44f2269f61b79fb3
Parents: 56835c3
Author: Jihoon Son <jihoonson@apache.org>
Authored: Thu Aug 4 15:29:01 2016 -0700
Committer: Wes McKinney <wesm@apache.org>
Committed: Thu Aug 4 15:29:01 2016 -0700

----------------------------------------------------------------------
 cpp/src/arrow/ipc/adapter.cc | 4 ++++
 cpp/src/arrow/ipc/adapter.h  | 2 ++
 2 files changed, 6 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/arrow/blob/5df7d4de/cpp/src/arrow/ipc/adapter.cc
----------------------------------------------------------------------
diff --git a/cpp/src/arrow/ipc/adapter.cc b/cpp/src/arrow/ipc/adapter.cc
index bac1172..84f7830 100644
--- a/cpp/src/arrow/ipc/adapter.cc
+++ b/cpp/src/arrow/ipc/adapter.cc
@@ -369,6 +369,10 @@ Status RowBatchReader::Open(MemorySource* source, int64_t position,
   return Status::OK();
 }
 
+// Here the explicit destructor is required for compilers to be aware of
+// the complete information of RowBatchReader::Impl class
+RowBatchReader::~RowBatchReader() {}
+
 Status RowBatchReader::GetRowBatch(
     const std::shared_ptr<Schema>& schema, std::shared_ptr<RowBatch>* out)
{
   return impl_->AssembleBatch(schema, out);

http://git-wip-us.apache.org/repos/asf/arrow/blob/5df7d4de/cpp/src/arrow/ipc/adapter.h
----------------------------------------------------------------------
diff --git a/cpp/src/arrow/ipc/adapter.h b/cpp/src/arrow/ipc/adapter.h
index a34a5c4..6231af6 100644
--- a/cpp/src/arrow/ipc/adapter.h
+++ b/cpp/src/arrow/ipc/adapter.h
@@ -78,6 +78,8 @@ class ARROW_EXPORT RowBatchReader {
   static Status Open(MemorySource* source, int64_t position, int max_recursion_depth,
       std::shared_ptr<RowBatchReader>* out);
 
+  virtual ~RowBatchReader();
+
   // Reassemble the row batch. A Schema is required to be able to construct the
   // right array containers
   Status GetRowBatch(


Mime
View raw message